From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id eurIF1fmZWErsgAAgWs5BA (envelope-from ) for ; Tue, 12 Oct 2021 21:47:35 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id 0CfcElfmZWFqCwAAbx9fmQ (envelope-from ) for ; Tue, 12 Oct 2021 19:47:35 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 91980FF10 for ; Tue, 12 Oct 2021 21:47:34 +0200 (CEST) Received: from localhost ([::1]:39632 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1maNkK-0003EY-Vb for larch@yhetil.org; Tue, 12 Oct 2021 15:47:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57644) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1maNjq-0003Cl-RE for guix-patches@gnu.org; Tue, 12 Oct 2021 15:47:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:42421) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1maNjq-0006LN-J3 for guix-patches@gnu.org; Tue, 12 Oct 2021 15:47:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1maNjq-0007jA-Fu for guix-patches@gnu.org; Tue, 12 Oct 2021 15:47:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#51064] [PATCH] gnu: fish: Update to 3.3.1 Resent-From: Filip Staffa Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 12 Oct 2021 19:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51064 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 51064@debbugs.gnu.org Received: via spool by 51064-submit@debbugs.gnu.org id=B51064.163406800629680 (code B ref 51064); Tue, 12 Oct 2021 19:47:02 +0000 Received: (at 51064) by debbugs.gnu.org; 12 Oct 2021 19:46:46 +0000 Received: from localhost ([127.0.0.1]:53967 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1maNjY-0007ia-SR for submit@debbugs.gnu.org; Tue, 12 Oct 2021 15:46:45 -0400 Received: from mail-4018.proton.ch ([185.70.40.18]:22809) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1maNUo-0007Dw-Oj for 51064@debbugs.gnu.org; Tue, 12 Oct 2021 15:31:33 -0400 Date: Tue, 12 Oct 2021 19:31:20 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=filipstaffa.net; s=protonmail; t=1634067083; bh=YaDQ+f7MDzWbbB9fiYVwuxeTG8TXrjnmFV6isdfKHTs=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=bcGnFjOT4kuiyvbXaa+JdKJfyywsc/QNY95o16jY7axYjHUVJKYseTSsDHC2/CX5E GXwsb+eiVLTIKVEnL00p9efPcsyeVAzeG9UqVqQjoEJY1zRi+uXgalKnPLHUOd3ENf nJhNZdb0d/ltUBv8RMJnjTTnt4cRVIkXZO4DfHkARUK+8ZC/U1xRUNj+PBGpPaEumR Yom478pZJIhyQo+mX/Y8qppZ8zsSFrxAJcdVeBP8yBVSjU7J6AooKLR256uYINYRwh /Fco1rXiCJgtV7sRmIG4BLuI3BvCpF68/N/KI5QJtN4Tpf+0F+36CpJ5XEx1aI+zts AHnStIrsudSdQ== Message-ID: In-Reply-To: <87h7dmuvzv.fsf@gnu.org> References: <20211006181722.138-1-gnu@filipstaffa.net> <87h7dmuvzv.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Mailman-Approved-At: Tue, 12 Oct 2021 15:46:43 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: Filip Staffa X-ACL-Warn: , Filip Staffa via Guix-patches From: Filip Staffa via Guix-patches via X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1634068055; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=YaDQ+f7MDzWbbB9fiYVwuxeTG8TXrjnmFV6isdfKHTs=; b=ub5cb7qFKaEewr+xkPH+l80cp/M41z3tgPCWJF/ir2Kp9IESLMA3s/Zf2n2aXQChkdF/OI B8Kdf7plty5Xc6YVYiNo6M7RXZJrNBmm3DlC6KrbOdCI3vyS7J3iIJ5ARHAaMWQbZ5pDqa pCJwIjjBXSVo7fx93qCN529sU4h7zkSIcOKm8kOW0T1NKKwb4bWGxqaAOPAq6ezzbKNOu8 i6aKLWJgiJzx/8NDiyMn+XjnWlOIGRnIshb98rElCta3axY2zArC6Ivzm8A30zrzDZKuKy 3G51DT8pMsOqR0Il90qGVTMOhQ3Q7PTzLCOR7z88xRUsO8kwZehVuaPs/PfWPQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1634068055; a=rsa-sha256; cv=none; b=bpKo90V/+HFS/9peJykX4zPU+U0Rr5Xzf+ggDuZmxoNZy8X/LfsTK+YKdR96Sosxip6eaN TDiTQvyPTjcOwWd4174vnN8EGHL2W8hVx/XaMx9SzItipsgHb2bh2E6VzX7G7UdHg3+1FJ sdA8Bnq7yV7vuxYNGGENHPzzU0lmdu+N4zdLA9cdLAZJLnBCDok0aPU+rigygl/lffMvCi w/1AmtLQvg/QnquqUiAupEk9jvM/0h/BMQI7naA+Ro7aygVXcMLX5xL9yHhaQKEWrdtTGf tsSFwy2OZOMrQDPdFSa6d0nlCawDy2lrk1kd1J4oHT/I2NBWhCwmrlRBOzfupw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=filipstaffa.net header.s=protonmail header.b=bcGnFjOT; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.42 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=filipstaffa.net header.s=protonmail header.b=bcGnFjOT; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 91980FF10 X-Spam-Score: -1.42 X-Migadu-Scanner: scn0.migadu.com X-TUID: D4/n5+ymh5Bp Hi Ludo=E2=80=99, thanks for checking the patch. It worked on my machine, so I have checked t= he test itself. It looks like in your case it failed on a precondition. It = checks the environment for processes matching Z*, and if it find any it fai= ls. Specifically this command (found here: https://github.com/fish-shell/fish-s= hell/blob/Integration_3.3.1/tests/checks/jobs.fish#L9 ): ps -o s | string match 'Z*' | count Would you be able to stop all such processes/run it in environment where th= is command returns 0? If not I would propose to close this patch and wait f= or next version of fish shell, it looks like they fixed the test to be less= flaky on Fish master branch. Regards, Filip =E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90 Original Me= ssage =E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90 On Tuesday, October 12th, 2021 at 17:02, Ludovic Court=C3=A8s wrote: > Hi Filip, > > Filip Staffa gnu@filipstaffa.net skribis: > > > - gnu/packages/shells.scm (fish): Update to 3.3.1 > > On x86_64-linux, I=E2=80=99m getting this test failure: > > --8<---------------cut here---------------start------------->8--- > > Testing file checks/invocation.fish ... ok (56 ms) > > Testing file checks/job-control-noninteractive.fish ... ok (14 ms) > > Testing file checks/job-control-not-a-tty.fish ... ok (8 ms) > > Testing file checks/job-ids.fish ... ok (13 ms) > > Testing file checks/jobs.fish ... Failure: > > The CHECK on line 18 wants: > > All clear of zombies. > > which failed to match line stdout:1: > > Found existing zombie processes. Clean up zombies before running this tes= t. > > Context: > > Found existing zombie processes. Clean up zombies before running this tes= t. <=3D does not match CHECK 'All clear of zombies.' on line 18 > > <=3D nothing to match CHECK 'Trigger process reaping' on line 28 > > <=3D nothing to match CHECK '1' on line 46 > > <=3D nothing to match CHECK 'Command' on line 50 > > <=3D nothing to match CHECK 'sleep' on line 51 > > <=3D nothing to match CHECK 'sleep' on line 52 > > <=3D nothing to match CHECK '0' on line 55 > > <=3D nothing to match CHECK 'Command' on line 66 > > <=3D nothing to match CHECK 'sleep' on line 67 > > <=3D nothing to match CHECK 'sleep' on line 68 > > <=3D nothing to match CHECK '1' on line 71 > > <=3D nothing to match CHECK '2' on line 75 > > <=3D nothing to match CHECK '1' on line 79 > > <=3D nothing to match CHECK '2' on line 82 > > <=3D nothing to match CHECK 'Command' on line 110 > > <=3D nothing to match CHECK 'sleep' on line 111 > > <=3D nothing to match CHECK 'sleep is done' on line 112 > > <=3D nothing to match CHECK '1' on line 113 > > <=3D nothing to match CHECK 'Command' on line 117 > > <=3D nothing to match CHECK 'sleep' on line 118 > > <=3D nothing to match CHECK '0' on line 119 > > <=3D nothing to match CHECK 'foo' on line 133 > > <=3D nothing to match CHECK 'caller' on line 134 > > when running command: > > ../test/root/bin/fish checks/jobs.fish > > Testing file checks/line-continuation.fish ... ok (6 ms) > > Testing file checks/line-number.fish ... ok (6 ms) > > Testing file checks/locale.fish ... ok (28 ms) > > --8<---------------cut here---------------end--------------->8--- > > Does that ring a bell? Any suggestions? > > Thanks, > > Ludo=E2=80=99.