unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Hilton Chain via Guix-patches via <guix-patches@gnu.org>
To: "Sergio Pastor Pérez" <sergio.pastorperez@outlook.es>
Cc: 64957@debbugs.gnu.org
Subject: [bug#64957] [PATCH vREVISION] gnu: Add python-fontmake.
Date: Mon, 31 Jul 2023 02:06:00 +0800	[thread overview]
Message-ID: <87o7jt1dh3.wl-hako@ultrarare.space> (raw) From: Hilton Chain <hako@ultrarare.space> (raw)
In-Reply-To: <DU2P193MB2132F9200C4E07100F136590F304A@DU2P193MB2132.EURP193.PROD.OUTLOOK.COM>

Hi Sergio,

On Sun, 30 Jul 2023 23:45:20 +0800,
Sergio Pastor Pérez wrote:
>
> * gnu/packages/fontutils.scm (python-fontmake): New variable.
> ---

Please adjust the commit message as well.

> +    (version "3.4.0")

The latest version is 3.6.1, can you update the definition for it?

> +    (build-system python-build-system)
> +    (propagated-inputs (list python-attrs

Please change the `propagated-inputs' field into `inputs'.

It's not necessary to propagate those inputs, as python-build-system
already wraps the final fontmake program to find them.

> +    (synopsis
> +     "Compile fonts from sources (UFO, Glyphs) to binary (OpenType, TrueType)")
> +    (description
> +     "Fontmake compiles fonts from various sources (.glyphs, .ufo, designspace) into binaries (.otf, .ttf). You can use it to create static instances and variable fonts.")

There are some format issues, which could also be found by running
`./pre-inst-env guix lint fontmake' in your Guix checkout, I have
attatched the output below.

--8<---------------cut here---------------start------------->8---
gnu/packages/fontutils.scm:535:5: fontmake@3.4.0: sentences in description should be followed by two spaces; possible infraction at 100
gnu/packages/fontutils.scm:535:0: fontmake@3.4.0: line 535 is way too long (171 characters)
gnu/packages/fontutils.scm:531:15: fontmake@3.4.0: permanent redirect from https://github.com/googlei18n/fontmake to https://github.com/googlefonts/fontmake
--8<---------------cut here---------------end--------------->8---

And... The REVISION in the `git send-email' part of the manual should
be replaced with a number, for example:

--8<---------------cut here---------------start------------->8---
$ git send-email --annotate -v2 \
      --to=ISSUE_NUMBER@debbugs.gnu.org -1
--8<---------------cut here---------------end--------------->8---

It's used in the [PATCH v...] part of the title.

Thanks




  reply	other threads:[~2023-07-30 18:40 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-30 15:35 [bug#64957] [PATCH] gnu: Add python-fontmake Sergio Pastor Pérez
2023-07-30 15:45 ` [bug#64957] [PATCH vREVISION] " Sergio Pastor Pérez
     [not found]   ` <hako@ultrarare.space>
2023-07-30 18:06     ` Hilton Chain via Guix-patches via [this message]
2023-07-30 22:22 ` [bug#64957] [PATCH v2] gnu: Add fontmake Sergio Pastor Pérez
2023-07-31  7:25   ` Hilton Chain via Guix-patches via
2023-07-31  8:29 ` [bug#64957] [PATCH v3] " Sergio Pastor Pérez
2023-07-31 16:39   ` Hilton Chain via Guix-patches via
2023-08-01  7:05 ` [bug#64957] [PATCH v4] " Sergio Pastor Pérez
2023-09-06  4:52   ` bug#64957: [PATCH] gnu: Add python-fontmake Maxim Cournoyer
     [not found] ` <handler.64957.D64957.16939759387992.notifdone@debbugs.gnu.org>
2023-09-06  5:25   ` [bug#64957] " Maxim Cournoyer
2023-09-06 17:22     ` Sergio Pastor Pérez
2023-09-06 18:43       ` Maxim Cournoyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o7jt1dh3.wl-hako@ultrarare.space \
    --to=guix-patches@gnu.org \
    --cc=64957@debbugs.gnu.org \
    --cc=hako@ultrarare.space \
    --cc=sergio.pastorperez@outlook.es \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).