unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Sughosha via Guix-patches via <guix-patches@gnu.org>
To: maxim.cournoyer@gmail.com
Cc: 57999@debbugs.gnu.org
Subject: [bug#57999] [PATCH] gnu: Add textpieces
Date: Wed, 28 Sep 2022 17:35:54 +0000	[thread overview]
Message-ID: <hIbSRv41X_s3LKsXCfvcu1hKe20yYm6Amz0RRrVlHwKXxqJIZ5ibjpzYl5xIF25wz_IflW3CHp8W_N45JGRpJOg1epcrm-8JC8UKdMML0j0=@proton.me> (raw)
In-Reply-To: <87y1u3v298.fsf@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 2387 bytes --]

Hi,

Thanks for reviewing. The problem is only that while validating the appstream it requires connecting to internet, but in Guix packaging works offline. Otherwise if built outside Guix, then it passes the test.

And, I will correct and send another patch file.

Sughosha

Gesendet von Proton Mail für Mobilgeräte

-------- Original-Nachricht --------
Am 28. Sept. 2022, 7:26 PM, schrieb Maxim Cournoyer :

> Hello, Sughosha  writes: > From: Sughosha  > > * gnu/packages/text-editors.scm (textpieces): New variable. [...] > +(define-public textpieces > + (package > + (name "textpieces") > + (version "3.2.0") > + (source (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/liferooter/textpieces") > + (commit (string-append "v" version)))) > + (sha256 > + (base32 > + "14zq2c7js80m4cq8wpdb3kyz5sw96l8znbz027w8s94gqhm632ff")))) > + (arguments > + `(#:tests? #f ;fails to validate appstream file Is this a known issue upstream? If so, it should be linked with a full sentence, for example: "The test suite fails validating the appstream file (see: https://www.upstream-issue-url)." > + #:glib-or-gtk? #t)) > + (build-system meson-build-system) > + (native-inputs (list pkg-config > + vala > + desktop-file-utils > + appstream-glib > + gettext-minimal > + `(,glib "bin") > + blueprint-compiler > + `(,gtk "bin"))) > + (inputs (list gtk > + libadwaita > + gtksourceview > + json-glib > + libgee > + python > + python-pygobject > + python-pyyaml)) Please sort the dependencies in lexicographical order. > + (home-page "https://github.com/liferooter/textpieces") > + (synopsis "Quick text processor") > + (description > + "Text Pieces tool for quick text transformations such as checksums, ^ is a tool > +encoding, decoding and so on. ^, etc. > +The basic features of Text Pieces are: > +@itemize > +@item Base64 encoding and decoding > +@item SHA-1, SHA-2 and MD5 checksums > +@item Prettify and minify JSON > +@item Covert JSON to YAML and vice versa > +@item Count lines, symbols and words > +@item Escape and unescape string, URL and HTML > +@item Remove leading and trailing whitespaces > +@item Sort and reverse sort lines > +@item Reverse lines and whole text > +@item You can write your own scripts and create custom tools > +@end itemize") > + (license license:gpl3))) The rest looks fine. It'd be nice to get the test suite passing. Thanks, Maxim

[-- Attachment #2: Type: text/html, Size: 3122 bytes --]

  reply	other threads:[~2022-09-28 18:00 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-22  6:23 [bug#57999] [PATCH] gnu: Add textpieces Sughosha via Guix-patches via
2022-09-28 17:26 ` Maxim Cournoyer
2022-09-28 17:35   ` Sughosha via Guix-patches via [this message]
2022-10-16 18:27     ` Christopher Baines
2022-10-17  5:19       ` Sughosha via Guix-patches via
2022-10-18 10:15         ` bug#57999: " Christopher Baines

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='hIbSRv41X_s3LKsXCfvcu1hKe20yYm6Amz0RRrVlHwKXxqJIZ5ibjpzYl5xIF25wz_IflW3CHp8W_N45JGRpJOg1epcrm-8JC8UKdMML0j0=@proton.me' \
    --to=guix-patches@gnu.org \
    --cc=57999@debbugs.gnu.org \
    --cc=Sughosha@proton.me \
    --cc=maxim.cournoyer@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).