From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id +LWADdkFh2YXeAAA62LTzQ:P1 (envelope-from ) for ; Thu, 04 Jul 2024 20:28:09 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id +LWADdkFh2YXeAAA62LTzQ (envelope-from ) for ; Thu, 04 Jul 2024 22:28:09 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=rimm.ee header.s=herman header.b="CSE/rXMx"; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1720124889; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=L87CH8sIioWjO64Wp57LHX/bc7lCZcESmrMWZ4kh/4I=; b=rZgZ7TveX8pjz4/OZmzGoycNUHOOwq3Z00ch/YfIjqrzcFYbiGBaqbjbaeSGUecpzr25TU JIBV2stVnYnClC2aWcbxdynFY2e4IpovBs6SkGLbntwbR6ioNHURulw64XosP7iWOxtppv SFoHQrmGwgRKQZZwlmtJ4AsKQhM8WISh/XfPOvu0Kkykb7xXv45IoZBpUlEhHXBxCnh5dN c83NNA0uyZGl1ik5xcj+0Z2NU9TxHPOwYM6nT8rDP5r81ixsZtAlg6cfUPa3ouTBAy1FMk 9OAYzsobr77LC2tsQnl3ZXuXaV17JuclPig8YgUzXwmk9l7VordkzxsWijxsOQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=rimm.ee header.s=herman header.b="CSE/rXMx"; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1720124889; a=rsa-sha256; cv=none; b=OetPRX/Gl5aKFUARQE5iploGl8ZQhC8VTN7x2bkDonF7KpD20cnKBuUxcoZdZmDomvuzvL TOZQ13E0DObdaaby9RwQXuY8sWDzVOVewlc/oxdtzV3I0Di3c+yZHQhzlrIsIL2mV24fDR fiSu8G3lKliUjB+/C6yJR2cTHwRy8j9x3eUxZxgMpObIoZBel/IJ0+dk4L61UFHoLN2vY/ pILyUm99jumyff8Gh2mnyGulfVkHMpjyJoLT1JdWYSMCvcV5v0NR8XMtlaKamdCY5BGF/J 5Kyvc5ryYrSnStDwkbGIKTkGbKC9NALmWSittvJK4g75K2CwF/uVc+NxvScz2Q== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id CCB3F135F9 for ; Thu, 4 Jul 2024 22:28:08 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sPT3m-0001ep-Np; Thu, 04 Jul 2024 16:28:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sPT3f-0001YC-MT for guix-patches@gnu.org; Thu, 04 Jul 2024 16:28:01 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sPT3f-0001vj-CU for guix-patches@gnu.org; Thu, 04 Jul 2024 16:27:59 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sPT3h-0007ct-TY for guix-patches@gnu.org; Thu, 04 Jul 2024 16:28:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#70499] [PATCH v2 0/3] Lint package order. Resent-From: Herman Rimm Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 04 Jul 2024 20:28:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70499 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: Josselin Poiret , Simon Tournier , Mathieu Othacehe , Tobias Geerinckx-Rice , Florian Pelz , Ricardo Wurmus , Christopher Baines , 70499@debbugs.gnu.org Received: via spool by 70499-submit@debbugs.gnu.org id=B70499.172012483229253 (code B ref 70499); Thu, 04 Jul 2024 20:28:01 +0000 Received: (at 70499) by debbugs.gnu.org; 4 Jul 2024 20:27:12 +0000 Received: from localhost ([127.0.0.1]:43177 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sPT2u-0007bl-IJ for submit@debbugs.gnu.org; Thu, 04 Jul 2024 16:27:12 -0400 Received: from 81-205-150-117.fixed.kpn.net ([81.205.150.117]:36745 helo=email.rimm.ee) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sPT2s-0007bW-Ex for 70499@debbugs.gnu.org; Thu, 04 Jul 2024 16:27:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rimm.ee; s=herman; t=1720124819; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=L87CH8sIioWjO64Wp57LHX/bc7lCZcESmrMWZ4kh/4I=; b=CSE/rXMx8ByAp5AwLulUCwV4sWE2rwUnIQU9MoyOlTNM2nXxYmY9wsmB9i5FM6WoI+Pozb 6nSwOEKXkodk22799bJsks0h3YFdT8gtqZhw7F2jHenVN6zWeVssPytBvmLZXuOJNqc3B6 ZO5zKfRfbwLgg4d2u4SzaUQakWYCn1pyH0jJBaLsC1Mfk6kMqVIPP3qBD2MUemXaJntEZd h35qvR66py6mm8jiMIZjwx8g3PeihyhFgfnj2SN0FyS23TRIdZG+p3YO4/INybp2dR8WNN v9FxiOaQs3wHefevEeqDVV0123jt8JdlzMYJbSOqYBflHFS9XXgMj+HS+sm3sg== Received: by 81-205-150-117.fixed.kpn.net (OpenSMTPD) with ESMTPSA id 0801a816 (TLSv1.3:TLS_CHACHA20_POLY1305_SHA256:256:NO); Thu, 4 Jul 2024 20:26:59 +0000 (UTC) Date: Thu, 4 Jul 2024 22:26:37 +0200 Message-ID: References: <1f19f015e714d68c84cd91618b1340365c8363bb.1713722288.git.herman@rimm.ee> <87a5ke0yve.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87a5ke0yve.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Herman Rimm X-ACL-Warn: , Herman Rimm via Guix-patches From: Herman Rimm via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Queue-Id: CCB3F135F9 X-Migadu-Scanner: mx13.migadu.com X-Migadu-Spam-Score: -4.89 X-Spam-Score: -4.89 X-TUID: D1qySHcOaOXu Hello, On Sat, May 25, 2024 at 04:06:45PM +0200, Ludovic Courtès wrote: > > However the alphabetical order lint warnings only appear once another > > type of lint warning is emitted, or when end of file is reached and > > linting finishes. So if few checkers are enabled, it takes a few seconds > > before anything is output for large module files, like 'crates-io.scm'. > > Can this be fixed easily? > > I’m not sure I understand. The alpabetical checker is part of another > patch set, right? (I know I’ve seen it, but I’m afraid I’ve lost track > of it. :-)) > > Anyway, we can and should discuss ‘--whole-file’ independently of the > alphabetical-order checker. I added the '--alphabetical-sort' option to guix style in [bug#70800]. For guix lint, the alphabetical checker is added in [PATCH 3/3]. It runs only when '--whole-file' is specified. It cannot be toggled with -c or -x because it is not a normal checker, because run-checkers only runs on a single package at a time. It could be a normal checker if given a package, the preceding package can be retrieved. It could be stored as a parameter. How would you get the preceding package? > > guix: Move ‘package-location > ui: Make 'user-module' parameter of 'load*' optional. > > scripts: lint: Add 'whole-file' option with ordering lint. > > This LGTM modulo minor issues: > > • The second patch looks unrelated to ‘--whole-file’, I’d drop it from > this series. I use load* on the specified file(s). I could instead add a --modules= MODULE1,MODULE2... option to be used with -L when necessary. Cheers, Herman