From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id oG4KFKDSEWXlVgAA9RJhRA:P1 (envelope-from ) for ; Mon, 25 Sep 2023 20:34:08 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id oG4KFKDSEWXlVgAA9RJhRA (envelope-from ) for ; Mon, 25 Sep 2023 20:34:08 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id BAF5C64946 for ; Mon, 25 Sep 2023 20:34:07 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=EiQDUO8k; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1695666848; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=jNIeeTi86oveBooKjZ1hnS872r35pplELvxuVLI1HkA=; b=ZnubNADDRNa/Tjx5pwg6Bi5wMU8mbx78F+jM6dTZErtOkkGihUAvsCrz9xUucnjAUAKNJw hXSL3uUSj2lajoPXPO8hHx2YM5BctjAVYhpJ9TdPz8Le0OGAr4TL1AweI1TLEDx3EHjhaz lcQEunVFh8zdkADXgnw3pWl4nGKnguTbefbVBsxDdHmQ9GetvGKUdVfhZV7d8ae8W6Oa5t mETFwSVLGM+BheAliXz9yTbYd8NPE9KlfMGboJi7uMQnjY/36zj26C3yDbBsIbXRFbxCQm YYgPYXJzeIM2mx6Xn1ZY/yHAH515XzeqwgdquNmFDmazjCRlqFA7wzep3uZeag== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1695666848; a=rsa-sha256; cv=none; b=W+kc/p+LgSm0LXxpx/5HAWqa/mVJbpP+ndbsF7IvYV4KtwTb0mRr6A2/kXpprnqZf4HF0T h01IY3ZE1BM93awwOMOwnHoJkYp5dzIRgnXskYzeljKBF2YiFCM6xj35aToMl8gGwPjnmO KmfkmIIzZif5ondxvOuYTu0DBYV4oEFCej4lEZmx4NQm/MM1gwuYDhaj4MEdMC8TBjf3TQ 0v6UBcM5qbo/E/rD6c9HYAJOKn8whNPzV2Cur8pVldIUQde3kQdChk2hT05XL/DzKvDkWT vv8hIOsi568e99/YfomXcN22DJPp8YYhskCIaX1zDfZeZ6u/IvymWNzD03A6hA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=EiQDUO8k; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qkqMW-00077r-Eb; Mon, 25 Sep 2023 14:31:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qkqM7-000727-Ql for guix-patches@gnu.org; Mon, 25 Sep 2023 14:30:54 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qkqM6-0008D8-0C for guix-patches@gnu.org; Mon, 25 Sep 2023 14:30:50 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qkqMI-0001NI-57 for guix-patches@gnu.org; Mon, 25 Sep 2023 14:31:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#66110] [PATCH] gnu: desmume: Update to 0.9.13. Resent-From: Liliana Marie Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 25 Sep 2023 18:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66110 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Hendursaga , 66110@debbugs.gnu.org Received: via spool by 66110-submit@debbugs.gnu.org id=B66110.16956666285223 (code B ref 66110); Mon, 25 Sep 2023 18:31:02 +0000 Received: (at 66110) by debbugs.gnu.org; 25 Sep 2023 18:30:28 +0000 Received: from localhost ([127.0.0.1]:46651 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qkqLj-0001MB-SS for submit@debbugs.gnu.org; Mon, 25 Sep 2023 14:30:28 -0400 Received: from mail-ed1-x543.google.com ([2a00:1450:4864:20::543]:43060) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qkqLf-0001Lo-Uf for 66110@debbugs.gnu.org; Mon, 25 Sep 2023 14:30:26 -0400 Received: by mail-ed1-x543.google.com with SMTP id 4fb4d7f45d1cf-530fa34ab80so18361405a12.0 for <66110@debbugs.gnu.org>; Mon, 25 Sep 2023 11:30:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695666605; x=1696271405; darn=debbugs.gnu.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:from:to:cc:subject:date :message-id:reply-to; bh=jNIeeTi86oveBooKjZ1hnS872r35pplELvxuVLI1HkA=; b=EiQDUO8kwr6BCsAEmr8o9B3esNSOUcAtLbYozNpqJCMIpIRIyxT1EEefrXCq+0etQz eb4/pS06x6/M6UgaTm3bUHfaym1xAke5RTNkywuSVwTwAz8DLCWJhZ18WXBqD2K+mtBx wZ2lgG+riZ+YmVZxH72NzlEeGn7i8ZO9jynl3QxWmmWEW7DeGxjCAvrWDI+qjVi20n/E pTmNA8gNU9g2rGvMaz05DV27aSfho7a2nSWkj/FT8GiK6XLqLpaG8hdQoAB1WNPHzdTF p00byETXt0SnatngO5dXGGBsxZGivgNQVsj/yQVdTRK02r1TY9OAt5CnEb/px7Lk+O+U NucA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695666605; x=1696271405; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=jNIeeTi86oveBooKjZ1hnS872r35pplELvxuVLI1HkA=; b=NUu83bUm/y2KSDi8PfeWpNEGr7MmBscO5ezcHbciVHXcyuEh1N7uCGiSAhVrK7NsPM fZ/3alo5yL3gv0BYJ8iWpSvIzZQoz7ChudptjNNq5w7j7uv1ItkjA90k2fPPlDrCHx1E j2Lfc73O25aKKrQs0vNOF1MrPfdlaPOQgU/5s4irVj3G7nRIlzKHx6Q4MAnDB0Etk4kD aMU8Y2JjOnMxU/hByxyzyjx5BSLMGIUxgxLO4uaea6nvOZelM5/iuKCbojRZvh1Rc4Dp fXvIySyB85MVmeaZm+25B522BdggqtS7d1xCmjousqxe7xffpiVGPzicLDXR8ztIpIca UtPA== X-Gm-Message-State: AOJu0YzK+PNQvL01h/tR88f7u3Vp30EKbRAwXK2SeJunOiR1/YqnW4PY KLSyj+eH4XJ6TQD8MtQhmTs= X-Google-Smtp-Source: AGHT+IHu79wuajzMZtuOfE7oh/HKLXC5JOkskpR+8gn5ErkjLfEUD6oPLo9zwmMG4yR0NL/WirJvYA== X-Received: by 2002:a17:907:3f0a:b0:9ad:93c8:c483 with SMTP id hq10-20020a1709073f0a00b009ad93c8c483mr838537ejc.2.1695666605096; Mon, 25 Sep 2023 11:30:05 -0700 (PDT) Received: from lumine.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id p26-20020a170906229a00b009ad8338aafasm6786049eja.13.2023.09.25.11.30.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Sep 2023 11:30:03 -0700 (PDT) Message-ID: From: Liliana Marie Prikler Date: Mon, 25 Sep 2023 20:30:02 +0200 In-Reply-To: <87bkdq41kk.fsf@aol.com> References: <3f84777ee9f4369d2aa6203f4a8b9a5775672a78.1695156110.git.hendursaga.ref@aol.com> <3f84777ee9f4369d2aa6203f4a8b9a5775672a78.1695156110.git.hendursaga@aol.com> <8526fd2b152008805f21f8afe14d419d967c3ccb.camel@gmail.com> <87bkdq41kk.fsf@aol.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4 MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Spam-Score: 4.23 X-Migadu-Spam-Score: 4.23 X-Migadu-Scanner: mx1.migadu.com X-Migadu-Queue-Id: BAF5C64946 X-TUID: ZGczGgkUY4cT Am Montag, dem 25.09.2023 um 13:14 -0400 schrieb Hendursaga: > Liliana Marie Prikler writes: >=20 > > Some stylistic choices in the ChangeLog are a little weird; overall > > however LGTM. >=20 > Not sure what exactly is wrong. I was diligent to look through dozens > of previous commits by others to look for patterns to use. Is there > some sort of "linter" for GNU-style ChangeLogs? For reference, here's the way I'd write it: > * gnu/packages/emulators.scm (desmume): Update to 0.9.13. > [source]: Switch to git-fetch. Remove patches. > [build-system]: Switch to meson-build-system. > [arguments]<#:configure-flags>: Replace =E2=80=9C--enable-openal=E2=80=9D= with =E2=80=9C- > Dopenal=3Dtrue=E2=80=9D. > Remove =E2=80=9C--enable-wifi=E2=80=9D. > Add =E2=80=9C-Dfrontend-cli=3Dtrue=E2=80=9D, =E2=80=9C-Dfrontend-gtk=3Dtr= ue=E2=80=9D, and =E2=80=9C-Dgdb- > stub=3Dtrue=E2=80=9D. > <#:phases>: Add =E2=80=98chdir=E2=80=99. > [native-inputs]: Add glib:bin and gettext-minimal. > [inputs]: Replace sdl with sdl2 and gtk+-2 with gtk+. > Remove glu. > Add agg, alsa-lib, libpcap, openal, and soundtouch. > [home-page]: Use HTTPS. > * gnu/packages/patches/desmume-gcc6-fixes.patch: Removed file. > * gnu/packages/patches/desmume-gcc7-fixes.patch: Likewise. > * gnu/local.mk (dist_patch_DATA): Adjust accordingly. The most important changes are clearly delimited configure flags and two spaces instead of one. I also split some lines that technically could remain squashed together, but that's minor imho. > > Testing locally, because it failed to apply on CI =E2=80=93 maybe the D= KIM > > signature breaks things?=C2=A0 It looks broken, what with those > > gratuitous newlines.=C2=A0 If all checks pass, then I'll push this with > > minor adjustments after the grace week. >=20 > Not quite sure why it failed to apply on CI. I used `git-send-email` > and all. I doubt I have any control over DKIM signatures. I > downloaded the raw email from the web interface and `git am`'d it > successfully, although it did warn about a quoted CRLF.. Thought so, just wanted you to know. Cheers