unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* bug#26736: [PATCH] gnu: libgc: Fix Check for Hurd systems.
@ 2017-05-01 15:47 rennes
  2017-05-02 11:30 ` Manolis Ragkousis
  0 siblings, 1 reply; 4+ messages in thread
From: rennes @ 2017-05-01 15:47 UTC (permalink / raw)
  To: 26736

[-- Attachment #1: Type: text/plain, Size: 454 bytes --]

This patch is libgc for core-updates.

On GNU/Hurd systems during the 'Check' phase, there is a deadlock  
caused by the 'gctest' test.

We set "--disable-gcj-support" to configure script to pass the 'gctest'  
test.

bug report:
https://lists.opendylan.org/pipermail/bdwgc/2017-April/006275.html
discussion:
https://lists.gnu.org/archive/html/bug-hurd/2017-01/msg00008.html

Tested in Linux-x86_64, Hurd and cross-compiling (master branch).

[-- Attachment #2: 0001-gnu-libgc-Fix-Check-for-Hurd-systems.patch --]
[-- Type: text/x-patch, Size: 2372 bytes --]

From 3369231f100c0195f04ee6e76e19dc1ffbd99e10 Mon Sep 17 00:00:00 2001
From: rennes <rennes@openmailbox.org>
Date: Mon, 1 May 2017 08:41:04 -0500
Subject: [PATCH] gnu: libgc: Fix Check for Hurd systems.

* gnu/packages/bdw-gc.scm (libgc)[arguments]: On GNU/Hurd systems
add '--disable-gcj-support' to #:configure-flags. Adjust #:configure-flags
to disable GCJ support and pass the 'gctest' test.
---
 gnu/packages/bdw-gc.scm | 20 +++++++++++++++++---
 1 file changed, 17 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/bdw-gc.scm b/gnu/packages/bdw-gc.scm
index b9732374d..790a23857 100644
--- a/gnu/packages/bdw-gc.scm
+++ b/gnu/packages/bdw-gc.scm
@@ -2,6 +2,7 @@
 ;;; Copyright © 2012, 2013, 2014, 2016 Ludovic Courtès <ludo@gnu.org>
 ;;; Copyright © 2014 Mark H Weaver <mhw@netris.org>
 ;;; Copyright © 2016 Leo Famulari <leo@famulari.name>
+;;; Copyright © 2017 Rene Saavedra <rennes@openmailbox.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -23,7 +24,8 @@
   #:use-module (guix packages)
   #:use-module (guix download)
   #:use-module (guix build-system gnu)
-  #:use-module (gnu packages pkg-config))
+  #:use-module (gnu packages pkg-config)
+  #:use-module (gnu packages hurd))
 
 (define-public libgc
   (package
@@ -38,8 +40,20 @@
               "143x7g0d0k6250ai6m2x3l4y352mzizi4wbgrmahxscv2aqjhjm1"))))
    (build-system gnu-build-system)
    (arguments
-    '(#:configure-flags '(;; Install gc_cpp.h et al.
-                          "--enable-cplusplus")))
+    `(#:configure-flags
+      (list
+       ;; Install gc_cpp.h et al.
+       "--enable-cplusplus"
+       ;; In GNU/Hurd systems during the 'Check' phase,
+       ;; there is a deadlock caused by the 'gctest' test.
+       ;; To disable the error set "--disable-gcj-support"
+       ;; to configure script. See bug report and discussion:
+       ;; <https://lists.opendylan.org/pipermail/bdwgc/2017-April/006275.html>
+       ;; <https://lists.gnu.org/archive/html/bug-hurd/2017-01/msg00008.html>
+       ,@(if (hurd-triplet? (or (%current-system)
+                                (%current-target-system)))
+             '("--disable-gcj-support")
+             '()))))
    (native-inputs `(("pkg-config" ,pkg-config)))
    (inputs `(("libatomic-ops" ,libatomic-ops)))
    (outputs '("out" "debug"))
-- 
2.12.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* bug#26736: [PATCH] gnu: libgc: Fix Check for Hurd systems.
  2017-05-01 15:47 bug#26736: [PATCH] gnu: libgc: Fix Check for Hurd systems rennes
@ 2017-05-02 11:30 ` Manolis Ragkousis
  2019-01-06  0:57   ` Kei Kebreau
  0 siblings, 1 reply; 4+ messages in thread
From: Manolis Ragkousis @ 2017-05-02 11:30 UTC (permalink / raw)
  To: rennes; +Cc: 26736

Hello Rene,

LGTM.

I will push it to core-updates.

Thank you,
Manolis

On 05/01/2017 06:47 PM, rennes wrote:
> This patch is libgc for core-updates.
> 
> On GNU/Hurd systems during the 'Check' phase, there is a deadlock caused
> by the 'gctest' test.
> 
> We set "--disable-gcj-support" to configure script to pass the 'gctest'
> test.
> 
> bug report:
> https://lists.opendylan.org/pipermail/bdwgc/2017-April/006275.html
> discussion:
> https://lists.gnu.org/archive/html/bug-hurd/2017-01/msg00008.html
> 
> Tested in Linux-x86_64, Hurd and cross-compiling (master branch).

^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#26736: [PATCH] gnu: libgc: Fix Check for Hurd systems.
  2017-05-02 11:30 ` Manolis Ragkousis
@ 2019-01-06  0:57   ` Kei Kebreau
  2019-01-06  1:09     ` [bug#26736] " Manolis Ragkousis
  0 siblings, 1 reply; 4+ messages in thread
From: Kei Kebreau @ 2019-01-06  0:57 UTC (permalink / raw)
  To: 26736-done

This patch was pushed several months ago.

Manolis Ragkousis <manolis837@gmail.com> writes:

> Hello Rene,
>
> LGTM.
>
> I will push it to core-updates.
>
> Thank you,
> Manolis
>
> On 05/01/2017 06:47 PM, rennes wrote:
>> This patch is libgc for core-updates.
>> 
>> On GNU/Hurd systems during the 'Check' phase, there is a deadlock caused
>> by the 'gctest' test.
>> 
>> We set "--disable-gcj-support" to configure script to pass the 'gctest'
>> test.
>> 
>> bug report:
>> https://lists.opendylan.org/pipermail/bdwgc/2017-April/006275.html
>> discussion:
>> https://lists.gnu.org/archive/html/bug-hurd/2017-01/msg00008.html
>> 
>> Tested in Linux-x86_64, Hurd and cross-compiling (master branch).

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [bug#26736] [PATCH] gnu: libgc: Fix Check for Hurd systems.
  2019-01-06  0:57   ` Kei Kebreau
@ 2019-01-06  1:09     ` Manolis Ragkousis
  0 siblings, 0 replies; 4+ messages in thread
From: Manolis Ragkousis @ 2019-01-06  1:09 UTC (permalink / raw)
  To: 26736-done, kkebreau, rennes

Hello Kei,

Was this ticket still open? I will close it now.

Thank you,
Manolis

On 1/6/19 2:57 AM, Kei Kebreau wrote:
> This patch was pushed several months ago.
> 
> Manolis Ragkousis <manolis837@gmail.com> writes:
> 
>> Hello Rene,
>>
>> LGTM.
>>
>> I will push it to core-updates.
>>
>> Thank you,
>> Manolis
>>
>> On 05/01/2017 06:47 PM, rennes wrote:
>>> This patch is libgc for core-updates.
>>>
>>> On GNU/Hurd systems during the 'Check' phase, there is a deadlock caused
>>> by the 'gctest' test.
>>>
>>> We set "--disable-gcj-support" to configure script to pass the 'gctest'
>>> test.
>>>
>>> bug report:
>>> https://lists.opendylan.org/pipermail/bdwgc/2017-April/006275.html
>>> discussion:
>>> https://lists.gnu.org/archive/html/bug-hurd/2017-01/msg00008.html
>>>
>>> Tested in Linux-x86_64, Hurd and cross-compiling (master branch).
> 
> 
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-01-06  1:10 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-05-01 15:47 bug#26736: [PATCH] gnu: libgc: Fix Check for Hurd systems rennes
2017-05-02 11:30 ` Manolis Ragkousis
2019-01-06  0:57   ` Kei Kebreau
2019-01-06  1:09     ` [bug#26736] " Manolis Ragkousis

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).