unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Maxime Devos <maximedevos@telenet.be>
To: iyzsong@outlook.com, 54293@debbugs.gnu.org
Cc: 宋文武 <iyzsong@member.fsf.org>
Subject: [bug#54293] [PATCH v2] home: Add home-git-service-type.
Date: Sat, 12 Mar 2022 10:54:15 +0100	[thread overview]
Message-ID: <ff9bfdb70d653047dcd564164fca568417a9d120.camel@telenet.be> (raw)
In-Reply-To: <TYCP286MB18973CA5D0DD1447744E30FAA30D9@TYCP286MB1897.JPNP286.PROD.OUTLOOK.COM>

[-- Attachment #1: Type: text/plain, Size: 427 bytes --]

iyzsong@outlook.com schreef op za 12-03-2022 om 10:22 [+0800]:
> + (user.name
> +   (git-option-value *unspecified*))

I think *unspecified* is considered an implementation detail. Proposal:
let it be #false by default, and don't serialize the option whenever it
is #false.

Also, I don't think that user names can be #false, #true or integers. 
Perhaps a 'git-string-value' would be useful?

Greetings,
Maxime.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]

  parent reply	other threads:[~2022-03-12  9:55 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-07 14:51 [bug#54293] [WIP] home: Add home-git-service-type 宋文武
2022-03-07 17:58 ` Maxime Devos
2022-03-09 12:18   ` 宋文武
2022-03-07 18:01 ` Maxime Devos
2022-03-07 18:12   ` Maxime Devos
2022-03-07 18:02 ` Maxime Devos
2022-03-07 18:04 ` Maxime Devos
2022-03-07 18:11 ` Maxime Devos
2022-03-09 12:50   ` 宋文武
2022-03-12 22:27     ` Maxime Devos
2022-03-12  2:22 ` [bug#54293] [PATCH v2] " iyzsong
2022-03-12  9:51   ` Maxime Devos
2022-03-12  9:54   ` Maxime Devos [this message]
2022-03-29 13:56     ` [bug#54293] [WIP] " Ludovic Courtès
2022-03-12  9:58   ` [bug#54293] [PATCH v2] " Maxime Devos
2022-03-12 10:02   ` Maxime Devos
2022-03-12 10:03   ` Maxime Devos
2022-03-12 10:11   ` Maxime Devos
2022-03-12 10:12   ` Maxime Devos
2022-03-12 10:21   ` Maxime Devos
2022-03-12 10:24   ` Maxime Devos
2022-03-12 10:26   ` Maxime Devos
2022-03-12 10:31   ` Maxime Devos
2022-03-12 10:39   ` Maxime Devos
2022-05-21 13:47   ` [bug#54293] [WIP] " Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ff9bfdb70d653047dcd564164fca568417a9d120.camel@telenet.be \
    --to=maximedevos@telenet.be \
    --cc=54293@debbugs.gnu.org \
    --cc=iyzsong@member.fsf.org \
    --cc=iyzsong@outlook.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).