From: Liliana Marie Prikler <liliana.prikler@gmail.com>
To: Hendursaga <hendursaga@aol.com>, 66110-done@debbugs.gnu.org
Subject: bug#66110: [PATCH] gnu: desmume: Update to 0.9.13.
Date: Sun, 01 Oct 2023 10:16:49 +0200 [thread overview]
Message-ID: <fec736377f09379c93f5a062ab562481cfc45922.camel@gmail.com> (raw)
In-Reply-To: <ffc8ab9d7c958e759ccbeec0cb9e4c12a5896a11.camel@gmail.com>
Am Montag, dem 25.09.2023 um 20:30 +0200 schrieb Liliana Marie Prikler:
> Am Montag, dem 25.09.2023 um 13:14 -0400 schrieb Hendursaga:
> > Liliana Marie Prikler <liliana.prikler@gmail.com> writes:
> >
> > > Some stylistic choices in the ChangeLog are a little weird;
> > > overall
> > > however LGTM.
> >
> > Not sure what exactly is wrong. I was diligent to look through
> > dozens
> > of previous commits by others to look for patterns to use. Is there
> > some sort of "linter" for GNU-style ChangeLogs?
>
> For reference, here's the way I'd write it:
> > * gnu/packages/emulators.scm (desmume): Update to 0.9.13.
> > [source]: Switch to git-fetch. Remove patches.
> > [build-system]: Switch to meson-build-system.
> > [arguments]<#:configure-flags>: Replace “--enable-openal” with “-
> > Dopenal=true”.
> > Remove “--enable-wifi”.
> > Add “-Dfrontend-cli=true”, “-Dfrontend-gtk=true”, and “-Dgdb-
> > stub=true”.
> > <#:phases>: Add ‘chdir’.
> > [native-inputs]: Add glib:bin and gettext-minimal.
> > [inputs]: Replace sdl with sdl2 and gtk+-2 with gtk+.
> > Remove glu.
> > Add agg, alsa-lib, libpcap, openal, and soundtouch.
> > [home-page]: Use HTTPS.
> > * gnu/packages/patches/desmume-gcc6-fixes.patch: Removed file.
> > * gnu/packages/patches/desmume-gcc7-fixes.patch: Likewise.
> > * gnu/local.mk (dist_patch_DATA): Adjust accordingly.
> The most important changes are clearly delimited configure flags and
> two spaces instead of one. I also split some lines that technically
> could remain squashed together, but that's minor imho.
Pushed with the above adjustments. Thanks
prev parent reply other threads:[~2023-10-01 8:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <3f84777ee9f4369d2aa6203f4a8b9a5775672a78.1695156110.git.hendursaga.ref@aol.com>
2023-09-19 20:42 ` [bug#66110] [PATCH] gnu: desmume: Update to 0.9.13 Hendursaga via Guix-patches via
2023-09-21 17:05 ` Liliana Marie Prikler
2023-09-25 17:14 ` Hendursaga via Guix-patches via
2023-09-25 18:30 ` Liliana Marie Prikler
2023-10-01 8:16 ` Liliana Marie Prikler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fec736377f09379c93f5a062ab562481cfc45922.camel@gmail.com \
--to=liliana.prikler@gmail.com \
--cc=66110-done@debbugs.gnu.org \
--cc=hendursaga@aol.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).