From: Bruno Victal <mirai@makinata.eu>
To: 67842@debbugs.gnu.org
Cc: Bruno Victal <mirai@makinata.eu>
Subject: [bug#67842] [PATCH 3/4] services: mympd: Fix syslog logging and missing service destructor.
Date: Fri, 15 Dec 2023 21:02:38 +0000 [thread overview]
Message-ID: <fe43af9dc3db1eedaab859558bf20bda21162eb9.1702663151.git.mirai@makinata.eu> (raw)
In-Reply-To: <cover.1702663151.git.mirai@makinata.eu>
* gnu/services/audio.scm: (mympd-shepherd-service): Fix syslog logging and
missing service destructor. Prefer list over quasiquote.
---
gnu/services/audio.scm | 13 +++++++------
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/gnu/services/audio.scm b/gnu/services/audio.scm
index ae991ced4d..4fcfcc13ea 100644
--- a/gnu/services/audio.scm
+++ b/gnu/services/audio.scm
@@ -938,14 +938,15 @@ (define (mympd-shepherd-service config)
cache-directory)))))
(make-forkexec-constructor
- `(#$(file-append package "/bin/mympd")
- "--user" #$username
- #$@(if (eq? log-to 'syslog) '("--syslog") '())
- "--workdir" #$work-directory
- "--cachedir" #$cache-directory)
+ (list #$(file-append package "/bin/mympd")
+ "--user" #$username
+ #$@(if (maybe-value-set? log-to) '() '("--syslog"))
+ "--workdir" #$work-directory
+ "--cachedir" #$cache-directory)
#:environment-variables
(list #$(format #f "MYMPD_LOGLEVEL=~a" log-level))
- #:log-file #$(maybe-value log-to)))))))))
+ #:log-file #$(maybe-value log-to))))))
+ (stop #~(make-kill-destructor)))))
(define (mympd-accounts config)
(match-record config <mympd-configuration> (user group)
--
2.41.0
next prev parent reply other threads:[~2023-12-15 21:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-15 20:59 [bug#67842] [PATCH 0/4] Refactor mympd service Bruno Victal
2023-12-15 21:02 ` [bug#67842] [PATCH 1/4] doc: Remove missed hunk of revert commit for MPD service Bruno Victal
2023-12-15 21:02 ` [bug#67842] [PATCH 2/4] tests: mympd: Simplify test Bruno Victal
2023-12-15 21:02 ` Bruno Victal [this message]
2023-12-15 21:02 ` [bug#67842] [PATCH 4/4] services: mympd: Refactor serialization process Bruno Victal
2023-12-16 1:44 ` Liliana Marie Prikler
2023-12-16 19:36 ` Bruno Victal
2023-12-16 22:12 ` Liliana Marie Prikler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fe43af9dc3db1eedaab859558bf20bda21162eb9.1702663151.git.mirai@makinata.eu \
--to=mirai@makinata.eu \
--cc=67842@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).