From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id wA0XL932Al8hWAAA0tVLHw (envelope-from ) for ; Mon, 06 Jul 2020 10:03:09 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id KEnIKt32Al9LKQAAbx9fmQ (envelope-from ) for ; Mon, 06 Jul 2020 10:03:09 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3277F940220 for ; Mon, 6 Jul 2020 10:03:09 +0000 (UTC) Received: from localhost ([::1]:38788 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jsNxr-00024W-Er for larch@yhetil.org; Mon, 06 Jul 2020 06:03:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52928) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jsNxm-00022M-Gr for guix-patches@gnu.org; Mon, 06 Jul 2020 06:03:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:50333) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jsNxm-0003kT-7M for guix-patches@gnu.org; Mon, 06 Jul 2020 06:03:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jsNxm-0007jv-3L for guix-patches@gnu.org; Mon, 06 Jul 2020 06:03:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#42193] [WIP 4/6] services: kernel-module-loader: Return a single 'shepherd-service'. Resent-From: Brice Waegeneire Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 06 Jul 2020 10:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42193 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Danny Milosavljevic Cc: 42193@debbugs.gnu.org Received: via spool by 42193-submit@debbugs.gnu.org id=B42193.159402973129690 (code B ref 42193); Mon, 06 Jul 2020 10:03:02 +0000 Received: (at 42193) by debbugs.gnu.org; 6 Jul 2020 10:02:11 +0000 Received: from localhost ([127.0.0.1]:33646 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jsNww-0007in-V1 for submit@debbugs.gnu.org; Mon, 06 Jul 2020 06:02:11 -0400 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:36703) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jsNwt-0007iI-By for 42193@debbugs.gnu.org; Mon, 06 Jul 2020 06:02:09 -0400 Received: from webmail.gandi.net (webmail19.sd4.0x35.net [10.200.201.19]) (Authenticated sender: brice@waegenei.re) by relay3-d.mail.gandi.net (Postfix) with ESMTPA id 4473360015; Mon, 6 Jul 2020 10:01:59 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 06 Jul 2020 10:01:59 +0000 From: Brice Waegeneire In-Reply-To: <20200706020322.3577052e@scratchpost.org> References: <20200704185234.12571-1-brice@waegenei.re> <20200704185431.13739-5-brice@waegenei.re> <20200706020322.3577052e@scratchpost.org> Message-ID: X-Sender: brice@waegenei.re User-Agent: Roundcube Webmail/1.3.13 X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.7 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: 8CfPqu2bZ+Lg Hello Danny, On 2020-07-06 00:03, Danny Milosavljevic wrote: > I mean technically we could do that, but almost none of the other > "-shepherd-service"s we have avoid returning a list. Why single this > one out? Because I wrote that module, forgetting to add a plural to 'kernel-module-loader-shepherd-service' and when reading the dnsmasq service code I was made aware of it. It's either that patch or a stupid typo one to go from 'kernel-module-loader-shepherd-service' to 'kernel-module-loader-shepherd-serviceS'. There are currently 14 other services that are using that pattern. > Could we change all of them to not return a list? Maybe, but I don't see the point of doing so as I expect that if the procedure's name is plural and return a list there is no need to change it. - Brice