From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id oNDuDgyLfl8WewAA0tVLHw (envelope-from ) for ; Thu, 08 Oct 2020 03:44:12 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id FWGXCgyLfl/yIgAAB5/wlQ (envelope-from ) for ; Thu, 08 Oct 2020 03:44:12 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id DC00F9402B4 for ; Thu, 8 Oct 2020 03:44:10 +0000 (UTC) Received: from localhost ([::1]:51818 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kQMqf-0002yQ-D1 for larch@yhetil.org; Wed, 07 Oct 2020 23:44:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50890) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kQMqY-0002yF-Dh for guix-patches@gnu.org; Wed, 07 Oct 2020 23:44:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:46844) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kQMqY-0003SD-42 for guix-patches@gnu.org; Wed, 07 Oct 2020 23:44:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kQMqY-0005Ph-2Y for guix-patches@gnu.org; Wed, 07 Oct 2020 23:44:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#43193] [PATCH] guix: Add --with-dependency-source option Resent-From: Jesse Gibbons Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 08 Oct 2020 03:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43193 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 43193@debbugs.gnu.org Received: via spool by 43193-submit@debbugs.gnu.org id=B43193.160212862820783 (code B ref 43193); Thu, 08 Oct 2020 03:44:02 +0000 Received: (at 43193) by debbugs.gnu.org; 8 Oct 2020 03:43:48 +0000 Received: from localhost ([127.0.0.1]:58390 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kQMqK-0005P8-8x for submit@debbugs.gnu.org; Wed, 07 Oct 2020 23:43:48 -0400 Received: from mail-pf1-f176.google.com ([209.85.210.176]:39566) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kQMqG-0005Ot-Mq for 43193@debbugs.gnu.org; Wed, 07 Oct 2020 23:43:46 -0400 Received: by mail-pf1-f176.google.com with SMTP id n14so2852320pff.6 for <43193@debbugs.gnu.org>; Wed, 07 Oct 2020 20:43:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:from:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=o7D8LKUhJLE14e5aglikZlSuBGDxnoRLvNbqT5/EMc8=; b=gUEqUzihpRG8WYnK1ebXb6xuCOylMfjcRZVRd+fl9kNCnI45duUG+MSgWD6B674ddE 75EVd3ClI2ZJeDDPiHKExBe37h/RIBOphCdMVQEfqe41gBjsTRnqtmT5be5KieHuRvwE Ld9GiofY5Jh0rJ+cAb10e/C2scxEtKYgkgeww+xALZwshbvHb/2hV+zqxxoDFS3PY4sj udFsO81Sr7DKnADBoRX3OdXQo8s272SuTeZvIZAwW1pRpfaQZ4IumvOFbzPQ0xi0clCu qPVCVUfJu9q1dCm+CJCBGvdsbSrDDZA0BdesyZsTzVs/5uboYnUJnSe5jqiuBD4/0jlW UasA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=o7D8LKUhJLE14e5aglikZlSuBGDxnoRLvNbqT5/EMc8=; b=qsL1jJFfmuTBIgDZhrwWHBuOJO7dUEWEwFgyIrI+D8jb+dvyluOXUZw43+RhlTKH4C RdoGIgbqiDNeCtXvsL6K0yXbjfeXfOyBIqIynTnIZjLTAPz/IlmrNZXUWbJd3nkBtZcw lcUnRwHMIOz5fYTjwX9Vkto/TFIaNIf2YI2S3CXq8/KFGNCXcz894Y76lVCKOT6LBcw6 tHNIVrXYjbIgwYuN9UUgb8etRoPJ4t88b0t/VhBA4oVlVA43vovEd/hYRaaxQ2ycmpfA G8iFFrkNtuF1ve/LS04I+bUB7gI9MQZ0JG1ux5E2pNC9bOJVA66lrNmQw6yv4OYhWCsa 4PhA== X-Gm-Message-State: AOAM531z8m5ImiBlN3cpww4VsvYVoXPuDNH7dvaONSeKBEfvYgESsHZ4 I099+S+g+FbWttlrC8gQzHBwqU8h7f8= X-Google-Smtp-Source: ABdhPJxf3Fr/CDRQtZtQxJUzRxPxiHiLJnLpIjde/tDUUyIZWKUdccqCyHztAatB/fYiQHYCh3t8RQ== X-Received: by 2002:a17:90a:9f91:: with SMTP id o17mr5997848pjp.228.1602128618091; Wed, 07 Oct 2020 20:43:38 -0700 (PDT) Received: from [192.168.1.25] ([38.141.58.134]) by smtp.gmail.com with ESMTPSA id p4sm1080835pjk.8.2020.10.07.20.43.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 07 Oct 2020 20:43:37 -0700 (PDT) From: Jesse Gibbons References: <9c3a00ba-19bf-a8e9-8803-d150e91f1b6e@gmail.com> <87y2lige5l.fsf@gnu.org> <7f52c72f-c280-b585-d1ad-ca012f804910@gmail.com> <87wo10s4j6.fsf@gnu.org> <4c890f8c-539c-1c9c-f558-7ba01cffa480@gmail.com> <87y2ld7s5b.fsf@gnu.org> <9c60e5f2-e9fa-55c9-863f-cc3bccc2cf15@gmail.com> Message-ID: Date: Wed, 7 Oct 2020 21:43:34 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Icedove/78.3.1 MIME-Version: 1.0 In-Reply-To: <9c60e5f2-e9fa-55c9-863f-cc3bccc2cf15@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Spam-Score: 0.2 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -0.8 (/) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=fail (rsa verify failed) header.d=gmail.com header.s=20161025 header.b=gUEqUzih; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: 0.09 X-TUID: GCy0pYfMoEN8 This is a friendly bump. On 9/26/20 4:46 PM, Jesse Gibbons wrote: > Attached are the patches that make the --with-source option recursive, > add documentation, add a test, adjust a test, and update the news. > > As expected, the changes I made are incompatible with the test > "options->transformation, with-source, no matches". Since > options->transformation, with-source does a recursive replacement, it > returns a clone of the package in question. I have tried changing the > comparison to eq?, eqv? and equal?, each returning false, so I settled > on a (limited) comparison of the packages' attributes. > > On 9/13/20 6:55 AM, Ludovic Courtès wrote: >> Hi, >> >> Jesse Gibbons skribis: >> >>> On 9/11/20 9:43 AM, Ludovic Courtès wrote: >> [...] >> >>>> So maybe drop the second clause for non-recursive replacement, and >>>> drop >>>> ‘transform-package-source’ as well. >>> I included a fallback to transform-package-source because the >>> following happens: >>> >>> $ ./pre-inst-env guix build --with-source=$(guix build --source >>> hello) hello >>> guix build: error: invalid source replacement specification: >>> "/gnu/store/hbdalsf5lpf01x4dcknwx6xbn6n5km6k-hello-2.10.tar.gz" >>> >>> This does not fail when I fall back to the non-recursive logic. >>> >>> I can drop transform-package-source, but I will need to do some more >>> hacking to figure out how the package name and version are parsed from >>> the file name as described in the manual, and move it to the logic in >>> transform-package-inputs/source. >> Yes, that’d be nice.  Namely, if you do: >> >>    guix build hello --source=hello-1.2.3.tar.gz >> >> it should work just as now (from the source file name, we assume that >> the source applies to package “hello”). >> >> Conversely, doing: >> >>    guix build hello --source=xyz-hello-1.2.3.tar.gz >> >> would have no effect.  It would not even emit a warning, unlike now. >> >>> I'm not going to have as much free time starting next week, so I might >>> not be able to do that for a while, but I will try to get it done >>> ASAP. >> Sure, let’s stay in touch, I think we’re almost done! >> >> Thank you, >> Ludo’.