unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Maxime Devos <maximedevos@telenet.be>
To: Christopher Rodriguez <yewscion@gmail.com>
Cc: 56989@debbugs.gnu.org
Subject: [bug#56989] [PATCH v3] gnu: Add dbqn.
Date: Tue, 9 Aug 2022 10:58:51 +0200	[thread overview]
Message-ID: <fd83320f-5181-c929-4598-4ea386165b83@telenet.be> (raw)
In-Reply-To: <87h72mx0t7.fsf@gmail.com>


[-- Attachment #1.1.1.1: Type: text/plain, Size: 1189 bytes --]


On 08-08-2022 15:54, Christopher Rodriguez wrote:
>>> +         (commit "fd17b144483549dbd2bcf23e3a37a09219171a99")
>>> +         (hash "1rr4l7ijzcg25n2igi1mzya6qllh5wsrf3m5i429rlgwv1fwvfji")
>>> +         (version (git-version tag revision commit)))
>> I'm not seeing a '0' tag anywhere in the repository -- I dont see any tags at
>> all tere.
> There are none; I thought the absence of any tage necessitates a '0' for
> the version number, and wanted to keep the definitions
> standardized. Should I inline the 0 instead in the git-version?
>
Yes, if upstream doesn't do versioning we use "0" or sometimes "0.0", in 
combination with git-version (or hg-version, ...). However, "0" is not a 
tag, so the variable 'tag' needs to be renamed or inlined.  As it is 
only used in a signle place, I would recommend inlining it. Likewise for 
'version'.

Additionally, 'hash' needs to be inlined -- not only because it is used 
in a single place, but also because there is some compile-time error 
checking for hashes that only can work when it is inlined.

Also, I've seen a v2 for the first patch, but what happened to 2/5, 3/5, 
4/5 and 5/5?

Greetings,
Maxime.


[-- Attachment #1.1.1.2: Type: text/html, Size: 1867 bytes --]

[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 929 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]

  parent reply	other threads:[~2022-08-09  8:59 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-05  2:20 [bug#56989] [PATCH v1 1/5] gnu: bqn: Add bqn.scm and dbqn package Christopher Rodriguez
2022-08-05  2:20 ` [bug#56990] [PATCH v1 2/5] gnu: bqn: Add bqn-bytecode-sources Christopher Rodriguez
2022-08-05  2:20 ` [bug#56992] [PATCH v1 3/5] gnu: bqn: Add cbqn-bootstrap Christopher Rodriguez
2022-08-05  2:20 ` [bug#56991] [PATCH v1 4/5] gnu: bqn: Add singeli-bootstrap Christopher Rodriguez
2022-08-05  2:20 ` [bug#56993] [PATCH v1 5/5] gnu: bqn: Add cbqn Christopher Rodriguez
2022-08-05  5:46 ` [bug#56989] [PATCH v2] gnu: bqn: Add bqn.scm and dbqn package Christopher Rodriguez
2022-08-05  7:15   ` Liliana Marie Prikler
2022-08-05 15:12     ` Christopher Rodriguez
2022-08-05 15:37       ` ( via Guix-patches via
2022-08-05 15:50         ` Christopher Rodriguez
2022-08-05 15:50         ` Christopher Rodriguez
2022-08-05 22:33       ` Liliana Marie Prikler
2022-08-06  1:47         ` Christopher Rodriguez
2022-08-06  2:20 ` [bug#56989] [PATCH v3] gnu: Add dbqn Christopher Rodriguez
2022-08-07 16:28   ` Liliana Marie Prikler
2022-08-08  9:19   ` Maxime Devos
2022-08-08 13:54     ` Christopher Rodriguez
2022-08-08 21:09       ` Maxime Devos
2022-08-09  8:58       ` Maxime Devos [this message]
2022-08-09  9:02         ` Maxime Devos
2022-08-07 14:43 ` [bug#56989] [PATCH v2] gnu: bqn: Add bqn.scm and dbqn package Christopher Rodriguez
2022-08-08  9:20 ` [bug#56989] [PATCH v1 1/5] " Maxime Devos
2022-08-09  1:22 ` [bug#56989] [PATCH v4] gnu: Add dbqn Christopher Rodriguez
2022-08-10 17:27 ` [bug#56989] [PATCH v5 1/5] gnu: Add dbqn package Christopher Rodriguez
2022-08-10 17:27   ` [bug#56989] [PATCH v5 2/5] gnu: Add bqn-sources Christopher Rodriguez
2022-08-10 17:27   ` [bug#56989] [PATCH v5 3/5] gnu: Add cbqn-bootstrap Christopher Rodriguez
2022-08-10 17:27   ` [bug#56989] [PATCH v5 4/5] gnu: Add singeli-sources Christopher Rodriguez
2022-08-10 17:28   ` [bug#56989] [PATCH v5 5/5] gnu: Add cbqn Christopher Rodriguez
2022-08-31 21:10   ` bug#56989: bug#56993: [PATCH v1 5/5] gnu: bqn: " Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fd83320f-5181-c929-4598-4ea386165b83@telenet.be \
    --to=maximedevos@telenet.be \
    --cc=56989@debbugs.gnu.org \
    --cc=yewscion@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).