From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:41423) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iPnX6-00079I-Te for guix-patches@gnu.org; Wed, 30 Oct 2019 08:57:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iPnX5-0000Vy-GX for guix-patches@gnu.org; Wed, 30 Oct 2019 08:57:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:40654) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iPnX5-0000V0-1T for guix-patches@gnu.org; Wed, 30 Oct 2019 08:57:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iPnX4-0000MA-Tw for guix-patches@gnu.org; Wed, 30 Oct 2019 08:57:02 -0400 Subject: [bug#37987] Add gitg References: Resent-Message-ID: Message-ID: From: Leo Prikler Date: Wed, 30 Oct 2019 13:56:51 +0100 In-Reply-To: 87tv7qbljo.fsf@gmail.com Content-Type: multipart/mixed; boundary="=-1XxsB1fqpmAm4MeltaEj" MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: m.othacehe@gmail.com Cc: 37987@debbugs.gnu.org --=-1XxsB1fqpmAm4MeltaEj Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit > Your patch LGTM. About failing test, I see that nix runs them and has > a > small fix to substitute bash path: > > --8<---------------cut here---------------start------------->8--- > substituteInPlace tests/libgitg/test-commit.vala --replace > "/bin/bash" > "${bash}/bin/bash" > --8<---------------cut here---------------end--------------->8--- > > Have you tried something like that? That does seem to work. I've updated the patch. Regards, Leo --=-1XxsB1fqpmAm4MeltaEj Content-Disposition: attachment; filename="0001-gnu-Add-gitg.patch" Content-Type: text/x-patch; name="0001-gnu-Add-gitg.patch"; charset="UTF-8" Content-Transfer-Encoding: base64 RnJvbSAzOTE1ZDZhNDczODFjYjgzNTU5OWU5ZmQ2NzQ0ZjczMzE0NGYwZjMwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBMZW8gUHJpa2xlciA8bGVvLnByaWtsZXJAc3R1ZGVudC50dWdy YXouYXQ+CkRhdGU6IFR1ZSwgMjkgT2N0IDIwMTkgMjM6MzA6MTYgKzAxMDAKU3ViamVjdDogW1BB VENIXSBnbnU6IEFkZCBnaXRnLgoKKiBnbnUvcGFja2FnZXMvZ25vbWUuc2NtOiAoZ2l0Zyk6IE5l dyB2YXJpYWJsZS4KLS0tCiBnbnUvcGFja2FnZXMvZ25vbWUuc2NtIHwgNjcgKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKwog MSBmaWxlIGNoYW5nZWQsIDY3IGluc2VydGlvbnMoKykKCmRpZmYgLS1naXQgYS9nbnUvcGFja2Fn ZXMvZ25vbWUuc2NtIGIvZ251L3BhY2thZ2VzL2dub21lLnNjbQppbmRleCAyNzZmYTU2Li4wNWZm NzI4IDEwMDY0NAotLS0gYS9nbnUvcGFja2FnZXMvZ25vbWUuc2NtCisrKyBiL2dudS9wYWNrYWdl cy9nbm9tZS5zY20KQEAgLTg0MDAsNiArODQwMCw3MyBAQCBoaWdoZXIgbGV2ZWwgcG9yY2VsYWlu IHN0dWZmLiIpCiAgICAgKGhvbWUtcGFnZSAiaHR0cHM6Ly93aWtpLmdub21lLm9yZy9Qcm9qZWN0 cy9MaWJnaXQyLWdsaWIiKQogICAgIChsaWNlbnNlIGxpY2Vuc2U6Z3BsMispKSkKIAorKGRlZmlu ZS1wdWJsaWMgZ2l0ZworICAocGFja2FnZQorICAgIChuYW1lICJnaXRnIikKKyAgICAodmVyc2lv biAiMy4zMi4xIikKKyAgICAoc291cmNlIChvcmlnaW4KKyAgICAgICAgICAgICAgKG1ldGhvZCB1 cmwtZmV0Y2gpCisgICAgICAgICAgICAgICh1cmkgKHN0cmluZy1hcHBlbmQgIm1pcnJvcjovL2du b21lL3NvdXJjZXMvIiBuYW1lICIvIgorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICh2ZXJzaW9uLW1ham9yK21pbm9yIHZlcnNpb24pICIvIgorICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIG5hbWUgIi0iIHZlcnNpb24gIi50YXIueHoiKSkKKyAgICAgICAgICAgICAg KHNoYTI1NgorICAgICAgICAgICAgICAgKGJhc2UzMgorICAgICAgICAgICAgICAgICIwbnBnNGtx cHdsOTkyZmdqZDJjbjNmaDg0YWl3cGRwOWtkOHo3cncyeGFqMmlhenNtOTE0IikpKSkKKyAgICAo YnVpbGQtc3lzdGVtIG1lc29uLWJ1aWxkLXN5c3RlbSkKKyAgICAoYXJndW1lbnRzCisgICAgIGAo IzpnbGliLW9yLWd0az8gI3QKKyAgICAgICAjOnBoYXNlcworICAgICAgIChtb2RpZnktcGhhc2Vz ICVzdGFuZGFyZC1waGFzZXMKKyAgICAgICAgIChhZGQtYWZ0ZXIgJ3VucGFjayAnZGlzYWJsZS1w b3N0LWluc3RhbGwtcGFydGlhbGx5CisgICAgICAgICAgIChsYW1iZGEgXworICAgICAgICAgICAg IChzdWJzdGl0dXRlKiAibWVzb25fcG9zdF9pbnN0YWxsLnB5IgorICAgICAgICAgICAgICAgKCgi J3B5dGhvbiciKSA7IHRoZXJlIGFyZSBubyBweXRob24gc291cmNlcyB0byBjb21waWxlCisgICAg ICAgICAgICAgICAgKHN0cmluZy1hcHBlbmQgIiciICh3aGljaCAidHJ1ZSIpICInIikpCisgICAg ICAgICAgICAgICAoKCJndGstdXBkYXRlLWljb24tY2FjaGUiKSAod2hpY2ggInRydWUiKSkpCisg ICAgICAgICAgICAgI3QpKQorICAgICAgICAgKGFkZC1hZnRlciAndW5wYWNrICdmaXgtdGVzdC1z b3VyY2VzCisgICAgICAgICAgIChsYW1iZGEgXworICAgICAgICAgICAgIChzdWJzdGl0dXRlKiAi dGVzdHMvbGliZ2l0Zy90ZXN0LWNvbW1pdC52YWxhIgorICAgICAgICAgICAgICAgKCgiL2Jpbi9i YXNoIikgKHdoaWNoICJiYXNoIikpKQorICAgICAgICAgICAgICN0KSkKKyAgICAgICAgIChhZGQt YWZ0ZXIgJ2dsaWItb3ItZ3RrLXdyYXAgJ3dyYXAtdHlwZWxpYgorICAgICAgICAgICAobGFtYmRh KiAoIzprZXkgb3V0cHV0cyAjOmFsbG93LW90aGVyLWtleXMpCisgICAgICAgICAgICAgKGxldCAo KHByb2cgKHN0cmluZy1hcHBlbmQgKGFzc29jLXJlZiBvdXRwdXRzICJvdXQiKQorICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICIvYmluL2dpdGciKSkpCisgICAgICAgICAg ICAgICAod3JhcC1wcm9ncmFtIHByb2cKKyAgICAgICAgICAgICAgICAgYCgiR0lfVFlQRUxJQl9Q QVRIIiA9ICgsKGdldGVudiAiR0lfVFlQRUxJQl9QQVRIIikpKSkKKyAgICAgICAgICAgICAgICN0 KSkpKSkpCisgICAgKGlucHV0cworICAgICBgKCgiZ2xpYiIgLGdsaWIpCisgICAgICAgKCJnc2V0 dGluZ3MtZGVza3RvcC1zY2hlbWFzIiAsZ3NldHRpbmdzLWRlc2t0b3Atc2NoZW1hcykKKyAgICAg ICAoImd0aysiICxndGsrKQorICAgICAgICgiZ3Rrc3BlbGwzIiAsZ3Rrc3BlbGwzKQorICAgICAg ICgiZ3Rrc291cmNldmlldyIgLGd0a3NvdXJjZXZpZXctMykKKyAgICAgICAoImpzb24tZ2xpYiIg LGpzb24tZ2xpYikKKyAgICAgICAoImxpYmRhenpsZSIgLGxpYmRhenpsZSkKKyAgICAgICAoImxp YmdlZSIgLGxpYmdlZSkKKyAgICAgICAoImxpYmdpdDIiICxsaWJnaXQyKSA7IHByb3BhZ2F0ZWQg YnkgbGliZ2l0Mi1nbGliCisgICAgICAgKCJsaWJnaXQyLWdsaWIiICxsaWJnaXQyLWdsaWIpCisg ICAgICAgKCJsaWJwZWFzIiAsbGlicGVhcykKKyAgICAgICAoImxpYnNlY3JldCIgLGxpYnNlY3Jl dCkKKyAgICAgICAoImxpYnNvdXAiICxsaWJzb3VwKQorICAgICAgICgibGlieG1sMiIgLGxpYnht bDIpKSkKKyAgICAobmF0aXZlLWlucHV0cworICAgICBgKCgiZ2xpYjpiaW4iICxnbGliICJiaW4i KQorICAgICAgICgiZ3RrKzpiaW4iICxndGsrICJiaW4iKQorICAgICAgICgiZ29iamVjdC1pbnRy b3NwZWN0aW9uIiAsZ29iamVjdC1pbnRyb3NwZWN0aW9uKQorICAgICAgICgiaW50bHRvb2wiICxp bnRsdG9vbCkKKyAgICAgICAoInBrZy1jb25maWciICxwa2ctY29uZmlnKQorICAgICAgICgidmFs YSIgLHZhbGEpKSkKKyAgICAoc3lub3BzaXMgIkdyYXBoaWNhbCB1c2VyIGludGVyZmFjZSBmb3Ig Z2l0IikKKyAgICAoZGVzY3JpcHRpb24KKyAgICAgImdpdGcgaXMgYSBncmFwaGljYWwgdXNlciBp bnRlcmZhY2UgZm9yIGdpdC4gIEl0IGFpbXMgYXQgYmVpbmcgYSBzbWFsbCwKK2Zhc3QgYW5kIGNv bnZlbmllbnQgdG9vbCB0byB2aXN1YWxpemUgdGhlIGhpc3Rvcnkgb2YgZ2l0IHJlcG9zaXRvcmll cy4KK0Jlc2lkZXMgdmlzdWFsaXphdGlvbiwgZ2l0ZyBhbHNvIHByb3ZpZGVzIHNldmVyYWwgdXRp bGl0aWVzIHRvIG1hbmFnZSB5b3VyCityZXBvc2l0b3J5IGFuZCBjb21taXQgeW91ciB3b3JrLiIp CisgICAgKGhvbWUtcGFnZSAiaHR0cHM6Ly93aWtpLmdub21lLm9yZy9BcHBzL2dpdGciKQorICAg IChsaWNlbnNlIGxpY2Vuc2U6Z3BsMispKSkKKwogKGRlZmluZS1wdWJsaWMgZ25vbWUtbWFoam9u Z2cKICAgKHBhY2thZ2UKICAgICAobmFtZSAiZ25vbWUtbWFoam9uZ2ciKQotLQpsaWJnaXQyIDAu MjguMgoK --=-1XxsB1fqpmAm4MeltaEj--