> Your patch LGTM. About failing test, I see that nix runs them and has > a > small fix to substitute bash path: > > --8<---------------cut here---------------start------------->8--- > substituteInPlace tests/libgitg/test-commit.vala --replace > "/bin/bash" > "${bash}/bin/bash" > --8<---------------cut here---------------end--------------->8--- > > Have you tried something like that? That does seem to work. I've updated the patch. Regards, Leo