From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id +H5jAk94NmEwFAEAgWs5BA (envelope-from ) for ; Mon, 06 Sep 2021 22:21:35 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id Ae1ZOU54NmFOXwAAbx9fmQ (envelope-from ) for ; Mon, 06 Sep 2021 20:21:34 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 4F0D11F876 for ; Mon, 6 Sep 2021 22:21:34 +0200 (CEST) Received: from localhost ([::1]:39250 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mNL7V-0005TL-Bh for larch@yhetil.org; Mon, 06 Sep 2021 16:21:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54340) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mNKwM-0004a7-EV for guix-patches@gnu.org; Mon, 06 Sep 2021 16:10:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:43007) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mNKwM-0003Eb-7H for guix-patches@gnu.org; Mon, 06 Sep 2021 16:10:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mNKwM-0005jn-1n for guix-patches@gnu.org; Mon, 06 Sep 2021 16:10:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#48237] [PATCH] gnu: emacs-consult: Add =?UTF-8?Q?=E2=80=98emacs-ve?= Resent-From: Liliana Marie Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 06 Sep 2021 20:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48237 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxim Cournoyer , Xinglu Chen Cc: Arun Isaac , 48237@debbugs.gnu.org Received: via spool by 48237-submit@debbugs.gnu.org id=B48237.163095897722016 (code B ref 48237); Mon, 06 Sep 2021 20:10:02 +0000 Received: (at 48237) by debbugs.gnu.org; 6 Sep 2021 20:09:37 +0000 Received: from localhost ([127.0.0.1]:54553 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mNKvw-0005j1-Vo for submit@debbugs.gnu.org; Mon, 06 Sep 2021 16:09:37 -0400 Received: from mail-wm1-f67.google.com ([209.85.128.67]:51759) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mNJ0M-0002WR-C8 for 48237@debbugs.gnu.org; Mon, 06 Sep 2021 14:06:03 -0400 Received: by mail-wm1-f67.google.com with SMTP id n39so3421909wms.1 for <48237@debbugs.gnu.org>; Mon, 06 Sep 2021 11:06:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:subject:from:to:cc:date:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=UfAgWkU1TTcZfY6k67QITodS9qFEoCsT7xHgvoUTRqQ=; b=cstSdDJknKcD8FKki3XreeB4rmJ8G9iidAQ5fRluG5e3cFsPKa/u/M5TmX/NfyULFU Bb2AMhU/j04alwFQXOny6fRbGcHxPDM1WuGuS4icXAB+KbWCtyFpFPf+pgiTiLJp/ToQ LbcJjt7LRIWH+VWaxbZqhq/cIyrtgB2XBgDmj9CMCz8D4S9HINZ24wUSitZ5hWYKm9io TuThwQpDe2WMskibCF1k3yVoAQ1WW4szcYVKNbkmOfcxIJPNtCXUiGiJia4PDzMA7Cgm COgt5YdLDhnXZAJKJ6vRhSyBu5oAZkzagsoRpbGAGKwSm/A64So4NRndq1rQhdFL1JcT zpDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=UfAgWkU1TTcZfY6k67QITodS9qFEoCsT7xHgvoUTRqQ=; b=KJMMkNGQvJ3YVkVdGwdRaRleCb99Z7hTu7aZD2q2+4cG/Ke9t2mvLGTtLlxnuXuEZ2 bETRzdwJYcMR9pzHQd4SM8vmtWG1vKedZTaQhv9DR5sv2iRZgpTRSshUEYmvF0h/41G+ Ajr9LzLUI+wDIJCDZBkjdGRVIltoXEjUVfztIG3SIwMHor0WSrcTROHOtDNVeHuRAet0 rhGnCrSvzNOy1IifetDPkA/Jt9Ez7Q7j640TUhAhOV3q6ZEtb4ZzqS8DA71TtDjoY7kT ww6qXlAxVWNQ6B7Fn5tQAb8lGC7iPzPu0yodIeFSQy0as2v9mYCJN1EWOa/gsnnpOiMR +/Bg== X-Gm-Message-State: AOAM531a+/5lV3kSLbiqatgxj019+x1kDscRAPkBFkLwzpqYtHDw9aFf 5n0pRA57+vNVuKyOBFtMudc= X-Google-Smtp-Source: ABdhPJxKhjR0RZFallgyFQAieOJPLxuCkEcNBErYJFe/VCIiiQE8FvZukNxHmgVWp5t5tVwXaB5J5Q== X-Received: by 2002:a05:600c:ac2:: with SMTP id c2mr310187wmr.141.1630951556588; Mon, 06 Sep 2021 11:05:56 -0700 (PDT) Received: from nijino.local (194-118-34-199.adsl.highway.telekom.at. [194.118.34.199]) by smtp.gmail.com with ESMTPSA id i5sm8464496wrc.86.2021.09.06.11.05.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Sep 2021 11:05:56 -0700 (PDT) Message-ID: From: Liliana Marie Prikler Date: Mon, 06 Sep 2021 20:05:54 +0200 In-Reply-To: <8735qhbnj7.fsf@gmail.com> References: <87k0oa4o7h.fsf@yoctocell.xyz> <871r9kl1tr.fsf@yoctocell.xyz> <87pmukuhsf.fsf@systemreboot.net> <87v93d24tx.fsf@yoctocell.xyz> <8735qhbnj7.fsf@gmail.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Mailman-Approved-At: Mon, 06 Sep 2021 16:09:36 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Mailman-Approved-At: Mon, 06 Sep 2021 16:21:28 -0400 X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1630959694; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=UfAgWkU1TTcZfY6k67QITodS9qFEoCsT7xHgvoUTRqQ=; b=EiDx2G/mhU7coN21WZ457z84hjL0DCRmnxHpqTTkQD8Sie3UR7d3agG7MYLyrC7pxobQAL nAEeQfsdvJxhy/tE7ixujH7l2jUc1KHWGe/wsKUbC892QJ2WlBFNZxIF3FzpXqM9ak40Ib bOfVfVSmne5C8YpMBvqpm06Sj2Fig8RKckkcPFVlIx+pxLkhz24TFIhVVcTqtAscqoOTgP vMW9fTdlpzrNDDfkrytM3Rjt6YKKF+RoH/jxDqOa8GJLfmKo21i3SZesIOnSN92FiJjocO wovt0LjLu9KTn8xaKdFSNEv7RDEDE0Y1M1PB9RW242vZOILAQhr0B1knQ3Nw3g== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1630959694; a=rsa-sha256; cv=none; b=uKkfOUJh3WYYiOG+Vck7tHDu+s2IkWeOd4I6fbblbi3gYCM10rufS+jvhT7olGt0wxgU6n yRhFMRLcdmVJuf14PQg4dKPpGVkX0LHfEhBRsgRfTQAH0OCfimQUSRi+iYcyMhgR9mxSG1 jVGXImGXjD+d2w+tLWvgHSbafsSMW3/Jq9Sz81oCts4KnNcYjveevRjII8JKnyXj77scJT FwitkXh56WOiczPyHc/ZM+Xu1QRY8p+pxgRrHercaq31HxF6dM61g6aWlygaQzUAzUOXyz k2fsXBO5qE8bihFoBuDOmqM527ocA3NclvSV6vh+evbdX52JEOsgNZ96IWYNNQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=cstSdDJk; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: 0.18 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=cstSdDJk; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 4F0D11F876 X-Spam-Score: 0.18 X-Migadu-Scanner: scn1.migadu.com X-TUID: P5CYQbFy7+7X Am Montag, den 06.09.2021, 13:51 -0400 schrieb Maxim Cournoyer: > Hello Arun, > > Xinglu Chen writes: > > > On Wed, Aug 11 2021, Arun Isaac wrote: > > > > > Hi all, > > > > > > I actually think we should not add emacs-vertico to the > > > propagated-inputs, and remove emacs-flycheck and emacs-selectrum > > > as well. All these are optional dependencies, and we should leave > > > it to the user to install the ones they want. At least in this > > > specific case, the three packages (flycheck, selectrum and > > > vertico) are the kind the user would want to explicitly install. > > > They aren't backend libraries that ought to remain invisible to > > > the user. > > > > > > In fact, this is the version of emacs-consult I have installed in > > > my profile. > > Guix packages typically come as featureful as possible unless there > are good reasons not too (to minimize the closure size, for > example). In this case, the added optional dependencies seem to have > negligible effect on the closure size, according to `guix size`; I'd > be in favor to keep the optional dependencies specified for that > reason, unless there are other considerations that I'm missing. While closure size is normally a good metric, with interpreted languages like Emacs Lisp you have the added baggage of *propagating* inputs, thereby installing stuff at user (or system) level, that the user did not actually ask for. My personal take on those is to provide them as inputs where necessary to compile, but not actually propagate them where not necessary to run. For example, an Emacs package might require emacs-dash to function at all and might install some autocompletion stuff with emacs-autocomplete or emacs-company (perhaps even both). emacs-dash absolutely must be propagated, but unless you're already using autocomplete or company and thus have them in your manifest, you probably don't want them to be installed by emacs-foo. Does this make sense?