From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:bcc0::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id CGZPFVpfd2BLogAAgWs5BA (envelope-from ) for ; Wed, 14 Apr 2021 23:32:10 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id OFs1D1pfd2CNHgAA1q6Kng (envelope-from ) for ; Wed, 14 Apr 2021 21:32:10 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B8D3E12627 for ; Wed, 14 Apr 2021 23:32:09 +0200 (CEST) Received: from localhost ([::1]:38688 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lWn7I-0008Ew-UX for larch@yhetil.org; Wed, 14 Apr 2021 17:32:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52176) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lWn7C-0008Ei-SW for guix-patches@gnu.org; Wed, 14 Apr 2021 17:32:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:52619) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lWn7C-0006pR-K4 for guix-patches@gnu.org; Wed, 14 Apr 2021 17:32:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lWn7C-0001ZN-H2 for guix-patches@gnu.org; Wed, 14 Apr 2021 17:32:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#47769] [PATCH 5/6] gnu: Added go-github-com-google-gousb. Resent-From: Maxime Devos Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 14 Apr 2021 21:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47769 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Martin Becze , 47769@debbugs.gnu.org Received: via spool by 47769-submit@debbugs.gnu.org id=B47769.16184358966003 (code B ref 47769); Wed, 14 Apr 2021 21:32:02 +0000 Received: (at 47769) by debbugs.gnu.org; 14 Apr 2021 21:31:36 +0000 Received: from localhost ([127.0.0.1]:35932 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lWn6m-0001Yk-G0 for submit@debbugs.gnu.org; Wed, 14 Apr 2021 17:31:36 -0400 Received: from laurent.telenet-ops.be ([195.130.137.89]:53260) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lWn6j-0001Yb-AA for 47769@debbugs.gnu.org; Wed, 14 Apr 2021 17:31:35 -0400 Received: from ptr-bvsjgyjmffd7q9timvx.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:aaf1:9810:a0b8:a55d]) by laurent.telenet-ops.be with bizsmtp id slXX240060mfAB401lXXRh; Wed, 14 Apr 2021 23:31:32 +0200 Message-ID: From: Maxime Devos Date: Wed, 14 Apr 2021 23:31:31 +0200 In-Reply-To: <20210414102010.6100-5-mjbecze@riseup.net> References: <20210414101413.5743-1-mjbecze@riseup.net> <20210414102010.6100-1-mjbecze@riseup.net> <20210414102010.6100-5-mjbecze@riseup.net> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-RxAWO+2Zr+GUHmPYgq7Q" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r21; t=1618435892; bh=CEgJIPiyz4jfcb4zkOnRLr8xWiwp9hcHS/eVrh11iEY=; h=Subject:From:To:Date:In-Reply-To:References; b=elFTC/ZPAd+MWtXvwgAyrq9QmjjofEmhzT52SLT3tbFBP0T9C9olpygdlTylJnzYb 8BGa7v4sh1noCIGfl4Vw04cvktk84+MpPMR9fewfYyWKPMj4GbEPC6oum3zTkUv5Tk 9AvAqlmnUpsViQMd/EqBDDi5Q/xjO3qL7bg+FhR151xdEtLdHWM4ndgbtxsaOQ2oio v81t4OFbQtKgWBbc9PLEttHIeb3ka6CeQEH5kQrlqv6X4TASfq2WCRoXgm0okMSSZe oUrXR3D6Wot/IbIABi4e9DBWLi5e3gnqS1skGQkFvgdjnVOq84uwnQOKSjvSiHKBHP 3JmSnVdEK4Wpw== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1618435929; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=CEgJIPiyz4jfcb4zkOnRLr8xWiwp9hcHS/eVrh11iEY=; b=aXlqTAvfjXc6451fTJBkgdrjoAfvKhfAQonbzB8LMttxVEcLK57jt4XZS1IEna9c2cRFW4 SX7AKo8cgPjkHXr+0R+Cg5ZFEpo/UOj5VH2Pa6KaCIwepiXTaYC4lTECeVTlOwfEaHCXtj qVlddJOVaTMuJ9oQI7rs5KE3WO6Gi2YoRkaALY1fAECD1NtrQZJbeFW0cQMrrpjeK6IWyR YVL5rwGjB7vDGWGuEW2NMhyf2vlnCANjDATDK873551JZToo7vKUgJhJiJBySFT7kg9ABU zelg6IWvIzCR52Ta3Z5RI5wzye4EeHPrP8+sNiQZrn/KfZ85wtwWFaPpgQ5dVA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1618435929; a=rsa-sha256; cv=none; b=MOpaDHJlzxNICCl3C+9O9ZRYObyUzynAyX4Gpke6+BkJYK5SHFoKwhjoRzeWk8BcYUHlD6 851NGLTl/ckdNO59quXfF0x3i/31sUEsnsA+4tj/Wtp0G/62B/bXhNEivtIRAn/AeyjEl1 1p14EXmZC3zy776WfHCDSiYFbR5atMya5R1riI7k/NsceOLQYFbNCLXP8XUYeMUVqmu84U THl/QlrZoXrp4aRh8aYSnNnQ6qISCoSxL8oXo3dgdaX9MqYgHtwdhn3f+vsHOlQbPHlCdy mjjauFUXOQ+EHvaDfrY3RSxEFFZgTlx3ea3yA1qsPAHgDUq3LJJ3FTU+U1lVmA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r21 header.b="elFTC/ZP"; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -3.44 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r21 header.b="elFTC/ZP"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: B8D3E12627 X-Spam-Score: -3.44 X-Migadu-Scanner: scn0.migadu.com X-TUID: S0V412PQeU5i --=-RxAWO+2Zr+GUHmPYgq7Q Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, 2021-04-14 at 05:20 -0500, Martin Becze wrote: > +(define-public go-github-com-google-gousb > + (package > + (name "go-github-com-google-gousb") > + (version "2.1.0") > + (source > + (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/google/gousb.git") > + (commit (string-append "v" version)))) > + (sha256 > + (base32 > + "1aki6hk009sicrf7gxy5nkjmj4j7lsy0by4kjgd9bwq8ragfyv5x")) > + (file-name (git-file-name name version)))) > + (build-system go-build-system) > + (arguments > + '(#:import-path "github.com/google/gousb")) > + (propagated-inputs > + `(("pkg-config" ,pkg-config) > + ("libusb" ,libusb))) Most likely, "pkg-config" should be in native-inputs. I believe there's a linter that checks whether packages should be in native-inputs, but I'm not sure if pkg-config is detected. Consider running ./pre-inst-env guix lint go-github-com-google-gousb. Also, why is "libusb" in "propagated-inputs" and not in "inputs"? "inputs" is usually preferred over "propagated-inputs", but there are valid reasons to use "propagated-inputs" instead. Greetings, Maime. --=-RxAWO+2Zr+GUHmPYgq7Q Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYHdfMxccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7hrUAQCdZk8Kmk0TEX/t58Y16icXXEj8 wSD8Gc4gKVKPUaH4aQEAr8whO5HZkKEHxHjfJ0ObFG6pSFlfIMaG4CQx0+l7sQo= =Jcn8 -----END PGP SIGNATURE----- --=-RxAWO+2Zr+GUHmPYgq7Q--