From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:57849)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jCo5P-0004kF-9x
 for guix-patches@gnu.org; Fri, 13 Mar 2020 13:27:05 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jCo5O-0003Wr-8F
 for guix-patches@gnu.org; Fri, 13 Mar 2020 13:27:03 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:54220)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1jCo5O-0003Wg-4c
 for guix-patches@gnu.org; Fri, 13 Mar 2020 13:27:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jCo5O-0001Gy-0F
 for guix-patches@gnu.org; Fri, 13 Mar 2020 13:27:02 -0400
Subject: [bug#39862] [PATCH v3 2/2] gnu: define dune-*-openmpi packages
Resent-Message-ID: <handler.39862.B39862.15841203904856@debbugs.gnu.org>
References: <87k13pvj5u.fsf@gnu.org>
 <20200312210513.107891-3-felgru@posteo.net> <87blp0pp4d.fsf@gnu.org>
From: Felix Gruber <felgru@posteo.net>
Message-ID: <fc5a653b-d07e-3aea-d16e-fa654e1b6ece@posteo.net>
Date: Fri, 13 Mar 2020 18:26:11 +0100
MIME-Version: 1.0
In-Reply-To: <87blp0pp4d.fsf@gnu.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Cc: 39862@debbugs.gnu.org

Hi Ludo’,

On 3/13/20 10:42 AM, Ludovic Courtès wrote:
> Felix Gruber <felgru@posteo.net> skribis:
> 
>> * gnu/packages/maths.scm (dune-*-openmpi): New variables.
>> * gnu/packages/maths.scm (add-openmpi-to-dune-package): New function to
>>   add openmpi to the inputs of a dune-* package and replace all dune-*
>>   packages in its input with the corresponding dune-*-openmpi package.
> 
> Nitpick: no need to repeat the file name above.  It would also be great
> if you could list all the new variables.

Sure, no problem.

>> +      (lambda (p) (not (dune-package? p))))))
> 
> You can replace the lambda with:
> 
>   (negate dune-package?)

Thanks for this hint, as I'm new to Scheme, my knowledge of its standard
library is still pretty limited. The negate function is quite useful.

> One last thing: could you look at the output of, say, ‘guix graph
> dune-geometry-openmpi’ and ensure we’re not duplicating more nodes than
> needed in the graph?
> 
> For example, you can compare node counts with:
> 
>   guix graph dune-geometry | grep 'label =' | wc -l
>   guix graph dune-geometry-openmpi | grep 'label =' | wc -l
> 
> The difference should be less than:
> 
>   guix graph openmpi | grep 'label =' | wc -l
> 
> If that works well, please send an updated patch and we should be ready
> to go!

I get the following numbers:

 graph dune-geometry | grep 'label =' | wc -l
 70

 guix graph dune-geometry-openmpi | grep 'label =' | wc -l
 143

 guix graph openmpi | grep 'label =' | wc -l
 137

The difference seems to be OK: 143 - 70 = 73 < 137.

I'll send the updated patch ASAP.

Best Regards,
Felix