[bug#51534] [PATCH] gnu: Add smplayer.

[bug#51534] [PATCH] gnu: Add smplayer.

[Attila Lendvai]

* gnu/packages/video.scm (smplayer): New variable.
---
 gnu/packages/video.scm | 60 ++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 60 insertions(+)

diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
index 245007f294..ecd5ab8728 100644
--- a/gnu/packages/video.scm
+++ b/gnu/packages/video.scm
@@ -2092,6 +2092,66 @@ (define-public mplayer
 SVCD, DVD, 3ivx, DivX 3/4/5, WMV and H.264 movies.")
     (license license:gpl2)))
 
+(define-public smplayer
+  (package
+    (name "smplayer")
+    (version "21.10.0")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append
+                    "mirror://sourceforge/smplayer/SMPlayer/" version
+                    "/smplayer-" version ".tar.bz2"))
+              (sha256
+               (base32
+                "12nvcl0cfix1xay9hfi7856vg4lpv8y5b0a22212bsjbvl5g22rc"))))
+    (build-system gnu-build-system)
+    (native-inputs
+     `(("qttools" ,qttools)))
+    (inputs
+     `(("qtbase" ,qtbase-5)
+       ("zlib" ,zlib)
+       ("mplayer" ,mplayer)))
+    (arguments
+     `(#:modules (,@%gnu-build-system-modules
+                  (srfi srfi-26))
+       #:tests? #false             ; no tests
+       #:make-flags (list (string-append "PREFIX=" (assoc-ref %outputs "out"))
+                          (string-append "CC=" ,(cc-for-target))
+                          ;; A KLUDGE to turn off invoking lrelease on the
+                          ;; project for now, because it fails consistently
+                          ;; with "WARNING: Could not find qmake spec
+                          ;; 'default'". See below.
+                          "LRELEASE=true")
+       #:phases
+       (modify-phases %standard-phases
+         (delete 'configure)
+         ;; Due to the above, we must run lrelease separately on each .ts file
+         ;; (as opposed to running `lrelease-pro smplayer.pro` for the entire
+         ;; project, as the Makefile does normally without the above kludge).
+         (add-after 'build 'compile-ts-files
+           (lambda _
+             (for-each (cut invoke "lrelease" <>)
+                       (find-files "./" "\\.ts$")))))))
+    (home-page "https://www.smplayer.info")
+    (synopsis "Complete front-end for MPlayer, a media player")
+    (description "SMPlayer is a free media player for Windows and Linux
+with built-in codecs that can play virtually all video and audio formats.
+It doesn't need any external codecs. Just install SMPlayer and you'll be
+able to play all formats without the hassle to find and install codec packs.
+
+One of the most interesting features of SMPlayer: it remembers the
+settings of all files you play. So you start to watch a movie but you have
+to leave... don't worry, when you open that movie again it will be resumed
+at the same point you left it, and with the same settings: audio track,
+subtitles, volume...
+
+SMPlayer is a graphical user interface (GUI) for the award-winning
+MPlayer, which is capable of playing almost all known video and audio
+formats. But apart from providing access for the most common and useful
+options of MPlayer, SMPlayer adds other interesting features like the
+possibility to play Youtube videos or download subtitles.")
+    (license license:gpl3+)))
+
 (define-public mpv
   (package
     (name "mpv")
-- 
2.33.0

[bug#51534] [PATCH v2] gnu: Add smplayer.

[Attila Lendvai]

* gnu/packages/video.scm (smplayer): New variable.
---

i forgot to double check the licence, it's gpl2+, not gpl3+. otherwise,
it's the same as the previous patch.

 gnu/packages/video.scm | 60 ++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 60 insertions(+)

diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
index 245007f294..2915f85352 100644
--- a/gnu/packages/video.scm
+++ b/gnu/packages/video.scm
@@ -2092,6 +2092,66 @@ (define-public mplayer
 SVCD, DVD, 3ivx, DivX 3/4/5, WMV and H.264 movies.")
     (license license:gpl2)))
 
+(define-public smplayer
+  (package
+    (name "smplayer")
+    (version "21.10.0")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append
+                    "mirror://sourceforge/smplayer/SMPlayer/" version
+                    "/smplayer-" version ".tar.bz2"))
+              (sha256
+               (base32
+                "12nvcl0cfix1xay9hfi7856vg4lpv8y5b0a22212bsjbvl5g22rc"))))
+    (build-system gnu-build-system)
+    (native-inputs
+     `(("qttools" ,qttools)))
+    (inputs
+     `(("qtbase" ,qtbase-5)
+       ("zlib" ,zlib)
+       ("mplayer" ,mplayer)))
+    (arguments
+     `(#:modules (,@%gnu-build-system-modules
+                  (srfi srfi-26))
+       #:tests? #false             ; no tests
+       #:make-flags (list (string-append "PREFIX=" (assoc-ref %outputs "out"))
+                          (string-append "CC=" ,(cc-for-target))
+                          ;; A KLUDGE to turn off invoking lrelease on the
+                          ;; project for now, because it fails consistently
+                          ;; with "WARNING: Could not find qmake spec
+                          ;; 'default'". See below.
+                          "LRELEASE=true")
+       #:phases
+       (modify-phases %standard-phases
+         (delete 'configure)
+         ;; Due to the above, we must run lrelease separately on each .ts file
+         ;; (as opposed to running `lrelease-pro smplayer.pro` for the entire
+         ;; project, as the Makefile does normally without the above kludge).
+         (add-after 'build 'compile-ts-files
+           (lambda _
+             (for-each (cut invoke "lrelease" <>)
+                       (find-files "./" "\\.ts$")))))))
+    (home-page "https://www.smplayer.info")
+    (synopsis "Complete front-end for MPlayer, a media player")
+    (description "SMPlayer is a free media player for Windows and Linux
+with built-in codecs that can play virtually all video and audio formats.
+It doesn't need any external codecs.  Just install SMPlayer and you'll be
+able to play all formats without the hassle to find and install codec packs.
+
+One of the most interesting features of SMPlayer: it remembers the
+settings of all files you play.  So you start to watch a movie but you have
+to leave... don't worry, when you open that movie again it will be resumed
+at the same point you left it, and with the same settings: audio track,
+subtitles, volume...
+
+SMPlayer is a graphical user interface (GUI) for the award-winning
+MPlayer, which is capable of playing almost all known video and audio
+formats.  But apart from providing access for the most common and useful
+options of MPlayer, SMPlayer adds other interesting features like the
+possibility to play Youtube videos or download subtitles.")
+    (license license:gpl2+)))
+
 (define-public mpv
   (package
     (name "mpv")
-- 
2.33.0

[bug#51534] [PATCH v2] gnu: Add smplayer.

[Liliana Marie Prikler]

Hi,

Am Montag, den 01.11.2021, 02:04 +0100 schrieb Attila Lendvai:
> * gnu/packages/video.scm (smplayer): New variable.
> ---
> 
> i forgot to double check the licence, it's gpl2+, not gpl3+.
> otherwise, it's the same as the previous patch.
> 
>  gnu/packages/video.scm | 60
> ++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 60 insertions(+)
> 
> diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
> index 245007f294..2915f85352 100644
> --- a/gnu/packages/video.scm
> +++ b/gnu/packages/video.scm
> @@ -2092,6 +2092,66 @@ (define-public mplayer
>  SVCD, DVD, 3ivx, DivX 3/4/5, WMV and H.264 movies.")
>      (license license:gpl2)))
>  
> +(define-public smplayer
> +  (package
> +    (name "smplayer")
> +    (version "21.10.0")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append
> +                    "mirror://sourceforge/smplayer/SMPlayer/"
> version
> +                    "/smplayer-" version ".tar.bz2"))
> +              (sha256
> +               (base32
> +                "12nvcl0cfix1xay9hfi7856vg4lpv8y5b0a22212bsjbvl5g22r
> c"))))
> +    (build-system gnu-build-system)
> +    (native-inputs
> +     `(("qttools" ,qttools)))
> +    (inputs
> +     `(("qtbase" ,qtbase-5)
> +       ("zlib" ,zlib)
> +       ("mplayer" ,mplayer)))
> +    (arguments
> +     `(#:modules (,@%gnu-build-system-modules
> +                  (srfi srfi-26))
> +       #:tests? #false             ; no tests
> +       #:make-flags (list (string-append "PREFIX=" (assoc-ref
> %outputs "out"))
> +                          (string-append "CC=" ,(cc-for-target))
> +                          ;; A KLUDGE to turn off invoking lrelease
> on the
> +                          ;; project for now, because it fails
> consistently
> +                          ;; with "WARNING: Could not find qmake
> spec
> +                          ;; 'default'". See below.
> +                          "LRELEASE=true")
> +       #:phases
> +       (modify-phases %standard-phases
> +         (delete 'configure)
> +         ;; Due to the above, we must run lrelease separately on
> each .ts file
> +         ;; (as opposed to running `lrelease-pro smplayer.pro` for
> the entire
> +         ;; project, as the Makefile does normally without the above
> kludge).
> +         (add-after 'build 'compile-ts-files
> +           (lambda _
> +             (for-each (cut invoke "lrelease" <>)
You might want to spell out that cut to avoid needing SRFI 26.  If you
do want to use SRFI 26 I'm pretty sure that cute is the more efficient
variant here.
> +                       (find-files "./" "\\.ts$")))))))
> +    (home-page "https://www.smplayer.info")
> +    (synopsis "Complete front-end for MPlayer, a media player")
> +    (description "SMPlayer is a free media player for Windows and
> Linux
> +with built-in codecs that can play virtually all video and audio
> formats.
> +It doesn't need any external codecs.  Just install SMPlayer and
> you'll be
> +able to play all formats without the hassle to find and install
> codec packs.
> +
> +One of the most interesting features of SMPlayer: it remembers the
> +settings of all files you play.  So you start to watch a movie but
> you have
> +to leave... don't worry, when you open that movie again it will be
> resumed
> +at the same point you left it, and with the same settings: audio
> track,
> +subtitles, volume...
> +
> +SMPlayer is a graphical user interface (GUI) for the award-winning
> +MPlayer, which is capable of playing almost all known video and
> audio
> +formats.  But apart from providing access for the most common and
> useful
> +options of MPlayer, SMPlayer adds other interesting features like
> the
> +possibility to play Youtube videos or download subtitles.")
Descriptions are for describing, not for advertising.  Please cut it
down to the meaningful bits.
> +    (license license:gpl2+)))
> +
I haven't built or ran the package, but from my lexical analysis I did
infer it was a more or less standard Qt thing.  I'm not sure if you
need to wrap some Qt-specific variables here similar to how it's done
in qt-build-system.  Otherwise LGTM.

Cheers

[bug#51534] [PATCH v3] gnu: Add smplayer v21.10.0.

[Attila Lendvai]

* gnu/packages/video.scm (smplayer): New variable.
---

thank you for the feedback Liliana!

i have edited the copy-pasted description to be shorter.

i've also done some more thourough testing, and indeed wrapping the executable
was necessary to add mpv (the media player backend) to the PATH. previously i
had it installed in my profile and SMPlayer found it from there.

 gnu/packages/video.scm | 58 ++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 58 insertions(+)

diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
index ff1abb308f..debc608694 100644
--- a/gnu/packages/video.scm
+++ b/gnu/packages/video.scm
@@ -2119,6 +2119,64 @@ (define-public mplayer
 SVCD, DVD, 3ivx, DivX 3/4/5, WMV and H.264 movies.")
     (license license:gpl2)))
 
+(define-public smplayer
+  (package
+    (name "smplayer")
+    (version "21.10.0")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append
+                    "mirror://sourceforge/smplayer/SMPlayer/" version
+                    "/smplayer-" version ".tar.bz2"))
+              (sha256
+               (base32
+                "12nvcl0cfix1xay9hfi7856vg4lpv8y5b0a22212bsjbvl5g22rc"))))
+    (build-system qt-build-system)
+    (native-inputs
+     `(("qttools" ,qttools)))
+    (inputs
+     `(("qtbase" ,qtbase-5)
+       ("zlib" ,zlib)
+       ("mpv" ,mpv)))
+    (arguments
+     `(#:tests? #false             ; no tests
+       #:make-flags (list (string-append "PREFIX=" (assoc-ref %outputs "out"))
+                          (string-append "CC=" ,(cc-for-target))
+                          ;; A KLUDGE to turn off invoking lrelease on the
+                          ;; project for now, because it fails consistently
+                          ;; with "WARNING: Could not find qmake spec
+                          ;; 'default'". See below.
+                          "LRELEASE=true")
+       #:phases
+       (modify-phases %standard-phases
+         (delete 'configure)
+         ;; Due to the above, we must run lrelease separately on each .ts file
+         ;; (as opposed to running `lrelease-pro smplayer.pro` for the entire
+         ;; project, as the Makefile does normally without the above kludge).
+         (add-after 'build 'compile-ts-files
+           (lambda _
+             (for-each (lambda (file)
+                         (invoke "lrelease" file))
+                       (find-files "./" "\\.ts$"))
+             #true))
+         (add-after 'install 'wrap-executable
+           (lambda* (#:key inputs outputs #:allow-other-keys)
+             (let* ((out (assoc-ref outputs "out"))
+                    (mpv (assoc-ref inputs "mpv")))
+               (wrap-program (string-append out "/bin/smplayer")
+                 `("PATH" ":" prefix
+                   ,(list (string-append mpv "/bin")))))
+             #true)))))
+    (home-page "https://www.smplayer.info")
+    (synopsis "Complete front-end for MPlayer, a media player")
+    (description "SMPlayer is a graphical user interface (GUI) for
+MPlayer, which is capable of playing almost all known video and audio
+formats.  Apart from providing access for the most common and useful
+options of MPlayer, SMPlayer adds other interesting features like the
+possibility to play Youtube videos, download subtitles, remember
+the last played position, etc.")
+    (license license:gpl2+)))
+
 (define-public mpv
   (package
     (name "mpv")
-- 
2.33.0

[bug#51534] [PATCH v4] gnu: Add smplayer v21.10.0.

[Attila Lendvai]

* gnu/packages/video.scm (smplayer): New variable.
---

v4 adds bash-minimal to the inputs as per guix lint. sorry for the miss!

there's another lint warning that i can't fix:

"smplayer@21.10.0: source not archived on Software Heritage and missing
from the Disarchive database"

and forgot to mention that v3 switched to the qt-build-system.

 gnu/packages/video.scm | 60 ++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 60 insertions(+)

diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
index ff1abb308f..5cb645baac 100644
--- a/gnu/packages/video.scm
+++ b/gnu/packages/video.scm
@@ -100,6 +100,7 @@ (define-module (gnu packages video)
   #:use-module (gnu packages avahi)
   #:use-module (gnu packages backup)
   #:use-module (gnu packages base)
+  #:use-module (gnu packages bash)
   #:use-module (gnu packages bison)
   #:use-module (gnu packages boost)
   #:use-module (gnu packages cdrom)
@@ -2119,6 +2120,65 @@ (define-public mplayer
 SVCD, DVD, 3ivx, DivX 3/4/5, WMV and H.264 movies.")
     (license license:gpl2)))
 
+(define-public smplayer
+  (package
+    (name "smplayer")
+    (version "21.10.0")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append
+                    "mirror://sourceforge/smplayer/SMPlayer/" version
+                    "/smplayer-" version ".tar.bz2"))
+              (sha256
+               (base32
+                "12nvcl0cfix1xay9hfi7856vg4lpv8y5b0a22212bsjbvl5g22rc"))))
+    (build-system qt-build-system)
+    (native-inputs
+     `(("qttools" ,qttools)))
+    (inputs
+     `(("bash-minimal" ,bash-minimal)
+       ("qtbase" ,qtbase-5)
+       ("zlib" ,zlib)
+       ("mpv" ,mpv)))
+    (arguments
+     `(#:tests? #false             ; no tests
+       #:make-flags (list (string-append "PREFIX=" (assoc-ref %outputs "out"))
+                          (string-append "CC=" ,(cc-for-target))
+                          ;; A KLUDGE to turn off invoking lrelease on the
+                          ;; project for now, because it fails consistently
+                          ;; with "WARNING: Could not find qmake spec
+                          ;; 'default'". See below.
+                          "LRELEASE=true")
+       #:phases
+       (modify-phases %standard-phases
+         (delete 'configure)
+         ;; Due to the above, we must run lrelease separately on each .ts file
+         ;; (as opposed to running `lrelease-pro smplayer.pro` for the entire
+         ;; project, as the Makefile does normally without the above kludge).
+         (add-after 'build 'compile-ts-files
+           (lambda _
+             (for-each (lambda (file)
+                         (invoke "lrelease" file))
+                       (find-files "./" "\\.ts$"))
+             #true))
+         (add-after 'install 'wrap-executable
+           (lambda* (#:key inputs outputs #:allow-other-keys)
+             (let* ((out (assoc-ref outputs "out"))
+                    (mpv (assoc-ref inputs "mpv")))
+               (wrap-program (string-append out "/bin/smplayer")
+                 `("PATH" ":" prefix
+                   ,(list (string-append mpv "/bin")))))
+             #true)))))
+    (home-page "https://www.smplayer.info")
+    (synopsis "Complete front-end for MPlayer, a media player")
+    (description "SMPlayer is a graphical user interface (GUI) for
+MPlayer, which is capable of playing almost all known video and audio
+formats.  Apart from providing access for the most common and useful
+options of MPlayer, SMPlayer adds other interesting features like the
+possibility to play Youtube videos, download subtitles, remember
+the last played position, etc.")
+    (license license:gpl2+)))
+
 (define-public mpv
   (package
     (name "mpv")
-- 
2.33.0

[bug#51534] [PATCH v4] gnu: Add smplayer v21.10.0.

[Liliana Marie Prikler]

Am Sonntag, den 28.11.2021, 13:12 +0100 schrieb Attila Lendvai:
> * gnu/packages/video.scm (smplayer): New variable.
> ---
> 
> v4 adds bash-minimal to the inputs as per guix lint. sorry for the
> miss!
> 
> there's another lint warning that i can't fix:
> 
> "smplayer@21.10.0: source not archived on Software Heritage and
> missing from the Disarchive database"
This one ought to disappear magically, as it's now queued for archival.
> and forgot to mention that v3 switched to the qt-build-system.
Don't worry too much about that; I'm the one who mentioned it first
after all.
>  gnu/packages/video.scm | 60
> ++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 60 insertions(+)
> 
> diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
> index ff1abb308f..5cb645baac 100644
> --- a/gnu/packages/video.scm
> +++ b/gnu/packages/video.scm
> @@ -100,6 +100,7 @@ (define-module (gnu packages video)
>    #:use-module (gnu packages avahi)
>    #:use-module (gnu packages backup)
>    #:use-module (gnu packages base)
> +  #:use-module (gnu packages bash)
>    #:use-module (gnu packages bison)
>    #:use-module (gnu packages boost)
>    #:use-module (gnu packages cdrom)
> @@ -2119,6 +2120,65 @@ (define-public mplayer
>  SVCD, DVD, 3ivx, DivX 3/4/5, WMV and H.264 movies.")
>      (license license:gpl2)))
>  
> +(define-public smplayer
> +  (package
> +    (name "smplayer")
> +    (version "21.10.0")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append
> +                    "mirror://sourceforge/smplayer/SMPlayer/"
> version
> +                    "/smplayer-" version ".tar.bz2"))
> +              (sha256
> +               (base32
> +                "12nvcl0cfix1xay9hfi7856vg4lpv8y5b0a22212bsjbvl5g22r
> c"))))
> +    (build-system qt-build-system)
> +    (native-inputs
> +     `(("qttools" ,qttools)))
> +    (inputs
> +     `(("bash-minimal" ,bash-minimal)
> +       ("qtbase" ,qtbase-5)
> +       ("zlib" ,zlib)
> +       ("mpv" ,mpv)))
> +    (arguments
> +     `(#:tests? #false             ; no tests
> +       #:make-flags (list (string-append "PREFIX=" (assoc-ref
> %outputs "out"))
> +                          (string-append "CC=" ,(cc-for-target))
> +                          ;; A KLUDGE to turn off invoking lrelease
> on the
> +                          ;; project for now, because it fails
> consistently
> +                          ;; with "WARNING: Could not find qmake
> spec
> +                          ;; 'default'". See below.
> +                          "LRELEASE=true")
> +       #:phases
> +       (modify-phases %standard-phases
> +         (delete 'configure)
> +         ;; Due to the above, we must run lrelease separately on
> each .ts file
> +         ;; (as opposed to running `lrelease-pro smplayer.pro` for
> the entire
> +         ;; project, as the Makefile does normally without the above
> kludge).
> +         (add-after 'build 'compile-ts-files
> +           (lambda _
> +             (for-each (lambda (file)
> +                         (invoke "lrelease" file))
> +                       (find-files "./" "\\.ts$"))
> +             #true))
> +         (add-after 'install 'wrap-executable
> +           (lambda* (#:key inputs outputs #:allow-other-keys)
> +             (let* ((out (assoc-ref outputs "out"))
> +                    (mpv (assoc-ref inputs "mpv")))
> +               (wrap-program (string-append out "/bin/smplayer")
> +                 `("PATH" ":" prefix
> +                   ,(list (string-append mpv "/bin")))))
> +             #true)))))
Rather than patching PATH, you ought to rewrite the calls to exec or
whatever is used to spawn mpv.
> +    (home-page "https://www.smplayer.info")
> +    (synopsis "Complete front-end for MPlayer, a media player")
> +    (description "SMPlayer is a graphical user interface (GUI) for
> +MPlayer, which is capable of playing almost all known video and
> audio
> +formats.  Apart from providing access for the most common and useful
> +options of MPlayer, SMPlayer adds other interesting features like
> the
> +possibility to play Youtube videos, download subtitles, remember
> +the last played position, etc.")
> +    (license license:gpl2+)))
Description LGTM now, but perhaps you ought to move the program itself
below mpv.

Cheers

[bug#51534] [PATCH v5] gnu: Add smplayer v21.10.0.

[Attila Lendvai]

* gnu/packages/video.scm (smplayer): New variable.
---

v5 moves smplayer below mvp.

as for PATH: it uses some heuristics to find the media player backend
binary (Helper::findExecutable), so patching it is not trivial. i
think it's more resilient to future changes to wrap it and set the PATH.

 gnu/packages/video.scm | 60 ++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 60 insertions(+)

diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
index ff1abb308f..ede085fe78 100644
--- a/gnu/packages/video.scm
+++ b/gnu/packages/video.scm
@@ -100,6 +100,7 @@ (define-module (gnu packages video)
   #:use-module (gnu packages avahi)
   #:use-module (gnu packages backup)
   #:use-module (gnu packages base)
+  #:use-module (gnu packages bash)
   #:use-module (gnu packages bison)
   #:use-module (gnu packages boost)
   #:use-module (gnu packages cdrom)
@@ -2213,6 +2214,65 @@ (define-public mpv
 projects while introducing many more.")
     (license license:gpl2+)))
 
+(define-public smplayer
+  (package
+    (name "smplayer")
+    (version "21.10.0")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append
+                    "mirror://sourceforge/smplayer/SMPlayer/" version
+                    "/smplayer-" version ".tar.bz2"))
+              (sha256
+               (base32
+                "12nvcl0cfix1xay9hfi7856vg4lpv8y5b0a22212bsjbvl5g22rc"))))
+    (build-system qt-build-system)
+    (native-inputs
+     `(("qttools" ,qttools)))
+    (inputs
+     `(("bash-minimal" ,bash-minimal)
+       ("qtbase" ,qtbase-5)
+       ("zlib" ,zlib)
+       ("mpv" ,mpv)))
+    (arguments
+     `(#:tests? #false             ; no tests
+       #:make-flags (list (string-append "PREFIX=" (assoc-ref %outputs "out"))
+                          (string-append "CC=" ,(cc-for-target))
+                          ;; A KLUDGE to turn off invoking lrelease on the
+                          ;; project for now, because it fails consistently
+                          ;; with "WARNING: Could not find qmake spec
+                          ;; 'default'". See below.
+                          "LRELEASE=true")
+       #:phases
+       (modify-phases %standard-phases
+         (delete 'configure)
+         ;; Due to the above, we must run lrelease separately on each .ts file
+         ;; (as opposed to running `lrelease-pro smplayer.pro` for the entire
+         ;; project, as the Makefile does normally without the above kludge).
+         (add-after 'build 'compile-ts-files
+           (lambda _
+             (for-each (lambda (file)
+                         (invoke "lrelease" file))
+                       (find-files "./" "\\.ts$"))
+             #true))
+         (add-after 'install 'wrap-executable
+           (lambda* (#:key inputs outputs #:allow-other-keys)
+             (let* ((out (assoc-ref outputs "out"))
+                    (mpv (assoc-ref inputs "mpv")))
+               (wrap-program (string-append out "/bin/smplayer")
+                 `("PATH" ":" prefix
+                   ,(list (string-append mpv "/bin")))))
+             #true)))))
+    (home-page "https://www.smplayer.info")
+    (synopsis "Complete front-end for MPlayer, a media player")
+    (description "SMPlayer is a graphical user interface (GUI) for
+MPlayer, which is capable of playing almost all known video and audio
+formats.  Apart from providing access for the most common and useful
+options of MPlayer, SMPlayer adds other interesting features like the
+possibility to play Youtube videos, download subtitles, remember
+the last played position, etc.")
+    (license license:gpl2+)))
+
 (define-public gnome-mpv
   (deprecated-package "gnome-mpv" celluloid))
 
-- 
2.33.0

bug#51534: [PATCH] gnu: Add smplayer.

[Ludovic Courtès]

Hi,

Attila Lendvai <attila@lendvai.name> skribis:

> * gnu/packages/video.scm (smplayer): New variable.

AFAICS this addresses Liliana’s concerns so I applied it on their
behalf.

Thanks!

Ludo’.