From: Felix Lechner via Guix-patches via <guix-patches@gnu.org>
To: 62156@debbugs.gnu.org
Cc: Sergey Trofimov <sarg@sarg.org.ru>,
Felix Lechner <felix.lechner@lease-up.com>
Subject: [bug#62156] [PATCH v3 2/2] lint: Append "/info/refs" to git-reference-url.
Date: Mon, 20 Mar 2023 09:57:19 -0700 [thread overview]
Message-ID: <fb004d22cf46a6eddecca4ac01c7d54cf5da649e.1679331429.git.felix.lechner@lease-up.com> (raw)
In-Reply-To: <b423186f49dfdfff336d4ff8058fe7190c132a73.1679331429.git.felix.lechner@lease-up.com>
For the atftp package added in the preceeding commit, lint produced this
warning:
gnu/packages/networking.scm:2924:5: atftp@0.8.0:
URI https://git.code.sf.net/p/atftp/code not reachable:
404 ("Not Found")
Thanks to Sergey Trofimov for suggesting a fix! [1]
[1] https://issues.guix.gnu.org/62156#3
It was implemented here, and the warning disappeared.
* guix/lint.scm (check-source): Append "/info/refs" to git-reference-url.
Co-authored-by: Sergey Trofimov <sarg@sarg.org.ru>
---
guix/lint.scm | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/guix/lint.scm b/guix/lint.scm
index a1a27873d9..394d68c472 100644
--- a/guix/lint.scm
+++ b/guix/lint.scm
@@ -1224,7 +1224,9 @@ (define (warnings-for-uris uris)
'())))
((git-reference? (origin-uri origin))
(warnings-for-uris
- (list (string->uri (git-reference-url (origin-uri origin))))))
+ (list (string->uri (string-append
+ (git-reference-url (origin-uri origin))
+ "/info/refs")))))
((or (svn-reference? (origin-uri origin))
(svn-multi-reference? (origin-uri origin)))
(let ((uri (svn-reference-uri-with-userinfo (origin-uri origin))))
--
2.39.1
next prev parent reply other threads:[~2023-03-20 16:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-13 4:41 [bug#62156] [PATCH 0/1] gnu: Add atftp Felix Lechner via Guix-patches via
2023-03-13 4:42 ` [bug#62156] [PATCH 1/1] " Felix Lechner via Guix-patches via
2023-03-19 23:03 ` [bug#62156] [PATCH v2] " Felix Lechner via Guix-patches via
2023-03-20 7:34 ` Sergey Trofimov
2023-03-20 16:57 ` [bug#62156] [PATCH v3 1/2] " Felix Lechner via Guix-patches via
2023-03-20 16:57 ` Felix Lechner via Guix-patches via [this message]
2023-03-21 4:25 ` [bug#62156] [PATCH v4 " Felix Lechner via Guix-patches via
2023-03-21 4:25 ` [bug#62156] [PATCH v4 2/2] lint: Append "/info/refs" to git-reference-url Felix Lechner via Guix-patches via
2023-03-27 16:49 ` bug#62156: [PATCH 0/1] gnu: Add atftp Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb004d22cf46a6eddecca4ac01c7d54cf5da649e.1679331429.git.felix.lechner@lease-up.com \
--to=guix-patches@gnu.org \
--cc=62156@debbugs.gnu.org \
--cc=felix.lechner@lease-up.com \
--cc=sarg@sarg.org.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).