From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id 6M0CAUhp+mNIMAEAbAwnHQ (envelope-from ) for ; Sat, 25 Feb 2023 21:02:16 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id CFYpAEhp+mN5VgEAG6o9tA (envelope-from ) for ; Sat, 25 Feb 2023 21:02:16 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9A9DA1F48B for ; Sat, 25 Feb 2023 21:02:15 +0100 (CET) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tobias.gr header.s=2018 header.b=LvEy5uWm; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1677355335; a=rsa-sha256; cv=none; b=thAmsPSu5v1Gq09gkY4sHq5IxQXdpXx6h8V/LPoWQZL467V+JlACnxmLuC+bTbMZLRvx/X FICM3qu3Ewd4bTbZQrjj1X+kau7uG/Ef2+RQv+4AZzfuCgQ+HvALNC5ivtlxDPlyxe6Fmb +RDwZzeDtJjGZzFySNhmlBEnlqU33Rcn71UBtiq1sstkCBp1/mtjj0yr8Fk9KcZlttySNf kbwvItW4Z0VLr+m6DHf4hYsfHBEhHggKI7YfoCs12WJkFNHrV0ZBLUILxxj0xqSZh94DZQ A4njUYVnYdKyIJ4sfMWX8xKo5h8HvI3qIxIacB2FeqnOnSWTa0Y6d2WRPS38bg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tobias.gr header.s=2018 header.b=LvEy5uWm; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1677355335; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=dZrz+kSBV6YkRQnPhT4EX50DJn1xPUs7NErNtlqoU7o=; b=KMEtwfqpZGK5yfccF2U7RCNvIHPNmxBJ9luKqzm+n7CM2G3IiJhRguCMLVs/cEJUCojTxy GYbxtEc5SpRlbsY6FipoDK/PMUpM4LQ+gqH92KK/GjpIl7EqMDCGA3AkgvdA+PepJmbLoS ZFQViwx8cEgbGB9kigQ5DgkGtVv/XeClp8yC2rX27r9SL9jZaMgYS0fAV3EyB0P/3X56VD JfbXs19q7KicVw0nQXRodAxMERohCXC/5saEaJccWuGeoQLV4oCj1g1VID1MPna05XBrWV e//fiS9diA1PaBSt8k6v5MczJGVQXKT8Nj//nTybmWPZXgBD04FaSokDY5a41Q== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pW0k9-0000mX-VO; Sat, 25 Feb 2023 15:02:06 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pW0k6-0000mO-R4 for guix-patches@gnu.org; Sat, 25 Feb 2023 15:02:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pW0k6-00085F-F3 for guix-patches@gnu.org; Sat, 25 Feb 2023 15:02:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pW0k6-0003di-02 for guix-patches@gnu.org; Sat, 25 Feb 2023 15:02:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#61686] [PATCH] gnu: Add dropwatch. Resent-From: Tobias Geerinckx-Rice Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 25 Feb 2023 20:02:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61686 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Bruno Victal Cc: 61686@debbugs.gnu.org, Nicolas Goaziou Received: via spool by 61686-submit@debbugs.gnu.org id=B61686.167735530813969 (code B ref 61686); Sat, 25 Feb 2023 20:02:01 +0000 Received: (at 61686) by debbugs.gnu.org; 25 Feb 2023 20:01:48 +0000 Received: from localhost ([127.0.0.1]:41598 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pW0jr-0003dE-Kv for submit@debbugs.gnu.org; Sat, 25 Feb 2023 15:01:47 -0500 Received: from tobias.gr ([80.241.217.52]:48722) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pW0jp-0003d5-Qh for 61686@debbugs.gnu.org; Sat, 25 Feb 2023 15:01:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=2018; bh=dZrz+kSBV6YkR QnPhT4EX50DJn1xPUs7NErNtlqoU7o=; h=references:in-reply-to:subject:cc: to:from:date; d=tobias.gr; b=LvEy5uWmiyLMSzTytvQMZJtE6aVHp2kCQZMa3miy9 S7vdTMS2na+GrztE0T6rk/sjtGv7jXILvtAKap5hqOPSQYGSvYtUO8UnoW+cxHlCH4GKGA LjBpqqQrzu1leHXf8LY65uJQpj5jKr0VcHIwjF/R6P0guy9vSETLOXwikV2wOctaoEdnyc SwEScg8n5EHG6agD6nJq2fVTxqvOY/5xOY+ZDvvWNc5IYTf7L2i8hWJ6sbTT4ZM5b19QG/ nbOb+p7Mtlwb0L+WAnmiBXGxz7Sng0lUbC07xHel0R3l5JORs/5SxMmQzLbvOo9wz0hvqI RgzwlmyAVU8VAdhcWvdIA== Received: by submission.tobias.gr (OpenSMTPD) with ESMTP id ae0a7614; Sat, 25 Feb 2023 20:01:41 +0000 (UTC) MIME-Version: 1.0 Date: Sat, 25 Feb 2023 21:01:41 +0100 In-Reply-To: <6ae388b3-fea8-2b3e-d32c-da1119d090a7@makinata.eu> References: <43b683614e136e70894ba395a6759dc714fe2faf.1677006911.git.mirai@makinata.eu> <87cz5znxzx.fsf@nicolasgoaziou.fr> <6ae388b3-fea8-2b3e-d32c-da1119d090a7@makinata.eu> Message-ID: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Tobias Geerinckx-Rice X-Migadu-Queue-Id: 9A9DA1F48B X-Spam-Score: -4.28 X-Migadu-Spam-Score: -4.28 X-Migadu-Scanner: scn0.migadu.com X-ACL-Warn: , Tobias Geerinckx-Rice via Guix-patches From: Tobias Geerinckx-Rice via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-TUID: FmwF+ZrNQtnN Hi Bruno, On 2023-02-25 20:21, Bruno Victal wrote: >> Do you think it is worth mentioning in the description? AFAICT, Guix >> does not set this option by default. > > With e701f67246680c81dd111cf7136b936bf7d8718b, this is now set by > default. …on all architectures: it was inconsistently built-in on ARM, and missing from x86. It's now modular everywhere. \o/ To my pleasant surprise, it's automatically loaded when I start dropwatch as a regular user. \o/ > Is there a reason for dropping the suffix for GitHub? AFAIK it "works" > but it's not the same url that they give out for cloning. It works, no quotes. No technical reason to drop it, but many people do, perhaps so it matches the ‘home page’ many GitHubbed projects now lack. It's also provably shorter. If you feel strongly about keeping it, there's precedent in Guix. It's just very rare (2.2%). Consistency has its charms. >> You also need to add >> >> (file-name (git-file-name name version)) >> >> for proper naming in the store. > > Is this always required? Yes, for git checkouts. > I assumed the default if unspecified was "good enough" and > that snippet was used for repositories with problematic names. Nope. It'll clone & build fine, but please set a meaningful name for humans instead of: /gnu/store/ja3blcdqia00k15vpayfc9kzsjijfpw0-git-checkout Which is also a bonus footgun when someone inexperienced tries to update the package without changing the hash, because there's no version+commit information in the name. >>> + (home-page "https://github.com/nhorman/dropwatch") >>> + (synopsis "Kernel dropped packet monitor") ‘Monitor [for] dropped network packets’, or ‘Monitor [for] network packets dropped by the kernel’, maybe? The above (RedHat) version just doesn't parse naturally for me. >> You need separate sentences with two spaces, per Texinfo syntax. > > This is actually not strictly necessary Still. Kind regards, T G-R Sent from a Web browser. Excuse or enjoy my brevity.