From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id aJVANR3/IGIbUwEAgWs5BA (envelope-from ) for ; Thu, 03 Mar 2022 18:47:09 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id YGoNMh3/IGKvvgAAauVa8A (envelope-from ) for ; Thu, 03 Mar 2022 18:47:09 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 60F4AC78C for ; Thu, 3 Mar 2022 18:47:09 +0100 (CET) Received: from localhost ([::1]:59552 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nPpXg-0002qJ-IP for larch@yhetil.org; Thu, 03 Mar 2022 12:47:08 -0500 Received: from eggs.gnu.org ([209.51.188.92]:57812) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nPpXa-0002kl-3g for guix-patches@gnu.org; Thu, 03 Mar 2022 12:47:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:49718) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nPpXZ-0003vy-PA for guix-patches@gnu.org; Thu, 03 Mar 2022 12:47:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nPpXZ-0005DS-Lq for guix-patches@gnu.org; Thu, 03 Mar 2022 12:47:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#54221] [PATCH 3/4] gnu: vim: Update package style. Resent-From: Maxime Devos Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 03 Mar 2022 17:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54221 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: SeerLite , 54221@debbugs.gnu.org Received: via spool by 54221-submit@debbugs.gnu.org id=B54221.164632960520024 (code B ref 54221); Thu, 03 Mar 2022 17:47:01 +0000 Received: (at 54221) by debbugs.gnu.org; 3 Mar 2022 17:46:45 +0000 Received: from localhost ([127.0.0.1]:43615 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nPpXJ-0005Ct-Ab for submit@debbugs.gnu.org; Thu, 03 Mar 2022 12:46:45 -0500 Received: from laurent.telenet-ops.be ([195.130.137.89]:34068) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nPpXG-0005Cj-Rw for 54221@debbugs.gnu.org; Thu, 03 Mar 2022 12:46:43 -0500 Received: from ptr-bvsjgyhxw7psv60dyze.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:3c5f:2eff:feb0:ba5a]) by laurent.telenet-ops.be with bizsmtp id 1tmg2700h4UW6Th01tmhHt; Thu, 03 Mar 2022 18:46:41 +0100 Message-ID: From: Maxime Devos Date: Thu, 03 Mar 2022 18:46:33 +0100 In-Reply-To: References: <6002b969ed2f353fef0e8fa87d4fc7d01d3344fa.camel@telenet.be> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-fQZU9w8BPMG0FZP7KzLu" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1646329601; bh=ZQGeztsofHn4FgBdeOoeor+mfqtwlVxpDdqjiT4Ahmc=; h=Subject:From:To:Date:In-Reply-To:References; b=eo2USFOvc6qyQyEurD1B4TbPPsmtR+j12txoSfRu+W9qne0WrUe4iqluqpbCdKtZy rO2EKOt6N8gjGsV1SR6VmuR5yoSzIn3wRwne2bEglwxpD8XUs26b5Q9oz5z2ia+K7l emMQXFHeZIh4U8qt8h9mYnHn6KCdZSXs3D8Ibjqg5XiBmiti8poeqssk1HCfUHpN3I V8KgL7hqoskyCVRna04WHE2+1B0e2y/rQ6YOD2u3q9FJbVr9kzqhhAaMYK1Fkykxj5 rBCV5Pi/ccPvhL3ei95fgi54FDRsz13OPebW2ofAqMZvsBLYqVhU0fn7PmY7q/2+K/ Dq5xIq7Sn03Vw== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1646329629; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=ZQGeztsofHn4FgBdeOoeor+mfqtwlVxpDdqjiT4Ahmc=; b=dYLE31qNfWt10MpodGVTmuk4xFYvQpjGYkzqR8IkVJmx6ZE4E1Ko4JIoGBXPJEZ9gFf8cr 0NMA0KB2YKGJNF0n0G1zUhxl557X1cRSLIcp7epYieLVZy5WHUMBE/vijEsclRIBJO7S3H m+Iop4IEvEpOLsH5qvt7zQzL1oDyBf2d9PLmsUCegvoGPJ8qTPFXj/JVirXwlZXnSj42Ml eu153NS5tcFqM5IsyTsYF1HME0xapoaoWpwGHIDGEEZw4qjr23Zbi2Y6Wc0SkLMY2m5h9n DzG0ZRvb9tI6CMYMHTy3D4higfrTQvlRgZk7PfWYe+QZZjcSNKhIqOwq6GaLNw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1646329629; a=rsa-sha256; cv=none; b=HH00AhHYnPntJZF1uw2Kg8Yaw7wbjexHxv3/PRDzkXYopQdY3mvv7XolNUBgTyqmMqyF6z 0/D7N8YtlmXNIori3Fya6FCwbmjDDk9Rapxczc26Z4R/2JoEeB8kOkcMgmmFcJmOx7QUTq 8h87xQEztSQxcKB0MYehcShsspkDKRuOh7VRnF4V/qsUGmuuUmE7iPjbfdM7EWlQHDouno WvS3A404APzCrHZCRL5ivWPG8kUP3QMElCaLmukzC7BXHxcksJtDY8YhE/uhA4Xj/eDx42 8+2dR3kcQrg2xkgDf2hYLpCgDDNeJwhwWCCfrdFmbFnH/dffZyH9djhxd/+zXQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r22 header.b=eo2USFOv; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 3.64 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r22 header.b=eo2USFOv; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 60F4AC78C X-Spam-Score: 3.64 X-Migadu-Scanner: scn0.migadu.com X-TUID: RTU+DH0syeOS --=-fQZU9w8BPMG0FZP7KzLu Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable SeerLite schreef op do 03-03-2022 om 13:49 [-0300]: > The blog post that introduces label-less inputs also introduces=20 > 'search-input-file', which made me think they were both part of the=20 > "package definition modernization process". The problem with 'which' was that it looks in 'native-inputs' (+ inputs when compiling natively), even when we need 'inputs'. To fix this, adding an 'inputs/native-inputs' argument was proposed (https://issues.guix.gnu.org/47869). That interface was considered a bit weird, so then (string-append (assoc-ref ...) "bin/...") was proposed. That's rather verbose though, so 'search-input-file' was introduced. In short, 'search-input-file' was introduced to help with locating binaries from 'inputs' (at least from my POV, shortly after ludo began using 'search-input-file' for delabelification). For looking in native-inputs (compilation tools etc.), I would prefer 'which' above the 'search-input-file' because it's a lot more concise, though I suppose there is an argument to be made for using 'search- input-file' for consistency. There's the downside of not raising an exception in case the file is not found though. However, there appears to be very few code that actually relies on the 'return #f' behaviour (search for '(or (which' and '(if (which'), so I think the behaviour can be changed without much trouble (on 'core-updates'). Greetings, Maxime. --=-fQZU9w8BPMG0FZP7KzLu Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYiD++RccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7rurAP4mpUFtsiTZUpCfqF0YJTcX50Jd i5qX/4fMw8NF6gQ4DgEAjOs9O1WJ+cUc85zD7Ymy9GSmObdkpZjKvr+roOOZ4QI= =7vmX -----END PGP SIGNATURE----- --=-fQZU9w8BPMG0FZP7KzLu--