From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id MLf/J4TKsV5aGgAA0tVLHw (envelope-from ) for ; Tue, 05 May 2020 20:20:20 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id sM2QCpDKsV7EVAAA1q6Kng (envelope-from ) for ; Tue, 05 May 2020 20:20:32 +0000 Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:470:142::17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 4A0FB940D36 for ; Tue, 5 May 2020 20:20:28 +0000 (UTC) Received: from localhost ([::1]:55088 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jW43I-0005au-Fy for larch@yhetil.org; Tue, 05 May 2020 16:20:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44000) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jW42s-0005Zn-RW for guix-patches@gnu.org; Tue, 05 May 2020 16:20:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:54339) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jW42s-0005Ek-GK for guix-patches@gnu.org; Tue, 05 May 2020 16:20:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jW42s-0008Cw-CS for guix-patches@gnu.org; Tue, 05 May 2020 16:20:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#41053] [PATCH 1/2] gnu: Add ableton-link. Resent-From: goodoldpaul@autistici.org Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 05 May 2020 20:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41053 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Marius Bakke Cc: 41053@debbugs.gnu.org Received: via spool by 41053-submit@debbugs.gnu.org id=B41053.158870995031473 (code B ref 41053); Tue, 05 May 2020 20:20:02 +0000 Received: (at 41053) by debbugs.gnu.org; 5 May 2020 20:19:10 +0000 Received: from localhost ([127.0.0.1]:37649 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jW422-0008BY-1O for submit@debbugs.gnu.org; Tue, 05 May 2020 16:19:10 -0400 Received: from latitanza.investici.org ([82.94.249.234]:56469) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jW41z-0008BO-Jd for 41053@debbugs.gnu.org; Tue, 05 May 2020 16:19:08 -0400 Received: from 1.mail-backend.investici.org (unknown [10.0.0.11]) by latitanza.investici.org (Postfix) with ESMTP id EC8E9120178; Tue, 5 May 2020 20:19:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=autistici.org; s=stigmate; t=1588709946; bh=QwWqez0/3YbN/DtEleNrm6RRtgzFQSrtRvPulEEvQDw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=tng/h8HhjI4EP6RkCS+AMPdT36ywClzrg3GmOiRpV8AcLt8rVk8hIH/l0ub822rEl 3cVH0cM47M7ZwjS/DcI2YZnwStPV0yqv19+O9xZ2sU6f33Ba5iK+ylUlnxCm7iJgga qC68vxGK2wWwaZu2j9QLnXZ6yZod79bRZk8B8EmM= Received: from 1.webmail.investici.org (localhost [127.0.0.1]) (Authenticated sender: goodoldpaul@autistici.org) by 1.mail-backend.investici.org (Postfix) with ESMTPA id C53FDBEE39; Tue, 5 May 2020 20:19:05 +0000 (UTC) MIME-Version: 1.0 Date: Tue, 05 May 2020 20:19:05 +0000 From: goodoldpaul@autistici.org In-Reply-To: <87368ez3nq.fsf@devup.no> References: <7ab14d0b64acca502e134f57bd1c4ac9@autistici.org> <20200503160608.5905-1-goodoldpaul@autistici.org> <87368ez3nq.fsf@devup.no> User-Agent: Roundcube Webmail Message-ID: X-Sender: goodoldpaul@autistici.org Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.0 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 X-Spam-Score: -0.00 Authentication-Results: aspmx1.migadu.com; dkim=fail (rsa verify failed) header.d=autistici.org header.s=stigmate header.b=tng/h8Hh; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 2001:470:142::17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Scan-Result: default: False [-0.00 / 13.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; GENERIC_REPUTATION(0.00)[-0.49579730119841]; XM_UA_NO_VERSION(0.01)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2001:470:142::/48:c]; IP_REPUTATION_HAM(0.00)[asn: 22989(0.12), country: US(-0.00), ip: 2001:470:142::17(-0.50)]; DWL_DNSWL_BLOCKED(0.00)[2001:470:142::17:from]; R_DKIM_REJECT(1.00)[autistici.org:s=stigmate]; MX_GOOD(-0.50)[cached: eggs.gnu.org]; RCPT_COUNT_TWO(0.00)[2]; DKIM_TRACE(0.00)[autistici.org:-]; MAILLIST(-0.20)[mailman]; FREEMAIL_TO(0.00)[fastmail.com]; RCVD_IN_DNSWL_FAIL(0.00)[2001:470:142::17:server fail]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:22989, ipnet:2001:470:142::/48, country:US]; MID_RHS_MATCH_FROM(0.00)[]; TAGGED_FROM(0.00)[larch=yhetil.org]; FROM_NEQ_ENVFROM(0.00)[goodoldpaul@autistici.org,guix-patches-bounces@gnu.org]; ARC_NA(0.00)[]; FORGED_RECIPIENTS_MAILLIST(0.00)[]; URIBL_BLOCKED(0.00)[dep.debian.net:url]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[autistici.org]; HAS_LIST_UNSUB(-0.01)[]; FROM_NO_DN(0.00)[]; RCVD_COUNT_SEVEN(0.00)[9]; FORGED_SENDER_MAILLIST(0.00)[] X-TUID: jascw/i1w+Cv Hi Marius, >> + (arguments >> + `(#:configure-flags >> + '("-DBUILD_TYPE=Release" > > You can use #:build-type instead of passing -DCMAKE_BUILD_TYPE. Is > there a particular reason why the default "RelWithDebInfo" does not cut > it? It's just because I read on CMake's website that it's supposed to enable "-O3" flags, but I'm no expert. Also, reading further, it seems that too much aggressive optimizations can sometimes break software. For now I removed it and if there will ever be the need it can be easily reinstated. >> + "-checkout/"))) >> + (substitute* (string-append source >> + >> "cmake_include/AsioStandaloneConfig.cmake") > > Note: if you run this phase immediately after 'unpack, you don't have > to > add a binding for the source directory as you can refer to this file by > just (substitute* "cmake_include/AsioStandaloneConfig.cmake"). But > perhaps that will break things? Yes sadly it does, because it makes CMake think that the headers will be in "../../../include" while they are at the same level. >> + (for-each (lambda (test-file) >> + (delete-file test-file)) >> + '("bin/LinkDiscoveryTest" >> "bin/LinkCoreTest")) >> + (copy-recursively "bin" bin) >> + (copy-recursively (string-append source >> "/include/ableton") >> + (string-append out >> "/include/ableton")) >> + (install-file (string-append source >> "/AbletonLinkConfig.cmake") >> + lib-cmake) >> + (install-file (string-append source >> + >> "/cmake_include/AsioStandaloneConfig.cmake") >> + (string-append lib-cmake >> "/cmake_include")) > > Terrible that we have to install "manually" here! But oh well. > Yes it is, upstream seems to not provide a "make install" target :( >> diff --git >> a/gnu/packages/patches/ableton-link-system-libraries-debian.patch >> b/gnu/packages/patches/ableton-link-system-libraries-debian.patch >> new file mode 100644 >> index 0000000000..0c12c62546 >> --- /dev/null >> +++ b/gnu/packages/patches/ableton-link-system-libraries-debian.patch >> @@ -0,0 +1,27 @@ >> +Description: Drop dependencies on included 3rd-party libs >> + upstream includes git-submodules for Catch and ASIO (not found in >> the tarball). >> + on Debian we want to use the system provided libraries. >> +Author: IOhannes m zmölnig >> +Origin: Debian >> +Forwarded: not-needed >> +Last-Update: 2016-10-26 >> +--- >> +This patch header follows DEP-3: http://dep.debian.net/deps/dep3/ > > Great that you took care to unbundle dependencies. Can you add a link > to where you found this patch? I got it from Debian's package, I now added a link in the patch header. Thanks for your patience, Giacomo