From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:52213) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iolx1-0002hV-Iw for guix-patches@gnu.org; Tue, 07 Jan 2020 05:19:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iolx0-0001on-80 for guix-patches@gnu.org; Tue, 07 Jan 2020 05:19:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:41332) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iolwz-0001oT-VT for guix-patches@gnu.org; Tue, 07 Jan 2020 05:19:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iolwz-00064x-Qn for guix-patches@gnu.org; Tue, 07 Jan 2020 05:19:01 -0500 Subject: [bug#39004] [PATCH] gnu: pcmanfm-qt: fix open file issue Resent-Message-ID: Mime-Version: 1.0 Message-Id: In-Reply-To: <20200107105214.502793d3@scratchpost.org> References: <9b9644a5-b79d-4293-8311-762a49f46a12@www.fastmail.com> <20200107105214.502793d3@scratchpost.org> Date: Tue, 07 Jan 2020 13:47:53 +0330 From: "Reza Alizadeh Majd" Content-Type: multipart/mixed; boundary=48349a3722b84745bbceaaae5d98c3e5 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Danny Milosavljevic Cc: 39004@debbugs.gnu.org --48349a3722b84745bbceaaae5d98c3e5 Content-Type: text/plain Hi Danny, On Tue, Jan 7, 2020, at 1:22 PM, Danny Milosavljevic wrote: > Hi Reza, > > thanks for the patch. I think that it is the right way for now. > > But GIO_LAUNCH_DESKTOP is not interpreted as a list by glib. > > It would be better to communicate intent by constructing GIO_LAUNCH_DESKTOP as > > (wrap-program (string-append out "/bin/pcmanfm-qt") > `("GIO_LAUNCH_DESKTOP" = > (,(string-append glib "/bin/gio-launch-desktop")))) > > . > > Otherwise, with ":" and "prefix" it very much sounded like a list. > > Also, could you make it check whether /bin/gio-launch-desktop exists and > error out otherwise? That is in order for us to notice the workaround > later when we move the gio-launch-desktop executable. > > (if (file-exists? ".........../bin/gio-launch-desktop") > (wrap-program ........) > (error "Could not find gio-launch-desktop")) > Thanks for your guidance, I updated the patch and applied both of - GIO_LAUNCH_DESKTOP variable format - gio-launch-desktop existence check to this new patch. -- Regards Reza Alizadeh Majd PantherX Team --48349a3722b84745bbceaaae5d98c3e5 Content-Disposition: attachment;filename="0001-gnu-pcmanfm-qt-fix-double-click-issue.patch" Content-Type: application/octet-stream; name="0001-gnu-pcmanfm-qt-fix-double-click-issue.patch" Content-Transfer-Encoding: BASE64 RnJvbSBjYjVjOTU5N2FjODM3ODk4MWJiNzBmZGM4ZmEwMWY2NDQwNmM1Mzk1IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBSZXphIEFsaXphZGVoIE1hamQgPHIubWFqZEBwYW50 aGVyeC5vcmc+CkRhdGU6IFR1ZSwgNyBKYW4gMjAyMCAxMToyNDowNSArMDMzMApTdWJqZWN0 OiBbUEFUQ0hdIGdudTogcGNtYW5mbS1xdDogZml4IGRvdWJsZS1jbGljayBpc3N1ZQoKKiBn bnUvcGFja2FnZXMvbHhxdC5zY20gKHBjbWFuZm0tcXQpOiBzZXQgR0lPX0xBVU5DSF9ERVNL VE9QIGVudmlyb25tZW50CnZhcmlhYmxlIHRvIHJlbGF0ZWQgbG9jYXRpb24gaW4gImJpbiIg b3V0cHV0IG9mICJnbGliIiBwYWNrYWdlLgotLS0KIGdudS9wYWNrYWdlcy9seHF0LnNjbSB8 IDE1ICsrKysrKysrKysrKystLQogMSBmaWxlIGNoYW5nZWQsIDEzIGluc2VydGlvbnMoKyks IDIgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvZ251L3BhY2thZ2VzL2x4cXQuc2NtIGIv Z251L3BhY2thZ2VzL2x4cXQuc2NtCmluZGV4IDVhMzcwOGUzMGEuLjVjNTc1NGRjMGMgMTAw NjQ0Ci0tLSBhL2dudS9wYWNrYWdlcy9seHF0LnNjbQorKysgYi9nbnUvcGFja2FnZXMvbHhx dC5zY20KQEAgLTk4NCw3ICs5ODQsOCBAQCBjb21wb25lbnRzIHRvIGJ1aWxkIGRlc2t0b3Ag ZmlsZSBtYW5hZ2VycyB3aGljaCBiZWxvbmdzIHRvIExYREUuIikKICAgICAgICAgKGJhc2Uz MiAiMHgzYzI1aW5seGxsOTY1eHN6eDM3bW5sNWdwM3NtbTJoN3gwNGY2N3owcWxoM3ZzYnJq cSIpKSkpCiAgICAgKGJ1aWxkLXN5c3RlbSBjbWFrZS1idWlsZC1zeXN0ZW0pCiAgICAgKGlu cHV0cwotICAgICBgKCgibGliZm0tcXQiICxsaWJmbS1xdCkKKyAgICAgYCgoImdsaWIiICxn bGliICJiaW4iKQorICAgICAgICgibGliZm0tcXQiICxsaWJmbS1xdCkKICAgICAgICAoInF0 YmFzZSIgLHF0YmFzZSkKICAgICAgICAoInF0eDExZXh0cmFzIiAscXR4MTFleHRyYXMpKSkK ICAgICAobmF0aXZlLWlucHV0cwpAQCAtMTAwMCw3ICsxMDAxLDE3IEBAIGNvbXBvbmVudHMg dG8gYnVpbGQgZGVza3RvcCBmaWxlIG1hbmFnZXJzIHdoaWNoIGJlbG9uZ3MgdG8gTFhERS4i KQogICAgICAgICAgICAgIChzdWJzdGl0dXRlKiAnKCJhdXRvc3RhcnQvQ01ha2VMaXN0cy50 eHQiKQogICAgICAgICAgICAgICAgKCgiREVTVElOQVRJT04gXCJcXCRcXHtMWFFUX0VUQ19Y REdfRElSXFx9IikKICAgICAgICAgICAgICAgICAiREVTVElOQVRJT04gXCJldGMveGRnIikp Ci0gICAgICAgICAgICAgI3QpKSkpKQorICAgICAgICAgICAgICN0KSkKKyAgICAgICAgIChh ZGQtYWZ0ZXIgJ2luc3RhbGwgJ3dyYXAtZ2xpYgorICAgICAgICAgICAobGFtYmRhKiAoIzpr ZXkgb3V0cHV0cyBpbnB1dHMgIzphbGxvdy1vdGhlci1rZXlzKQorICAgICAgICAgICAgIChs ZXQqICgob3V0ICAoYXNzb2MtcmVmIG91dHB1dHMgIm91dCIpKQorICAgICAgICAgICAgICAg ICAgICAoZ2xpYiAoYXNzb2MtcmVmIGlucHV0cyAiZ2xpYiIpKQorICAgICAgICAgICAgICAg ICAgICAoZ2lvLWV4ZS1wYXRoIChzdHJpbmctYXBwZW5kIGdsaWIgIi9iaW4vZ2lvLWxhdW5j aC1kZXNrdG9wIikpKQorICAgICAgICAgICAgICAgKGlmIChmaWxlLWV4aXN0cz8gZ2lvLWV4 ZS1wYXRoKQorICAgICAgICAgICAgICAgICAod3JhcC1wcm9ncmFtIChzdHJpbmctYXBwZW5k IG91dCAiL2Jpbi9wY21hbmZtLXF0IikKKyAgICAgICAgICAgICAgICAgICBgKCJHSU9fTEFV TkNIX0RFU0tUT1AiID0gKCxnaW8tZXhlLXBhdGgpKSkKKyAgICAgICAgICAgICAgICAgKGVy cm9yICJjb3VsZG4ndCBmaW4gZ2lvLWxhdW5jaC1kZXNrdG9wLXBhdGgiKSkKKyAgICAgICAg ICAgICAgICN0KSkpKSkpCiAgICAgKGhvbWUtcGFnZSAiaHR0cHM6Ly9seHF0Lm9yZy8iKQog ICAgIChzeW5vcHNpcyAiRmlsZSBtYW5hZ2VyIGFuZCBkZXNrdG9wIGljb24gbWFuYWdlciIp CiAgICAgKGRlc2NyaXB0aW9uICJQQ01hbkZNLVF0IGlzIHRoZSBRdCBwb3J0IG9mIFBDTWFu Rk0sIHRoZSBmaWxlIG1hbmFnZXIgb2YKLS0gCjIuMjMuMAoK --48349a3722b84745bbceaaae5d98c3e5--