From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60249)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dUZXi-0004hO-R6
	for guix-patches@gnu.org; Mon, 10 Jul 2017 10:20:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dUZXe-0001hJ-UE
	for guix-patches@gnu.org; Mon, 10 Jul 2017 10:20:06 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:58288)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1dUZXe-0001hB-PG
	for guix-patches@gnu.org; Mon, 10 Jul 2017 10:20:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dUZXe-00018Z-Js
	for guix-patches@gnu.org; Mon, 10 Jul 2017 10:20:02 -0400
Subject: bug#27307: [PATCH] gnu: unshield: Remove incorrect '"'.
Resent-To: guix-patches@gnu.org
Resent-Message-ID: <handler.27307.D27307.14996963434298.done@debbugs.gnu.org>
References: <20170610132351.25681-1-manolis837@gmail.com>
	<87shj7ltp6.fsf@fastmail.com>
From: Manolis Ragkousis <manolis837@gmail.com>
Message-ID: <f8a3638c-054c-e8f9-b5c2-c172599f3004@gmail.com>
Date: Mon, 10 Jul 2017 17:18:51 +0300
MIME-Version: 1.0
In-Reply-To: <87shj7ltp6.fsf@fastmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Marius Bakke <mbakke@fastmail.com>
Cc: 27307-done@debbugs.gnu.org

Hey Marius

On 06/10/2017 06:59 PM, Marius Bakke wrote:
> manolis837@gmail.com writes:
> 
>> * gnu/packages/compression.scm: Remove incorrect '"'.
> 
> Nit-pick: it should say "* gnu/packages/compression.scm (unshield): ..."
> 
> [...]
> 
>> -           (uri (string-append "https://www.dropbox.com/s/8r4b6752swe3nhu/\"
>> +           (uri (string-append "https://www.dropbox.com/s/8r4b6752swe3nhu/\
>>  unshield-avigomanager11b22.zip?dl=1"))
> 
> I guess you can also remove string-append here? Alternatively, quoting the
> next line and indenting it would look a little better IMO.

I went with your second suggestion, I liked it more as well :)
Pushed the updated patch to master.
> 
> Sorry for the review failure! :-)
> 

I should have been more careful :P Thank you for your time and help!

Manolis