unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Liliana Marie Prikler <liliana.prikler@gmail.com>
To: Vivien Kraus <vivien@planete-kraus.eu>, 66052@debbugs.gnu.org
Cc: rg@raghavgururajan.name, maxim.cournoyer@gmail.com
Subject: [bug#66052] [PATCH gnome-team 1/1] gnu: tracker: Update to 3.6.0.
Date: Sun, 17 Sep 2023 15:27:28 +0200	[thread overview]
Message-ID: <f81b5962314a785372f3cf9ac737cfbcdb69fd99.camel@gmail.com> (raw)
In-Reply-To: <62ce9b1e2e95d3b480e9d09cb85fe8823b54bf09.1694955548.git.vivien@planete-kraus.eu>

Am Sonntag, dem 17.09.2023 um 13:29 +0200 schrieb Vivien Kraus:
> * gnu/packages/gnome.scm (tracker): Update to 3.6.0.
> [#:phases]: On 32-bit systems, disable 2 failing tests.
Should be [#:phases]: Add ‘the-added-phase’ otherwise the ChangeLog
LGTM.
> ---
>  gnu/packages/gnome.scm | 20 ++++++++++++++++++--
>  1 file changed, 18 insertions(+), 2 deletions(-)
> 
> diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
> index 2077478ff2..29aa57133d 100644
> --- a/gnu/packages/gnome.scm
> +++ b/gnu/packages/gnome.scm
> @@ -9387,7 +9387,7 @@ (define-public gnome-autoar
>  (define-public tracker
>    (package
>      (name "tracker")
> -    (version "3.5.3")
> +    (version "3.6.0")
>      (source (origin
>                (method url-fetch)
>                (uri (string-append "mirror://gnome/sources/tracker/"
> @@ -9395,7 +9395,7 @@ (define-public tracker
>                                    "tracker-" version ".tar.xz"))
>                (sha256
>                 (base32
> -               
> "1vi878f95a2nlvqz46ph6f05hywjb2ni0znqavhdkrbvi6qchrhl"))))
> +               
> "1whdqidxmagsc35pmz9kcc5vs3bmvbkmnis7prnx3zxs37z2qnaj"))))
>      (build-system meson-build-system)
>      (arguments
>       (list
> @@ -9417,6 +9417,22 @@ (define-public tracker
>                (substitute* "utils/trackertestutils/__main__.py"
>                  (("/bin/bash")
>                   (search-input-file inputs "bin/bash")))))
> +          #$@(if (target-x86-32?)
> +                 ;; On 32-bit systems, the far away dates are
> incorrect, and
> +                 ;; the floats are not parsed exactly.
> +                 (list
> +                  #~(add-after 'unpack 'relax-float-equality-tests
> +                      (lambda _
> +                        (substitute* "tests/libtracker-
> sparql/tracker-statement-test.c"
> +                          (("g_assert_cmpfloat *\\((.*), ==, ([0-
> 9.e-]+)\\);" total actual expected)
> +                           (string-append
> "g_assert_cmpfloat_with_epsilon ("
> +                                          actual ", " expected ",
> 1e-12);")))))
> +                  #~(add-after 'unpack 'disable-datetime-test
> +                      (lambda _
> +                        (substitute* "tests/core/tracker-sparql-
> test.c"
> +                          (("\\{ \"datetime/direct-1\", .* \\},")
> +                           "/* datetime test disabled */")))))
> +                 '())
You can (and probably should) make this into a ‘disable-failing-tests’
or inline it into an existing one.  Otherwise LGTM but waiting for CI
to test.

Cheers

  reply	other threads:[~2023-09-17 13:28 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-17 12:59 [bug#66052] [PATCH gnome-team 0/1] Update tracker, and ignore i686 missing tests Vivien Kraus via Guix-patches via
2023-09-17 11:29 ` [bug#66052] [PATCH gnome-team 1/1] gnu: tracker: Update to 3.6.0 Vivien Kraus via Guix-patches via
2023-09-17 13:27   ` Liliana Marie Prikler [this message]
2023-09-17 11:29     ` [bug#66052] [PATCH gnome-team v2] " Vivien Kraus via Guix-patches via
2023-09-17 16:22       ` Liliana Marie Prikler
2023-09-17 11:29         ` [bug#66052] [PATCH gnome-team v3] " Vivien Kraus via Guix-patches via
2023-09-17 18:55           ` Liliana Marie Prikler
2023-09-17 11:29             ` [bug#66052] [PATCH gnome-team v4] " Vivien Kraus via Guix-patches via
2023-09-17 19:51               ` Liliana Marie Prikler
2023-09-17 11:29                 ` [bug#66052] [PATCH gnome-team v5] " Vivien Kraus via Guix-patches via
2023-09-18 17:00                   ` Liliana Marie Prikler
2023-09-24 10:01                     ` bug#66052: " Liliana Marie Prikler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f81b5962314a785372f3cf9ac737cfbcdb69fd99.camel@gmail.com \
    --to=liliana.prikler@gmail.com \
    --cc=66052@debbugs.gnu.org \
    --cc=maxim.cournoyer@gmail.com \
    --cc=rg@raghavgururajan.name \
    --cc=vivien@planete-kraus.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).