unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Liliana Marie Prikler <liliana.prikler@gmail.com>
To: Zongyuan Li <zongyuan.li@c0x0o.me>, 61680@debbugs.gnu.org
Subject: [bug#61680] [PATCH] gnu: podman: Add 'docker' alias script as 'docker' output
Date: Wed, 22 Feb 2023 06:19:05 +0100	[thread overview]
Message-ID: <f807e5a48baae089ce34f65a27a0d551f54898cf.camel@gmail.com> (raw)
In-Reply-To: <20230221143401.42099-1-zongyuan.li@c0x0o.me>

Am Dienstag, dem 21.02.2023 um 14:34 +0000 schrieb Zongyuan Li:
> * gnu/packages/containers.scm: New 'docker' output for podman
That ChangeLog looks somewhat incomplete.

> Signed-off-by: Zongyuan Li <zongyuan.li@c0x0o.me>
Signed-off-by is for committers signing off the commits.

> ---
>  gnu/packages/containers.scm | 157 +++++++++++++++++++---------------
> --
>  1 file changed, 83 insertions(+), 74 deletions(-)
> 
> diff --git a/gnu/packages/containers.scm
> b/gnu/packages/containers.scm
> index 272b67c38d..80c4aaa400 100644
> --- a/gnu/packages/containers.scm
> +++ b/gnu/packages/containers.scm
> @@ -312,83 +312,92 @@ (define-public podman
>    (package
>      (name "podman")
>      (version "4.3.1")
> -    (source
> -     (origin
> -       (method git-fetch)
> -       (uri (git-reference
> -             (url "https://github.com/containers/podman")
> -             (commit (string-append "v" version))))
> -       (modules '((guix build utils)))
> -       ;; FIXME: Btrfs libraries not detected by these scripts.
> -       (snippet '(substitute* "Makefile"
> -                   ((".*hack/btrfs.*") "")))
> -       (sha256
> -        (base32
> "05hv4xdf06n728lmsx793zygypc9i404bgcgpy0fyrg8c2s11q2h"))
> -       (file-name (git-file-name name version))))
> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url "https://github.com/containers/podman")
> +                    (commit (string-append "v" version))))
> +              (modules '((guix build utils)))
> +              ;; FIXME: Btrfs libraries not detected by these
> scripts.
> +              (snippet '(substitute* "Makefile"
> +                          ((".*hack/btrfs.*")
> +                           "")))
> +              (sha256
> +               (base32
> +               
> "05hv4xdf06n728lmsx793zygypc9i404bgcgpy0fyrg8c2s11q2h"))
> +              (file-name (git-file-name name version))))
Don't mix style changes with functional ones.  `guix style', while
recommended in the manual, often does more harm than good.

> +    (outputs '("out" "docker"))
Since this is a very non-standard output, perhaps try describing it
with a output-synopsis package property.

Cheers

  reply	other threads:[~2023-02-22  5:20 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-21 14:34 [bug#61680] [PATCH] gnu: podman: Add 'docker' alias script as 'docker' output Zongyuan Li via Guix-patches via
2023-02-22  5:19 ` Liliana Marie Prikler [this message]
2023-02-22  5:52   ` lWP6SrZsSwhCy5tUxadDfg via Guix-patches via
2023-02-22 19:23     ` Liliana Marie Prikler
2023-02-23  6:56 ` [bug#61680] [PATCH v2] " Zongyuan Li via Guix-patches via
2023-03-02 18:35   ` [bug#61680] [PATCH] " Ludovic Courtès
2023-03-03  6:30     ` Zongyuan Li via Guix-patches via
2023-03-03  8:08 ` [bug#61680] [PATCH v3] " Zongyuan Li via Guix-patches via
2023-03-24 10:29   ` Zongyuan Li via Guix-patches via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f807e5a48baae089ce34f65a27a0d551f54898cf.camel@gmail.com \
    --to=liliana.prikler@gmail.com \
    --cc=61680@debbugs.gnu.org \
    --cc=zongyuan.li@c0x0o.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).