From: John Kehayias via Guix-patches via <guix-patches@gnu.org>
To: Guillaume Le Vaillant <glv@posteo.net>
Cc: 51987@debbugs.gnu.org
Subject: [bug#51987] [PATCH] [core-updates-frozen] gnu: ledger: Remove failing test output.
Date: Sat, 20 Nov 2021 18:08:15 +0000 [thread overview]
Message-ID: <f6nBMBeLWxV8BA90ZdT42NLpOgLVbKcfozVlemi9jvFolsOQc_IHo_i5GwOKRibgQCiqvMMvL1IFmaqxk-zJnYVIr435fdNgWSxEL-z97YY=@protonmail.com> (raw)
In-Reply-To: <87k0h3xjnp.fsf@kitej>
[-- Attachment #1: Type: text/plain, Size: 577 bytes --]
Hello,
‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On Saturday, November 20th, 2021 at 4:19 AM, Guillaume Le Vaillant wrote:
> Instead of adding a patch removing the file, wouldn't it be simpler to just add a phase
> calling '(delete-file "test/...")'?
That's a very good point, much easier! I've attached v2 of the patch (commit message also had a typo before) where I used a snippet to remove the file. I haven't written a snippet before but seemed like a clean and explicit way to do the source modification here.
Hope that's better!
John
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-ledger-Remove-failing-test-output.patch --]
[-- Type: text/x-patch; name=0001-gnu-ledger-Remove-failing-test-output.patch, Size: 1711 bytes --]
From 49cfab2b6c52bd0be59f17f9bbcd669937beb2a6 Mon Sep 17 00:00:00 2001
From: John Kehayias <john.kehayias@protonmail.com>
Date: Sat, 20 Nov 2021 13:02:25 -0500
Subject: [PATCH V2] gnu: ledger: Remove failing test output.
* gnu/packages/finance.scm (ledger)[source]: Add snippet to remove a failing test.
---
gnu/packages/finance.scm | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/gnu/packages/finance.scm b/gnu/packages/finance.scm
index 354a2f2e0f..0c045b7bd3 100644
--- a/gnu/packages/finance.scm
+++ b/gnu/packages/finance.scm
@@ -25,6 +25,7 @@
;;; Copyright © 2021 ZmnSCPxj jxPCSnmZ <ZmnSCPxj@protonmail.com>
;;; Copyright © 2021 François J <francois-oss@avalenn.eu>
;;; Copyright © 2021 Foo Chuan Wei <chuanwei.foo@hotmail.com>
+;;; Copyright © 2021 John Kehayias <john.kehayias@protonmail.com>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -304,7 +305,14 @@ (define-public ledger
(commit (string-append "v" version))))
(file-name (git-file-name name version))
(sha256
- (base32 "0x6jxwss3wwzbzlwmnwb8yzjk8f9wfawif4f1b74z2qg6hc4r7f6"))))
+ (base32 "0x6jxwss3wwzbzlwmnwb8yzjk8f9wfawif4f1b74z2qg6hc4r7f6"))
+ (snippet '(begin
+ ;; Remove test that fails due to difference in
+ ;; reported error message (missing leading "./" in the
+ ;; file name); started some time after Guix commit
+ ;; 727f05e1e285aa52f5a19ec923fdc2259859b4b1
+ (delete-file "test/regress/BF3C1F82-2.test")
+ #true))))
(build-system cmake-build-system)
(arguments
`(#:modules (,@%cmake-build-system-modules
--
2.33.1
next prev parent reply other threads:[~2021-11-20 18:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-19 22:47 [bug#51987] [PATCH] [core-updates-frozen] gnu: ledger: Remove failing test output John Kehayias via Guix-patches via
2021-11-20 9:19 ` Guillaume Le Vaillant
2021-11-20 18:08 ` John Kehayias via Guix-patches via [this message]
2021-11-20 18:26 ` bug#51987: " Guillaume Le Vaillant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='f6nBMBeLWxV8BA90ZdT42NLpOgLVbKcfozVlemi9jvFolsOQc_IHo_i5GwOKRibgQCiqvMMvL1IFmaqxk-zJnYVIr435fdNgWSxEL-z97YY=@protonmail.com' \
--to=guix-patches@gnu.org \
--cc=51987@debbugs.gnu.org \
--cc=glv@posteo.net \
--cc=john.kehayias@protonmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).