From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:34949) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1igeOh-00044v-Dd for guix-patches@gnu.org; Sun, 15 Dec 2019 19:38:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1igeOg-0000W7-9o for guix-patches@gnu.org; Sun, 15 Dec 2019 19:38:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:59795) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1igeOg-0000W0-6H for guix-patches@gnu.org; Sun, 15 Dec 2019 19:38:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1igeOg-0003lu-2m for guix-patches@gnu.org; Sun, 15 Dec 2019 19:38:02 -0500 Subject: [bug#38554] [PATCH 4/5] Add python2-fastentrypoints Resent-Message-ID: Message-ID: From: Jesse Gibbons In-Reply-To: References: <660a10a1f02b4818a28dfea58b544956437d4b66.camel@gmail.com> <55a8d50ae479e0036d31ca9ca75aa3ff3796d48d.camel@gmail.com> Content-Type: text/plain; charset="UTF-8" Date: Sun, 15 Dec 2019 17:37:15 -0700 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: zimoun Cc: 38554@debbugs.gnu.org On Thu, 2019-12-12 at 18:18 +0100, zimoun wrote: > Hi Jesse, > > Thank you for your patches. > > As you have maybe seen, I have file a bug [1] to track the Python > packages and the end-of-file of Python 2. Here you add a new Python 2 > entry. My question is: do we absolutely need it? > > I have seen your bug report about the broken Hy REPL and this series > fixes it. My question is just: can we continue to add > `package-with-python2` packages? > > > All the best, > simon > > [1] https://debbugs.gnu.org/cgi/bugreport.cgi?bug=38420 This concern is why I added the python2 packages in separate patches contrary to tradition. I wanted to know what others thought of it. We don't necessarily need to add the python2 packages, especially when the repository says this will be the last version of hy to support python2 and those packages are only added to support hy in python2. I recommend you start a discussion with Brett, who reviewed the patches and told me to combine patch 1 with 4 and 2 with 5. I have too much going on to create and send updated patches before Tuesday, so I guess now is the time for such discussion.