unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Liliana Marie Prikler <liliana.prikler@gmail.com>
To: Suhail Singh <suhailsingh247@gmail.com>, 71592@debbugs.gnu.org
Cc: Katherine Cox-Buday <cox.katherine.e+guix@gmail.com>,
	Andrew Tropin <andrew@trop.in>
Subject: [bug#71592] [PATCH 2/3] gnu: emacs-org-super-agenda: Ignore failing tests.
Date: Sun, 16 Jun 2024 17:53:30 +0200	[thread overview]
Message-ID: <f5837de4defe180cca73a7c8e20e81f95ddba557.camel@gmail.com> (raw)
In-Reply-To: <11a2f4a62b32e2b5545a9e585cb870cf1182f728.1718548296.git.suhail@bayesians.ca>

Am Sonntag, dem 16.06.2024 um 11:30 -0400 schrieb Suhail Singh:
> 
> * gnu/packages/emacs-xyz.scm (emacs-org-super-agenda): Ignore tests
> that fail
> with emacs-org 9.7.4.
> 
> Change-Id: I06c3ec4a6b279b3cbf2efc392dc930b088f2b569
> ---
>  gnu/packages/emacs-xyz.scm | 12 ++++++++++--
>  1 file changed, 10 insertions(+), 2 deletions(-)
> 
> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
> index 9a57a0fbf7..cf0488d5c7 100644
> --- a/gnu/packages/emacs-xyz.scm
> +++ b/gnu/packages/emacs-xyz.scm
> @@ -23608,8 +23608,16 @@ (define-public emacs-org-super-agenda
>                   (string-append (getcwd) "/test/results.el")))
>                ;; The following tests fail.
>                (substitute* "test/test.el"
> -                ((".* org-super-agenda-test--with-retained-sorting
> .*" all)
> -                 (string-append all "  (skip-unless nil)\n"))))))))
> +                  ((".* org-super-agenda-test--auto-parent .*" all)
> +                   (string-append all "  (skip-unless nil)\n"))
> +                  ;; some tests are using an obsolete variable
> +                  (("\\(org-super-agenda-retain-sorting ")
> +                   "(org-super-agenda-keep-order ")
> +                  ;; however, they still fail ...
> +                  ((".* org-super-agenda-test--with-retained-sorting
> .*" all)
> +                   (string-append all "  (skip-unless nil)\n"))
> +                  ((".* org-super-agenda-test--without-retained-
> sorting .*" all)
> +                   (string-append all "  (skip-unless
> nil)\n"))))))))
I think a comment here noting the incompatibility would be nice.
Perhaps marked as a TODO, so that updaters know to remove it.

Cheers


  reply	other threads:[~2024-06-16 15:55 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-16 14:36 [bug#71592] [PATCH 0/3] gnu: emacs-org: Update to 9.7.4 Suhail Singh
2024-06-16 15:29 ` [bug#71592] [PATCH 1/3] " Suhail Singh
2024-06-16 15:30 ` [bug#71592] [PATCH 2/3] gnu: emacs-org-super-agenda: Ignore failing tests Suhail Singh
2024-06-16 15:53   ` Liliana Marie Prikler [this message]
2024-06-16 15:31 ` [bug#71592] [PATCH 3/3] gnu: emacs-compat: Build from git Suhail Singh
2024-06-16 15:55   ` Liliana Marie Prikler
2024-06-17 11:59 ` [bug#71592] [PATCH v2 0/4] gnu: emacs-org: Update to 9.7.4 Suhail Singh
2024-06-17 12:00   ` [bug#71592] [PATCH v2 1/4] " Suhail Singh
2024-06-17 12:01   ` [bug#71592] [PATCH v2 2/4] gnu: emacs-org-super-agenda: Ignore failing tests Suhail Singh
2024-06-17 12:02   ` [bug#71592] [PATCH v2 3/4] gnu: emacs-compat: Update the home-page Suhail Singh
2024-06-17 12:03   ` [bug#71592] [PATCH v2 4/4] gnu: emacs-compat: Update source to use git reference Suhail Singh
2024-06-19  7:54   ` bug#71592: [PATCH v2 0/4] gnu: emacs-org: Update to 9.7.4 Nicolas Goaziou via Guix-patches via
2024-06-22 21:39 ` [bug#71592] [PATCH 0/3] " Adam Porter
2024-06-23  5:27   ` Suhail Singh
2024-06-27 13:40     ` Adam Porter
2024-06-28  0:04       ` Suhail Singh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f5837de4defe180cca73a7c8e20e81f95ddba557.camel@gmail.com \
    --to=liliana.prikler@gmail.com \
    --cc=71592@debbugs.gnu.org \
    --cc=andrew@trop.in \
    --cc=cox.katherine.e+guix@gmail.com \
    --cc=suhailsingh247@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).