From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id mBaqOL6m+l7CNwAA0tVLHw (envelope-from ) for ; Tue, 30 Jun 2020 02:43:10 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id 6oVHNL6m+l52egAAbx9fmQ (envelope-from ) for ; Tue, 30 Jun 2020 02:43:10 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2BE6B940602 for ; Tue, 30 Jun 2020 02:43:10 +0000 (UTC) Received: from localhost ([::1]:59296 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jq6El-0001yv-O1 for larch@yhetil.org; Mon, 29 Jun 2020 22:43:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55682) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jq6Eg-0001yn-Dv for guix-patches@gnu.org; Mon, 29 Jun 2020 22:43:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:38349) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jq6Eg-0001Gr-4H for guix-patches@gnu.org; Mon, 29 Jun 2020 22:43:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jq6Eg-000074-1h for guix-patches@gnu.org; Mon, 29 Jun 2020 22:43:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#42067] [PATCH] gnu: darktable: Add optional dependencies. Resent-From: Vinicius Monego Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 30 Jun 2020 02:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42067 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 42067-done@debbugs.gnu.org Received: via spool by 42067-done@debbugs.gnu.org id=D42067.1593484943381 (code D ref 42067); Tue, 30 Jun 2020 02:43:02 +0000 Received: (at 42067-done) by debbugs.gnu.org; 30 Jun 2020 02:42:23 +0000 Received: from localhost ([127.0.0.1]:49895 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jq6E3-000065-A8 for submit@debbugs.gnu.org; Mon, 29 Jun 2020 22:42:23 -0400 Received: from mout02.posteo.de ([185.67.36.66]:59437) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jq6Dz-00005q-Qf for 42067-done@debbugs.gnu.org; Mon, 29 Jun 2020 22:42:21 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id 26ECD2400FB for <42067-done@debbugs.gnu.org>; Tue, 30 Jun 2020 04:42:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1593484933; bh=zwpnwlzig+4pgo82Y8GkOezLrIdXW0o8+AaavvTeopE=; h=Subject:From:To:Cc:Date:From; b=F5WrCGBOu6/IoBzS73YpYgL9QPk1YRbhUQCxVqJeV/eJ8wPTfJb20insgbu0wLQ+F h3E2oiNBNpjeuyGWy/uZGL75JalclcQk1EwZW1C9M8rmBZRgm4IvB/xOkPNPUow4F+ 9OPxXnKuGExFDosTjLJEy2G788nDFoeszebp1wPWPmI3uAF9Wv61dniic+QY/ZTVTS 7SqNSum0B3Yq9O8FRV28ohw4dPRgC1V8i7fdcQMaGkrPz0PQti/+aYeqlwGd0RiMKC txB5jCsn/8Aykkdhsmg2254HJ18SZG5hfPo1Y3kjYN1z2DuwfIJpDdWPxWJKAhhADF rVdIWjmsXAZUA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 49wpXy6f4Rz9rxL; Tue, 30 Jun 2020 04:42:10 +0200 (CEST) Message-ID: From: Vinicius Monego Date: Mon, 29 Jun 2020 23:42:06 -0300 In-Reply-To: <87eepxa5zu.fsf@gnu.org> References: <20200626203904.16748-1-monego@posteo.net> <87eepxa5zu.fsf@gnu.org> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=fail (rsa verify failed) header.d=posteo.net header.s=2017 header.b=F5WrCGBO; dmarc=fail reason="SPF not aligned (strict)" header.from=posteo.net (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: 0.09 X-TUID: pxGRwa0PmTl6 Hello Ludo, > > BTW, why are we building with Clang? > This was briefly discussed in the version update thread (2020- 06/msg00651). To be more descriptive: DT 3+ requires GCC/Clang 8+ and will fail to build with the default GCC 7.5.0. We have to load a newer version of GCC, or use Clang. Marius attempted to build it with gcc-9 and "ran into other problems" although I have succesfully built DT3 with the same compiler and version a while ago. Meanwhile, DT's CMakeLists.txt checks for LLVM to enable "test- compilation of OpenCL programs". If LLVM is not found, this test- compilation is skipped. If LLVM is found, it checks for Clang, and the required opencl header is located inside Clang's directory. Because we "have to have" Clang this way, it made more sense to me to compile with it. Anyways, OpenCL is optional. To build with GCC only, we would have to load the gcc module and skip the test-compilation. It may be possible to use both gcc and clang, but that would add redundancy.