unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Sarah Morgensen <iskarian@mgsn.dev>
To: 49729@debbugs.gnu.org
Subject: [bug#49729] [PATCH core-updates] build-system/gnu: Make gzip files writable before resetting timestamps.
Date: Sat, 24 Jul 2021 23:12:04 -0700	[thread overview]
Message-ID: <f45aa05904dcb0cb8718be3d32d9bae9807ed8c0.1627193346.git.iskarian@mgsn.dev> (raw)

guix/build/gnu-build-system.scm (reset-gzip-timestamps): Ensure gzip
files are writable before resetting their timestamps.
---
Hello Guix,

There have been a number of instances of packages having to add their own phase
before 'reset-gzip-timestamps to make the gzip files writable--perhaps the gnu
build system can take care of this itself? WDYT?

--
Sarah
 guix/build/gnu-build-system.scm | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/guix/build/gnu-build-system.scm b/guix/build/gnu-build-system.scm
index d0f7413268..d84411c090 100644
--- a/guix/build/gnu-build-system.scm
+++ b/guix/build/gnu-build-system.scm
@@ -598,6 +598,8 @@ and 'man/'.  This phase moves directories to the right place if needed."
                                         (string-suffix? ".tgz" file))
                                     (gzip-file? file)))
                              #:stat lstat)))
+      ;; Ensure the files are writable.
+      (for-each make-file-writable files)
       (for-each reset-gzip-timestamp files)))
 
   (match outputs

base-commit: 7bef3be1d318beebaf48ac6daa3140205ba18e98
-- 
2.31.1





             reply	other threads:[~2021-07-25  6:13 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-25  6:12 Sarah Morgensen [this message]
2021-07-25 15:26 ` [bug#49729] [PATCH core-updates] build-system/gnu: Make gzip files writable before resetting timestamps Maxime Devos
2021-07-25 20:45   ` Sarah Morgensen
2021-07-26 20:49     ` Maxime Devos
2021-07-28  1:21       ` Sarah Morgensen
2021-07-27  2:16 ` [bug#49729] [PATCH core-updates 00/20] Remove obsolete phases making gzip files writable Sarah Morgensen
2021-07-27  2:56   ` [bug#49729] [PATCH core-updates 01/20] gnu: python-biom-format: Remove obsolete phase Sarah Morgensen
2021-07-27  2:56   ` [bug#49729] [PATCH core-updates 02/20] gnu: clipper: " Sarah Morgensen
2021-07-27  2:56   ` [bug#49729] [PATCH core-updates 03/20] gnu: khmer: " Sarah Morgensen
2021-07-27  2:56   ` [bug#49729] [PATCH core-updates 04/20] gnu: cups-minimal: " Sarah Morgensen
2021-07-27  2:56   ` [bug#49729] [PATCH core-updates 05/20] gnu: emacs: " Sarah Morgensen
2021-07-27  2:56   ` [bug#49729] [PATCH core-updates 06/20] gnu: po4a: " Sarah Morgensen
2021-07-27  2:56   ` [bug#49729] [PATCH core-updates 07/20] gnu: go-golang-org-x-crypto: " Sarah Morgensen
2021-07-27  2:56   ` [bug#49729] [PATCH core-updates 08/20] gnu: go-github-com-docker-distribution: " Sarah Morgensen
2021-07-27  2:56   ` [bug#49729] [PATCH core-updates 09/20] gnu: go-github-com-gdamore-tcell: " Sarah Morgensen
2021-07-27  2:56   ` [bug#49729] [PATCH core-updates 10/20] gnu: python-plotly: " Sarah Morgensen
2021-07-27  2:56   ` [bug#49729] [PATCH core-updates 11/20] gnu: go-ipfs: " Sarah Morgensen
2021-07-27  2:56   ` [bug#49729] [PATCH core-updates 12/20] gnu: python-scikit-learn: " Sarah Morgensen
2021-07-27  2:56   ` [bug#49729] [PATCH core-updates 13/20] gnu: jalv-select: " Sarah Morgensen
2021-07-27  2:56   ` [bug#49729] [PATCH core-updates 14/20] gnu: lmms: " Sarah Morgensen
2021-07-27  2:56   ` [bug#49729] [PATCH core-updates 15/20] gnu: helm: " Sarah Morgensen
2021-07-27  2:56   ` [bug#49729] [PATCH core-updates 16/20] gnu: arcanist: " Sarah Morgensen
2021-07-27  2:56   ` [bug#49729] [PATCH core-updates 17/20] gnu: python-pdfminer-six: " Sarah Morgensen
2021-07-27  2:56   ` [bug#49729] [PATCH core-updates 18/20] gnu: go-github-com-prometheus-common: " Sarah Morgensen
2021-07-27  2:56   ` [bug#49729] [PATCH core-updates 19/20] gnu: pre-commit: " Sarah Morgensen
2021-07-27 19:26   ` [bug#49729] [PATCH core-updates 20/20] gnu: cpuid: Remove obsolete file permissions change Sarah Morgensen
2021-10-26 13:14 ` [bug#49729] (No Subject) Attila Lendvai
2021-12-24  5:51   ` [bug#49729] [PATCH core-updates] build-system/gnu: Make gzip files writable before resetting timestamps Maxim Cournoyer
2022-01-17 17:09     ` Maxim Cournoyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f45aa05904dcb0cb8718be3d32d9bae9807ed8c0.1627193346.git.iskarian@mgsn.dev \
    --to=iskarian@mgsn.dev \
    --cc=49729@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).