From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id uCjrGrEkOGLHcQAAgWs5BA (envelope-from ) for ; Mon, 21 Mar 2022 08:09:37 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id 4FNtE7EkOGIzKgAAG6o9tA (envelope-from ) for ; Mon, 21 Mar 2022 08:09:37 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id BB8684138 for ; Mon, 21 Mar 2022 08:09:36 +0100 (CET) Received: from localhost ([::1]:35340 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nWCAZ-0002iD-Eg for larch@yhetil.org; Mon, 21 Mar 2022 03:09:35 -0400 Received: from eggs.gnu.org ([209.51.188.92]:52042) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nWC1K-0005Is-Hl for guix-patches@gnu.org; Mon, 21 Mar 2022 03:00:05 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:41808) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nWC1K-000821-6D for guix-patches@gnu.org; Mon, 21 Mar 2022 03:00:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nWC1K-0005Lj-23 for guix-patches@gnu.org; Mon, 21 Mar 2022 03:00:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#54476] [PATCH] gnu: games: Add robotfindskitten. Resent-From: Liliana Marie Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 21 Mar 2022 07:00:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54476 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Roman Riabenko , 54476@debbugs.gnu.org Received: via spool by 54476-submit@debbugs.gnu.org id=B54476.164784599520526 (code B ref 54476); Mon, 21 Mar 2022 07:00:01 +0000 Received: (at 54476) by debbugs.gnu.org; 21 Mar 2022 06:59:55 +0000 Received: from localhost ([127.0.0.1]:35705 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nWC1C-0005Kz-Mh for submit@debbugs.gnu.org; Mon, 21 Mar 2022 02:59:54 -0400 Received: from mail-ed1-f68.google.com ([209.85.208.68]:35651) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nWC1B-0005Kn-7Z for 54476@debbugs.gnu.org; Mon, 21 Mar 2022 02:59:53 -0400 Received: by mail-ed1-f68.google.com with SMTP id k10so2949188edj.2 for <54476@debbugs.gnu.org>; Sun, 20 Mar 2022 23:59:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:subject:from:to:date:in-reply-to:references:user-agent :mime-version:content-transfer-encoding; bh=hTk6+jl5flvZ/kaj3SZr3Osgua9L1II/uVNL+vh9Buc=; b=J0PF5INM9beKET3GJklWQs4GEk4JMFFUPSm2IpOyZE9RfWRRTP1jziH2V2aRsNnIXy fsJtkXoUM1uKN34jxR/OtBbhSdtl+e2874Aow5IcQ+5VnlrrCJf6kksm4XTxXgxEjgxU gvIJYYbMbu1Owfu3UYeIc66H7IdhTJWIddCw8D7RFyZj/1FVWMqL561xfoDc40gjVk3g aBMnD/wQRyyur5+JaWC/L8KM5ap0viFexz02epzjPiM3WB4GTwJVx7dIXK5XZDW5/wVm bljb0bnoyqo4z/UJ3eHUnuooVqLnDjhH7NFNTqQ4s18+IYekszbOy1Lgzmw7jMymnfT9 Oy7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=hTk6+jl5flvZ/kaj3SZr3Osgua9L1II/uVNL+vh9Buc=; b=xIS8uhME6XdEC4wGk/KfuQsDDfejTst1VqOutKjporO8Q1Nug9PVpcz5KyPLPkjJKQ DApOlSR+Fx/s3nPqZxEroNta8JAzi1XWtfCaBEyCx5nnXm6bhm7pSnFZpWRNRpR5NNjR 9qfcWr51sSFhKi8Jzlckt+JJ7f5bWZdqEYgOmKqfw/uWXfpJ9kNpwpw9o8sYqZSFRvel ZqtEpT0rQIJd47cY0/Ph0zAPVUF3URpk0eXnXRfUfslNWoiI7AImJIsUrJJlCHLhsMcw EzTIhibegBJND+G9IUzLSyzxvvqgSr9f0xsTP3i2INcJsaGFqXbkkIqamtaaHtfIlGfk nmag== X-Gm-Message-State: AOAM532E2cJZu5dED6PNER9TuDYIdQHqYhwumrgVi3JPyCCLLPMWg+qD IDPTuPdP9est7ce/Ns4bzDg= X-Google-Smtp-Source: ABdhPJz5I9LK5lZiLpDNLhq2CAc53/j5okv981XvHFmxa0sQtWV3dbbL8mltnK3PzyQj+/dK5RMW6w== X-Received: by 2002:aa7:da81:0:b0:419:11e8:1039 with SMTP id q1-20020aa7da81000000b0041911e81039mr13711076eds.285.1647845987142; Sun, 20 Mar 2022 23:59:47 -0700 (PDT) Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id y14-20020a056402440e00b00416046b623csm7882383eda.2.2022.03.20.23.59.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 20 Mar 2022 23:59:46 -0700 (PDT) Message-ID: From: Liliana Marie Prikler Date: Mon, 21 Mar 2022 07:59:45 +0100 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1647846577; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=hTk6+jl5flvZ/kaj3SZr3Osgua9L1II/uVNL+vh9Buc=; b=OQH8odOkWtlBWFGnM2p5mT4Y+wXX0dmcOsq4kXFzIXhlaMIV8iOICoM7nrvAQ3Jjp/6DLU mJO1ZwjmO+1lUkuYv/E0+y2bZNXu/HAAoh7g1LW7e7fM4b+YrqRrCyX8hJpMm99CusbJoq FqEf2nT+CcknLArJKqqjjzF779BKAoQQYwI4LNdx0DlcSIu0Dq3wdhO5RsdhUVDQ3SbobA pwyRSQwMUC2BYEkCGE2tHWwe/P2BGuir/2z6pjNo2SHH/JYmeQ1aGWYwiFbtMwG6cp5eVR hVuaXV286tRjL/IW7O9aIx9cr2ZUoHATARbbVlwMFzTKkWRLvD9w3WHDxLokfQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1647846577; a=rsa-sha256; cv=none; b=bCr4EpaD77gO1yGjCXNR3TwtwKZogfkaMyb3xU/ohZgfw2dLNYN2iF2OCcpg7dIp45nfpq YYBT8Hyu37eqNT/Gz1mkQDaBXnWE/BBJu7xLAisJIs6ZZTE9QSXj64gKbEew8KCI3ru04G 1o1RiCy8OoEHGAKUHi9rfRwAw1k8bouJDK9fpBuZTf5HUhO1pB+0mTfo5MniDAPA54bY0U nwHNXYAfrX0+iCTz89JMVG7drQGJYio9M7oR5kraKMMBa37wTLIXo/FtjIzV5rCUEcMqft 7bk3m8/Ml3ea1wvrEpWbKiRgPDwTV1JSWiXf7x0WfKCmltH1YZKH5GJJGUZtyQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=J0PF5INM; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 5.88 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=J0PF5INM; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: BB8684138 X-Spam-Score: 5.88 X-Migadu-Scanner: scn1.migadu.com X-TUID: snILHYRIs12x Hi Roman, Am Sonntag, dem 20.03.2022 um 16:28 +0200 schrieb Roman Riabenko: > + ;; Despite what guix lint says, version 2.8284271.702 is newer > then > + ;; 1600003_201b. See ChangeLog for version history. > + (version "2.8284271.702") > + ;; The git version is the same as in the release tarball, but it > bundles > + ;; convenient .desktop files, which were requested for Debian. > + (source (origin > + (method git-fetch) > + (uri (git-reference > + (url > + > "https://github.com/robotfindskitten/robotfindskitten") > + (commit > "1cae36621f9c19d19a40eacf63789913d4ef5d5c"))) > + (file-name (git-file-name name version)) > + (sha256 > + (base32 > + > "0ps3xrl1yh0h7jhl3bwhx5xw2hvhzync03y08i66rzw098r530qq")))) Looking at the git repository, those are *not* the same. Use git- version or use the tag as commit, but don't mix conventions. > + (replace 'bootstrap > + (lambda _ > + (invoke "autoreconf" "-ifv"))) ;per README.md The existing bootstrap should already correctly invoke autoreconf if no bootstrap script exists. > + (add-after 'unpack 'fix-install-path > + (lambda _ > + ;; It is configured to install executable to > /games or > + ;; /usr/local/games per Filesystem Hierarchy > Standard. > + ;; We change that to get it in $PATH. > + (substitute* "src/Makefile.am" > + (("\\$\\(prefix\\)/games") "$(prefix)/bin")) We could change this by using #:make-flags instead, I believe. > + ;; When built with guix, all characters are > displayed in > + ;; the background colour pair. If it is not > set manually, > + ;; this is not happening, so we get back > colour into the > + ;; game. The background is redrawn anyway. See > man bkgd. > + (substitute* "src/robotfindskitten.c" > + (("\\(void\\) bkgd \\( \\(chtype\\) > COLOR_PAIR\\(WHITE\\) \\);") > + ""))))) This should probably go into a "patch-source" phase. > + (synopsis "Zen Simulation of robot finding kitten") > + (description > + "In this simulation, you play the part of robot. Your task is > to > +complete the simulation by finding kitten, as is your destiny, and > indeed your > +wont. You (robot) are represented by the # character, and you move > around with > +the arrow keys touching things. If the thing you touch is kitten, > you get a > +cute little animation (which was cuter in the DOS version) and the > simulation > +ends. Otherwise, you get a brief description of what it is you > touched.") Both synopsis and description could use some love. Plain copypasta with grammatical errors is not good optics. Cheers