From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34292) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dxAxf-0000xy-M0 for guix-patches@gnu.org; Wed, 27 Sep 2017 07:57:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dxAxa-0007OJ-Qw for guix-patches@gnu.org; Wed, 27 Sep 2017 07:57:07 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:53823) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dxAxa-0007O8-NJ for guix-patches@gnu.org; Wed, 27 Sep 2017 07:57:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dxAxa-0002CZ-BD for guix-patches@gnu.org; Wed, 27 Sep 2017 07:57:02 -0400 Subject: [bug#28583] [PATCH 1/7] gnu: Add ruby-httpclient. Resent-Message-ID: References: <20170924181052.0219647c@cbaines.net> <20170924171717.3855-1-mail@cbaines.net> From: Ben Woodcroft Message-ID: Date: Wed, 27 Sep 2017 21:56:04 +1000 MIME-Version: 1.0 In-Reply-To: <20170924171717.3855-1-mail@cbaines.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Christopher Baines , 28583@debbugs.gnu.org Hi, Thanks for the patches. On 25/09/17 03:17, Christopher Baines wrote: > * gnu/packages/ruby.scm (ruby-httpclient): New variable. > --- > gnu/packages/ruby.scm | 51 +++++++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 51 insertions(+) > > diff --git a/gnu/packages/ruby.scm b/gnu/packages/ruby.scm > index 80d3bffd8..ff6be875f 100644 > --- a/gnu/packages/ruby.scm > +++ b/gnu/packages/ruby.scm > @@ -3579,6 +3579,57 @@ It has built-in support for the legacy @code{cookies.txt} and > (home-page "https://github.com/sparklemotion/http-cookie") > (license license:expat))) > > +(define-public ruby-httpclient > + (package > + (name "ruby-httpclient") > + (version "2.8.3") > + (source > + (origin > + (method url-fetch) > + (uri (rubygems-uri "httpclient" version)) > + (sha256 > + (base32 > + "19mxmvghp7ki3klsxwrlwr431li7hm1lczhhj8z4qihl2acy8l99")))) > + (build-system ruby-build-system) > + (arguments > + '(;; TODO: Some tests currently fail > + ;; ------ > + ;; 211 tests, 729 assertions, 13 failures, 4 errors, 0 pendings, > + ;; 2 omissions, 0 notifications > + ;; 91.866% passed > + ;; ------ > + ;; 6.49 tests/s, 22.41 assertions/s > + #:tests? #f > + #:phases > + (modify-phases %standard-phases > + (replace 'check > + (lambda* (#:key tests? #:allow-other-keys) > + (if tests? > + (zero? > + (system* "ruby" > + "-Ilib" > + "test/runner.rb")) > + #t))) Since tests? is #f, this is effectively dead code. But it could be useful to someone continuing the tests, I'm not fussed. > + (add-after 'install 'wrap-bin-httpclient > + (lambda* (#:key outputs #:allow-other-keys) > + (wrap-program (string-append (assoc-ref outputs "out") > + "/bin/httpclient") > + `("GEM_HOME" ":" prefix (,(getenv "GEM_HOME")))) > + #t))))) It would be preferable to move this to be part of the ruby-build-system as is done in e.g. python-build-system, but OK. Otherwise LGTM. ben