From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44751)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gVXVz-0000VL-Af
	for guix-patches@gnu.org; Sat, 08 Dec 2018 02:59:08 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gVXVu-0006yt-MY
	for guix-patches@gnu.org; Sat, 08 Dec 2018 02:59:07 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:33276)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1gVXVu-0006yf-Ih
	for guix-patches@gnu.org; Sat, 08 Dec 2018 02:59:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gVXVu-0001U3-Dh
	for guix-patches@gnu.org; Sat, 08 Dec 2018 02:59:02 -0500
Subject: [bug#33575] [PATCH] guix: lint: Add checker to check if inputs are
	sorted.
Resent-Message-ID: <handler.33575.B33575.15442559275681@debbugs.gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Date: Fri, 07 Dec 2018 23:58:43 -0800
From: swedebugia@riseup.net
In-Reply-To: <87sgz8ekvk.fsf@member.fsf.org>
References: <20181202074210.31361-1-arunisaac@systemreboot.net>
	<87sgz8ekvk.fsf@member.fsf.org>
Message-ID: <f2b8429f1eaf8611fcb148c055733e04@riseup.net>
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: iyzsong@member.fsf.org
Cc: 33575@debbugs.gnu.org, Guix-patches <guix-patches-bounces+swedebugia=riseup.net@gnu.org>

On 2018-12-08 04:51, iyzsong@member.fsf.org wrote:
> Arun Isaac <arunisaac@systemreboot.net> writes:
> 
>> * guix/scripts/lint.scm (check-inputs-should-be-sorted): New procedure.
>> (%checkers): Add it.
>> [...]
>>
>> +(define (check-inputs-should-be-sorted package)
>> +  ;; Emit a warning if inputs, native inputs or propagated inputs of PACKAGE
>> +  ;; are not lexicographically ordered.
> 
> Hello, consider 'gspell', it has some native-inputs for build and some
> for test:
> 
>     (native-inputs
>      `(("glib" ,glib "bin")
>        ("pkg-config" ,pkg-config)
>        ("xmllint" ,libxml2)
> 
>        ;; For tests.
>        ("aspell-dict-en" ,aspell-dict-en)
>        ("xorg-server" ,xorg-server)))
> 
> Currently I'd seperated them by a comment like this.
> 
> If they are sorted, I have to add comment for each test input:
> 
>   `(("aspell-dict-en", aspecll-dict-en) ; for test
>     ("glib" ,glib "bin")
>     ("pkg-config" ,pkg-config)
>     ("xmllint" ,libxml2)
>     ("xorg-server" ,xorg-server))       ; for test
> 
> Which will be a little annoying...

You convinced me sorting is a bad idea. Thanks for providing a good
argument :)

-- 
Cheers 
Swedebugia