From: Martin Becze <mjbecze@riseup.net>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: 39931@debbugs.gnu.org
Subject: [bug#39931] [PATCH] gnu: Added emacs-org-journal
Date: Sat, 7 Mar 2020 13:23:41 -0500 [thread overview]
Message-ID: <f0faad1c-7fdb-7e62-f2ac-d47db70a901d@riseup.net> (raw)
In-Reply-To: <8283ce01-fb0a-9591-f8bd-3cf36e8c4332@riseup.net>
[-- Attachment #1: Type: text/plain, Size: 2527 bytes --]
opps i messed that the last patch file. Here is the correct one!
On 3/6/20 11:05 AM, Martin Becze wrote:
> Thanks for the review Nicolas!
>
> Attached is an updated patch.
>
> On 3/5/20 3:18 PM, Nicolas Goaziou wrote:
>> Hello,
>>
>> Martin Becze <mjbecze@riseup.net> writes:
>>
>>> * gnu/packages/emacs-xyz.scm (emacs-org-journal): New Variable.
>>
>> Thank you!
>>
>>> +(define-public emacs-org-journal
>>> + (package
>>> + (name "emacs-org-journal")
>>> + (version "2.0.0")
>>> + (home-page "https://github.com/bastibe/org-journal")
>>
>> Usually, `home-page' is lower in the package definition, right above
>> `synopsis'.
>>
>>> + (source
>>> + (origin
>>> + (method git-fetch)
>>> + (uri (git-reference
>>> + (url home-page)
>>
>> It may be just me, but I'm not a big fan of this trick, because it binds
>> two information that might be unrelated at some point. I suggest to use
>> the full URL instead.
>>
>> OTOH, the above is not a strong argument either, so it's up to you.
>>
>>> + (commit version)))
>>> + (file-name (git-file-name name version))
>>> + (sha256
>>> + (base32
>>> + "18dqd0jy2x530lk0h4fcn9cld9qh4w7b3vxa60fpiia628vsv1dg"))))
>>> + (build-system emacs-build-system)
>>> + (synopsis "A simple org-mode based journaling mode")
>>
>> I suggest "Simple Org mode based journaling mode". In any case, I think
>> "guix lint" complains when a synopsis starts with an article.
>>
>>> + (description "@code{org-journal} maintains a set of files,
>>> depending on the value
>>> + of @{org-journal-file-type}, a file represents a day, week, month
>>> or year. When
>>> +@code{org-journal-file-type} is set to =’daily=, each file represent
>>> a day. In case
>>> +@{org-journal-file-type} is set to =’weekly=, a file represents
>>> a week, etc.
>>
>> "Org Journal maintains a set of files, which may represent a day,
>> a week, a month or a year."
>>
>> IOW, I think description should not leak the innards of the package.
>>
>>> + Convenient bindings allow the creation of journal records in the
>>> current daily,
>>> + weekly, monthly or yearly file and search within all records or
>>> specified time
>>> + intervals. All records can be browsed and searched from the Emacs
>>> Calendar for
>>> + convenience.")
>>
>> You need to add two spaces after full stops.
>>
>> Could you send an updated patch?
>>
>> Regards,
>>
[-- Attachment #2: v3-0001-gnu-Added-emacs-org-journal.patch --]
[-- Type: text/x-patch, Size: 2244 bytes --]
From b9f584ae41d70209feb230d281df420e0e30c239 Mon Sep 17 00:00:00 2001
From: Martin Becze <mjbecze@riseup.net>
Date: Thu, 5 Mar 2020 12:40:42 -0500
Subject: [PATCH v3] gnu: Added emacs-org-journal
* gnu/packages/emacs-xyz.scm (emacs-org-journal): New Variable.
---
gnu/packages/emacs-xyz.scm | 27 +++++++++++++++++++++++++++
1 file changed, 27 insertions(+)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 19c4ed7571..2cc7d3a485 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -60,6 +60,7 @@
;;; Copyright © 2020 Paul Garlick <pgarlick@tourbillion-technology.com>
;;; Copyright © 2020 Robert Smith <robertsmith@posteo.net>
;;; Copyright © 2020 Evan Straw <evan.straw99@gmail.com>
+;;; Copyright © 2020 Martin Becze <mjbecze@riseup.net>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -21732,3 +21733,29 @@ supports generation of phonetic and numeric passwords.")
Separated Value) files. It follows the format as defined in RFC 4180 \"Common
Format and MIME Type for CSV Files\" (@url{http://tools.ietf.org/html/rfc4180}).")
(license license:gpl3+)))
+
+(define-public emacs-org-journal
+ (package
+ (name "emacs-org-journal")
+ (version "2.0.0")
+ (source
+ (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/bastibe/org-journal.git")
+ (commit version)))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32
+ "18dqd0jy2x530lk0h4fcn9cld9qh4w7b3vxa60fpiia628vsv1dg"))))
+ (build-system emacs-build-system)
+ (home-page "https://github.com/bastibe/org-journal")
+ (synopsis "Simple org-mode journaling mode")
+ (description "Adapted from @url{https://www.emacswiki.org/emacs/PersonalDiary}
+Functions to maintain a simple personal diary / journal using in Emacs.
+Convenient bindings allow the creation of journal records in the current daily,
+weekly, monthly or yearly file and search within all records or specified time
+intervals. All records can be browsed and searched from the Emacs Calendar for
+convenience. All entries in a specified TODO state will be carried over to the
+next day.")
+ (license license:bsd-3)))
--
2.25.1
next prev parent reply other threads:[~2020-03-07 18:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-05 17:47 [bug#39931] [PATCH] gnu: Added emacs-org-journal Martin Becze
2020-03-05 20:18 ` Nicolas Goaziou
2020-03-06 16:05 ` Martin Becze
2020-03-07 18:23 ` Martin Becze [this message]
2020-03-08 10:24 ` bug#39931: " Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f0faad1c-7fdb-7e62-f2ac-d47db70a901d@riseup.net \
--to=mjbecze@riseup.net \
--cc=39931@debbugs.gnu.org \
--cc=mail@nicolasgoaziou.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).