From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id kLFpHXUKUGfhrwAAe85BDQ:P1 (envelope-from ) for ; Wed, 04 Dec 2024 07:53:25 +0000 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id kLFpHXUKUGfhrwAAe85BDQ (envelope-from ) for ; Wed, 04 Dec 2024 08:53:25 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=JQTK40LP; dkim=fail ("headers rsa verify failed") header.d=fsfe.org header.s=2021081301 header.b=H3NmfW3q; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=fsfe.org (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1733298805; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=bKDPhHqk8nPzjZP19Fb9zRoYLrnOK1ZLqDZPDrRQlwA=; b=u2NS3AxNE+ISx6jD3UhvBFB8gioyLNZlGTkA2PmuzpiqmjjpLwYJOjEB9glJ1A/Ap8IkSa 4Fj37lTfmDU4gdp1pOFCntJiktolxTi5d0win9AwbabSRQG7ZMRDwcC5HB64Gb5y01vXas 04OU3wbgWRAjufEjEhB70Y7aHYYLEDnUgTDhLbCWcN00PiFMmFHV4HgLvbvVELYNJ++Fpc RxPramygP6V75m6sIp7pckYqEMYlTGuRJcbE3p1nAw8SQtacL4MJkAyQG0OKAbZel8A+5r JjlEfNH47Dk/up/Kk4+0oLfZyTc2ZWBHrDZg+5HsvzmGFHUTwxW4w0780BJD0Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=JQTK40LP; dkim=fail ("headers rsa verify failed") header.d=fsfe.org header.s=2021081301 header.b=H3NmfW3q; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=fsfe.org (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1733298805; a=rsa-sha256; cv=none; b=LTkEMPNyZnqe3doO0q61KeWj2rsC+tRYVoBpZnmGOGfY6FEu6YaV862dLSkau9OPaji9A9 X8Dri5mxbUfK4Au6CYKMmOalXmFbMAwF+RyoyQzxDianWBhPH0M+Kxzahb2w/in4nSzGJT jW4zE373BN+NhhyBSyE1wzKU2KH91Pt6Z2YyuhD4qKUyNSH0e51mWlq2UVsMLnVPwiGYuJ 4WQMsB1p8UJX1IqltkKdCNJiKwbT1HO6+iNuwh83wrR5l2MkfHmHcrI5Oh5zl1swCEQHyZ n3OHLxbkXFtmcLsOwnEEHq0oeeH+9zo9s0Ym5WsMgph9ob2Prw4WaXQCuz48dQ== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 531D34174E for ; Wed, 04 Dec 2024 08:53:25 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tIkBt-0007sF-O7; Wed, 04 Dec 2024 02:52:57 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tIkBF-0007T8-My for guix-patches@gnu.org; Wed, 04 Dec 2024 02:52:24 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tIkB1-00028w-Hm; Wed, 04 Dec 2024 02:52:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:References:In-Reply-To:Date:From:To:Subject; bh=bKDPhHqk8nPzjZP19Fb9zRoYLrnOK1ZLqDZPDrRQlwA=; b=JQTK40LPeXsGRX0L5Wrs3c/B6F0Xw6ENZWcnF9Hrz8obukP/j0e9tJuBinRdgv0G+ev9zqTZFSrrGo1cgFipTRDvBvToXbS1g7CGCxcDURTCDjen8F6FO3eBiDyyORrR/IBpGlCg6fbdns8hT8T9CY9VrAbLL9gDRE1eeh4RrPqILjl1FmMLIxYoy3zosLmqqERq0k03AV5TYdIKHvJ6c3n/iLwbP1RMFEGWgd0O+S2/oAVEUH3Q/Mn1cThb05Mwz58VSVq2K7L3+7VXEy5POKcvHhoFM5HhLhNo5EhzmBr9y1bbPRDQFyamPFdlCxW09Qoyh5I8HtkO3D2FK4q8Jw==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tIkB1-0001gA-16; Wed, 04 Dec 2024 02:52:03 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#74187] [PATCH v2 24/24] gnu: node: Rename variable node-bootstrap and hide package. Resent-From: jlicht@fsfe.org Original-Sender: "Debbugs-submit" Resent-CC: jlicht@fsfe.org, rekado@elephly.net, ludo@gnu.org, guix-patches@gnu.org Resent-Date: Wed, 04 Dec 2024 07:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74187 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 74187@debbugs.gnu.org Cc: Jelle Licht , jlicht@fsfe.org, Ricardo Wurmus , Ludovic =?UTF-8?Q?Court=C3=A8s?= X-Debbugs-Original-Xcc: jlicht@fsfe.org, Ricardo Wurmus , Ludovic =?UTF-8?Q?Court=C3=A8s?= Received: via spool by 74187-submit@debbugs.gnu.org id=B74187.17332986866388 (code B ref 74187); Wed, 04 Dec 2024 07:52:02 +0000 Received: (at 74187) by debbugs.gnu.org; 4 Dec 2024 07:51:26 +0000 Received: from localhost ([127.0.0.1]:34117 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tIkAP-0001ex-Sd for submit@debbugs.gnu.org; Wed, 04 Dec 2024 02:51:26 -0500 Received: from mail2.fsfe.org ([213.95.165.55]:37648) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tIkAM-0001ee-Nm for 74187@debbugs.gnu.org; Wed, 04 Dec 2024 02:51:23 -0500 From: jlicht@fsfe.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fsfe.org; s=2021081301; t=1733298652; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bKDPhHqk8nPzjZP19Fb9zRoYLrnOK1ZLqDZPDrRQlwA=; b=H3NmfW3qk9VlKJiu8QXoHs7xY+E3HMN+HEZ2+wf9RU8KyVi6FVEeJMFtZJ5PTuu7/RzsvS Ri61ElJncHm3yS6h1jTjFO9kUX6F3OhJeCMqwkLji8BeplCOhdpCaMJn6SnpT+3nCSAfrM ViCMbaQYljxmzG7lDrlVhKS56fuIkwY= Date: Wed, 4 Dec 2024 08:49:46 +0100 Message-ID: In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Scanner: mx11.migadu.com X-Migadu-Spam-Score: 2.77 X-Spam-Score: 2.77 X-Migadu-Queue-Id: 531D34174E X-TUID: d4X/l863ndvZ From: Jelle Licht The formerly known as node package has security issues, so should only be used to bootstrap more recent and secure versions of node. * gnu/packages/node.scm (node): Rename to... (node-bootstrap): ... this, and make it a hidden package. Change-Id: I536a8f55faa14f8221915467c2981053f4c4d70e --- gnu/packages/node.scm | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/gnu/packages/node.scm b/gnu/packages/node.scm index 13d2575333..16153b20da 100644 --- a/gnu/packages/node.scm +++ b/gnu/packages/node.scm @@ -56,9 +56,12 @@ (define-module (gnu packages node) #:use-module (gnu packages tls) #:use-module (gnu packages web) #:use-module (ice-9 match) + #:use-module (srfi srfi-1) #:use-module (srfi srfi-26)) -(define-public node +;; This should be the latest version of node that still builds without +;; depending on llhttp. +(define-public node-bootstrap (package (name "node") (version "10.24.1") @@ -338,12 +341,8 @@ (define-public node (license license:expat) (properties '((max-silent-time . 7200) ;2h, needed on ARM (timeout . 21600) ;6h - (cpe-name . "node.js"))))) - -;; This should be the latest version of node that still builds without -;; depending on llhttp. -(define-public node-bootstrap - (hidden-package node)) + (cpe-name . "node.js") + (hidden? . #t))))) ;; Duplicate of node-semver (define-public node-semver-bootstrap @@ -749,7 +748,7 @@ (define-public llhttp-bootstrap (define-public node-lts (package - (inherit node) + (inherit node-bootstrap) (version "20.18.1") (source (origin (method url-fetch) @@ -780,7 +779,7 @@ (define-public node-lts (("deps/uv/uv.gyp") "") (("deps/zlib/zlib.gyp") "")))))) (arguments - (substitute-keyword-arguments (package-arguments node) + (substitute-keyword-arguments (package-arguments node-bootstrap) ((#:configure-flags configure-flags) ''("--shared-cares" "--shared-libuv" @@ -982,7 +981,8 @@ (define-public node-lts nghttp3 `(,nghttp2 "lib") openssl - zlib)))) + zlib)) + (properties (alist-delete 'hidden? (package-properties node-bootstrap))))) (define-public libnode (package/inherit node-lts -- 2.46.0