unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Liliana Marie Prikler <liliana.prikler@gmail.com>
To: Mathieu Othacehe <othacehe@gnu.org>, 57643@debbugs.gnu.org
Subject: [bug#57643] [PATCH 1/3] image: Make the operating-system field mandatory.
Date: Wed, 07 Sep 2022 20:34:47 +0200	[thread overview]
Message-ID: <f0b915a105da96897a7d02fc2304591021da421e.camel@gmail.com> (raw)
In-Reply-To: <20220907124633.17013-1-othacehe@gnu.org>

Hi,

Am Mittwoch, dem 07.09.2022 um 14:46 +0200 schrieb Mathieu Othacehe:
> Make the operating-system field mandatory as creating an image
> without it
> makes no sense. Introduce a new macro, image-without-os for the
> specific cases
> where the image is only created to be inherited from afterwards.
> 
> * gnu/image.scm (<image>)[operating-system]: Make it mandatory.
> * gnu/system/image.scm (image-without-os): New macro.
> (efi-disk-image, efi32-disk-image, iso9660-image, docker-image,
> raw-with-offset-disk-image): Use it.
> * gnu/system/images/hurd.scm (hurd-disk-image): Ditto.
IMHO adding a new macro is a bit much.  Can't we simply add an empty
image from which the others are derived or use (operating-system #f)
literally?  (Alternatively to #f you might prefer "none" as syntactic
sugar.)

I do agree with making operating-system mandatory, though.

Cheers




  parent reply	other threads:[~2022-09-07 18:37 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-07 12:44 [bug#57643] [PATCH 0/3] Document the image API Mathieu Othacehe
2022-09-07 12:46 ` [bug#57643] [PATCH 1/3] image: Make the operating-system field mandatory Mathieu Othacehe
2022-09-07 12:46   ` [bug#57643] [PATCH 2/3] doc: Add a "Platforms" chapter Mathieu Othacehe
2022-09-07 15:37     ` zimoun
2022-09-24  9:55       ` [bug#57643] [PATCH 0/3] Document the image API Ludovic Courtès
2022-09-24 10:10     ` Ludovic Courtès
2022-09-24 10:49       ` Maxime Devos
2022-09-24 13:01         ` Mathieu Othacehe
2022-09-24 16:33         ` Ludovic Courtès
2022-09-24 16:58           ` Maxime Devos
2022-09-25 20:15             ` Ludovic Courtès
2022-09-24 12:50       ` Mathieu Othacehe
2022-09-07 12:46   ` [bug#57643] [PATCH 3/3] doc: Add a "System Images" chapter Mathieu Othacehe
2022-09-07 15:47     ` zimoun
2022-09-24 10:15     ` [bug#57643] [PATCH 0/3] Document the image API Ludovic Courtès
2022-09-07 18:34   ` Liliana Marie Prikler [this message]
2022-09-24 10:16     ` Ludovic Courtès
2022-09-24 10:55   ` [bug#57643] [PATCH 1/3] image: Make the operating-system field mandatory Maxime Devos
2022-09-24 13:02     ` Mathieu Othacehe
2022-09-24 10:18 ` [bug#57643] [PATCH 0/3] Document the image API Ludovic Courtès
2022-09-24 12:59   ` Mathieu Othacehe
2022-09-25 11:53   ` bug#57643: " Mathieu Othacehe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f0b915a105da96897a7d02fc2304591021da421e.camel@gmail.com \
    --to=liliana.prikler@gmail.com \
    --cc=57643@debbugs.gnu.org \
    --cc=othacehe@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).