* [bug#67211] [PATCH] gnu: Add emacs-adwaita-dark-theme
@ 2023-11-15 21:43 Tristan Cottam via Guix-patches via
2023-11-16 11:58 ` Nicolas Goaziou via Guix-patches via
0 siblings, 1 reply; 5+ messages in thread
From: Tristan Cottam via Guix-patches via @ 2023-11-15 21:43 UTC (permalink / raw)
To: 67211
Cc: Tristan Cottam, Andrew Tropin, Katherine Cox-Buday,
Liliana Marie Prikler
* gnu/packages/emacs-xyz.scm (emacs-adwaita-dark-theme): New variable.
Change-Id: Id6e6d0d6aa27e7c1cc6ec0fc11c3a5f09231d751
---
> FWIW, changing the Version keyword in the header is a release. Also, it
> has the benefit of making the version number more meaningful.
I agree, I had missed that version bump commit. However, it isn't in fact the
last one, so I left the rest as it is.
gnu/packages/emacs-xyz.scm | 23 +++++++++++++++++++++++
1 file changed, 23 insertions(+)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index be7ffd1f37..443f315f23 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -1995,6 +1995,29 @@ (define-public emacs-suneater-theme
theme but now takes more inspiration from the Nano theme.")
(license license:gpl3+)))
+(define-public emacs-adwaita-dark-theme
+ (let ((commit "a97d5d5f5657a52c3b4c4b146b4d307dfb1a7a74")
+ (revision "0"))
+ (package
+ (name "emacs-adwaita-dark-theme")
+ (version (git-version "1.1.1" revision commit))
+ (source (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://gitlab.com/jessieh/adwaita-dark-theme")
+ (commit commit)))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32
+ "0g8fjqmz805fhqspbzmpvb90kpzwigl4z56bkykywgy2cwb9ljzh"))))
+ (build-system emacs-build-system)
+ (home-page "https://gitlab.com/jessieh/adwaita-dark-theme")
+ (synopsis "Adwaita-inspired dark color scheme for Emacs")
+ (description
+ "adwaita-dark-theme is an Adwaita-inspired dark color scheme for
+Emacs.")
+ (license license:gpl2+))))
+
(define-public emacs-treepy
(package
(name "emacs-treepy")
base-commit: bd0f2173210416e86281c1de8789e7cdab66dd57
prerequisite-patch-id: 5e36e77f4fa1848dbd20c2e5d5cec31d2473c2a8
--
2.41.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* [bug#67211] [PATCH] gnu: Add emacs-adwaita-dark-theme
2023-11-15 21:43 [bug#67211] [PATCH] gnu: Add emacs-adwaita-dark-theme Tristan Cottam via Guix-patches via
@ 2023-11-16 11:58 ` Nicolas Goaziou via Guix-patches via
2023-11-16 15:38 ` Tristan Cottam via Guix-patches via
0 siblings, 1 reply; 5+ messages in thread
From: Nicolas Goaziou via Guix-patches via @ 2023-11-16 11:58 UTC (permalink / raw)
To: 67211; +Cc: tristan, cox.katherine.e+guix, liliana.prikler, andrew
Hello,
Tristan Cottam via Guix-patches via <guix-patches@gnu.org> writes:
> I agree, I had missed that version bump commit. However, it isn't in fact the
> last one, so I left the rest as it is.
My point is that is it usually better to package version bumps rather
than arbitrary commits. IOW, I'd rather drop the revision and package
057c39313341907b35c68d2179226886a0c276fd instead.
> + (description
> + "adwaita-dark-theme is an Adwaita-inspired dark color scheme for
> +Emacs.")
You didn't change this. Is it intentional?
Regards,
--
Nicolas Goaziou
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-11-16 20:36 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-15 21:43 [bug#67211] [PATCH] gnu: Add emacs-adwaita-dark-theme Tristan Cottam via Guix-patches via
2023-11-16 11:58 ` Nicolas Goaziou via Guix-patches via
2023-11-16 15:38 ` Tristan Cottam via Guix-patches via
2023-11-16 19:57 ` Nicolas Goaziou via Guix-patches via
2023-11-16 20:35 ` bug#67211: " Tristan Cottam via Guix-patches via
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).