unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Liliana Marie Prikler <liliana.prikler@gmail.com>
To: zamfofex <zamfofex@twdb.moe>, 68987@debbugs.gnu.org
Cc: 宋文武 <iyzsong@envs.net>
Subject: [bug#68987] [PATCH 1/2] gnu: moonfish: Update to 0-2.2118580.
Date: Thu, 08 Feb 2024 18:50:36 +0100	[thread overview]
Message-ID: <efce36d9ba2954914522d43aa6efddef14619c5a.camel@gmail.com> (raw)
In-Reply-To: <e64550fd3c8b6b0ba39c7484fc5a679787f99643.1707351996.git.zamfofex@twdb.moe>

Am Mittwoch, dem 07.02.2024 um 21:34 -0300 schrieb zamfofex:
> * gnu/packages/games.scm (moonfish): Update to 0-2.2118580.
> 
> Change-Id: I0c5b0e61f6818d29165a1371da717bb8695db834
> ---
>  gnu/packages/games.scm | 50 ++++++++++++++--------------------------
> --
>  1 file changed, 17 insertions(+), 33 deletions(-)
> 
> diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
> index 06ba868f35..16e2ee828a 100644
> --- a/gnu/packages/games.scm
> +++ b/gnu/packages/games.scm
> @@ -10557,46 +10557,30 @@ (define-public stockfish
>        (license license:gpl3+))))
>  
>  (define-public moonfish
> -  (let ((commit "4f8829009e8c26e6a878261e0bc4c7e7617ef6b6")
> -        (revision "1"))
> +  (let ((commit "2118580d6ab454e165c7a84de6a604f96bc73850")
> +        (revision "2"))
>      (package
>        (name "moonfish")
>        (version (git-version "0" revision commit))
> -      (source (origin
> -                (method git-fetch)
> -                (uri (git-reference
> -                      (url "https://git.sr.ht/~zamfofex/moonfish")
> -                      (commit commit)))
> -                (sha256
> -                 (base32
> -                 
> "1ksg42x9cyn3pbfryy9raqb355k47cqcisascpy157c3cgdr2z60"))
> -                (file-name (git-file-name name version))))
> +      (source
> +       (origin
> +         (method git-fetch)
> +         (uri (git-reference
> +               (url "https://git.sr.ht/~zamfofex/moonfish")
> +               (commit commit)))
> +         (sha256
> +          (base32
> "1vqnmk2mpqd9nfchrirj5g3v3nqyhj3204d6fn3sihc2iqp4zyrk"))
> +         (file-name (git-file-name name version))))
Please don't mix in cosmetic changes with semantic ones.  IMHO the
indentation is fine as-is.
>        (build-system gnu-build-system)
>        (arguments
>         (list
> -        #:make-flags
> -        #~(list (string-append "CC=" #$(cc-for-target)))
> -        #:tests? #f                     ;no check target
> -        #:phases
> -        #~(modify-phases %standard-phases
> -            (delete 'configure)         ;no configure script
> -            (replace 'install           ;no 'install' target
> -              (lambda _
> -                (let* ((out-bin (string-append #$output "/bin"))
> -                       (tools-bin (string-append #$output:tools
> "/bin"))
> -                       (tool (string-append tools-bin "/moonfish-
> ")))
> -                  (mkdir-p out-bin)
> -                  (mkdir-p tools-bin)
> -                  (copy-file "moonfish"
> -                             (string-append out-bin "/moonfish"))
> -                  (copy-file "play"
> -                             (string-append tool "play"))
> -                  (copy-file "lichess"
> -                             (string-append tool "lichess"))
> -                  (copy-file "analyse"
> -                             (string-append tool "analyse"))))))))
> +        #:make-flags #~(list (string-append "CC="
> +                                            #$(cc-for-target))
> +                             (string-append "PREFIX=" %output))
> +        #:tests? #f ;no check target
> +        #:phases #~(modify-phases %standard-phases
> +                     (delete 'configure)))) ;no configure script
You forgot to document this change…
>        (inputs (list bearssl cjson))
> -      (outputs '("out" "tools"))
… as well as this.
>        (home-page "https://git.sr.ht/~zamfofex/moonfish")
>        (synopsis "Simple chess engine written in C")
>        (description

Cheers

  reply	other threads:[~2024-02-08 17:52 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-08  0:31 [bug#68987] [PATCH 0/2] update moonfish zamfofex
2024-02-08  0:34 ` [bug#68987] [PATCH 1/2] gnu: moonfish: Update to 0-2.2118580 zamfofex
2024-02-08 17:50   ` Liliana Marie Prikler [this message]
2024-02-08 23:34     ` zamfofex
2024-02-08  0:34 ` [bug#68987] [PATCH 2/2] gnu: moonfish: Improve description zamfofex
2024-02-28 10:30 ` [bug#68987] Ping Andreas Enge
2024-03-25 13:55 ` [bug#68987] [PATCH v2 1/2] gnu: moonfish: Update to 0-2.fd3471d zamfofex
2024-03-25 13:55   ` [bug#68987] [PATCH v2 2/2] gnu: moonfish: Improve description zamfofex
2024-03-26 20:01 ` [bug#68987] [PATCH v3 1/2] gnu: moonfish: Update to 0-2.fb2cb4f zamfofex
2024-03-26 20:01   ` [bug#68987] [PATCH v3 2/2] gnu: moonfish: Improve description zamfofex
2024-03-27 12:57     ` bug#68987: " Christopher Baines

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=efce36d9ba2954914522d43aa6efddef14619c5a.camel@gmail.com \
    --to=liliana.prikler@gmail.com \
    --cc=68987@debbugs.gnu.org \
    --cc=iyzsong@envs.net \
    --cc=zamfofex@twdb.moe \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).