unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Dariqq <dariqq@posteo.net>
To: 70460@debbugs.gnu.org
Cc: felix@alternativebit.fr
Subject: [bug#70460] [PATCH v2 0/3] Update power-profiles-daemon and add a service-type for it.
Date: Thu,  9 May 2024 08:00:38 +0000	[thread overview]
Message-ID: <ef702260-e612-4b5b-bf76-b9d8a46e4679@posteo.net> (raw)
In-Reply-To: <cover.1714662236.git.dariqq@posteo.net>



On 02.05.24 17:37, Dariqq wrote:
> Hi all,
> 
> Here is v2 of the patches.
> 
> I hope the added manual entry is ok as I don't have prior experience writing texinfo. I've added the note not to use tlp and p-p-d together there too.
> 
> Also is there a better way to set the pythonpath to not include the packages in native-inputs? This decreases guix size of the package by 100 MB.
> 
> Changes compared to v1:
> 
> * Added the commit removing inputs to the first commit.
> * Added back python and python-pygobject as inputs (previously propagated from python-dbusmock in native-inputs).
> * Set GUIX_PYTHONPATH to only refer to nonnative python inputs rather than all.
> * Moved gtk-docs to a seperate doc output.
> * Added a short entry in the manual for the service-type.
> * Added my copyright line in all files.
> 
> Things that could still be improved:
> * The generated manpage looks horrible because python-argparse-manpage is outdated. I've tried updating it but ran into test errors.

For the manpage I've updated python-argparse-manpage in #70834 which got 
pushed yesterday which fixes the manpage for me locally.


> * Test timeout issues on qa? I am not sure what to do here as it is kind of hard for me to guess what an appropriate timeout window would be that would work.
> 
> 

It seems to succeeding now. Maybe we just got lucky this time?

> Dariqq (3):
>    gnu: power-profiles-daemon: Update to 0.21.
>    gnu: power-profiles-daemon: Build gtk-docs.
>    gnu: services: Add power-profiles-daemon-service-type.
> 
>   doc/guix.texi                | 40 +++++++++++++++++++++++++
>   gnu/packages/freedesktop.scm | 56 +++++++++++++++++++++++------------
>   gnu/services/pm.scm          | 57 +++++++++++++++++++++++++++++++++++-
>   3 files changed, 134 insertions(+), 19 deletions(-)
> 
> 
> base-commit: 5010a51fc91aeac5a3b87a3eea04f18f3fe8a3a3




  parent reply	other threads:[~2024-05-09  8:02 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-18 18:31 [bug#70460] [PATCH 0/4] Update power-profiles-daemon and add a service-type for it Dariqq
2024-05-02 15:37 ` [bug#70460] [PATCH v2 0/3] " Dariqq
2024-05-02 15:37   ` [bug#70460] [PATCH v2 1/3] gnu: power-profiles-daemon: Update to 0.21 Dariqq
2024-05-02 15:37   ` [bug#70460] [PATCH v2 2/3] gnu: power-profiles-daemon: Build gtk-docs Dariqq
2024-05-02 15:37   ` [bug#70460] [PATCH v2 3/3] gnu: services: Add power-profiles-daemon-service-type Dariqq
2024-05-25 13:29     ` Ludovic Courtès
2024-05-25 15:15       ` Dariqq
2024-05-09  8:00   ` Dariqq [this message]
2024-05-16  6:55   ` bug#70460: [PATCH v2 0/3] Update power-profiles-daemon and add a service-type for it Christopher Baines

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ef702260-e612-4b5b-bf76-b9d8a46e4679@posteo.net \
    --to=dariqq@posteo.net \
    --cc=70460@debbugs.gnu.org \
    --cc=felix@alternativebit.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).