From: swedebugia <swedebugia@riseup.net>
To: "LaFreniere, Joseph" <joseph@lafreniere.xyz>, 36751@debbugs.gnu.org
Subject: [bug#36751] [PATCH] gnu: Add emacs-hyperbole.
Date: Tue, 6 Aug 2019 13:32:50 +0200 [thread overview]
Message-ID: <ee6cfed9-0472-5138-3a9f-caaaaa9d1c1e@riseup.net> (raw)
In-Reply-To: <877e7urii4.fsf@odyssey.lafreniere.xyz>
Hi!
Thanks for the patch.
On 2019-08-03 06:16, LaFreniere, Joseph wrote:
> I have squashed the fixup into the original commit and rebased on
> current master (82ebb785f178d8618d39b658932d23d9f859fc91). The
> resulting commit is attached.
>
>
> --
> Joseph LaFreniere
Git said this:
$ git apply 0001-gnu-Add-emacs-hyperbole.patch
0001-gnu-Add-emacs-hyperbole.patch:122: space before tab in indent.
(or (and (boundp 'user-mail-address)
0001-gnu-Add-emacs-hyperbole.patch:123: trailing whitespace.
--
0001-gnu-Add-emacs-hyperbole.patch:149: trailing whitespace.
0001-gnu-Add-emacs-hyperbole.patch:155: space before tab in indent.
(dname (or (and (boundp 'message-user-fqdn) (stringp
message-user-fqdn)
0001-gnu-Add-emacs-hyperbole.patch:156: space before tab in indent.
(string-match "\\." message-user-fqdn)
warning: squelched 10 whitespace errors
warning: 15 lines add whitespace errors.
---
Could you take a look at that?
Otherwise LGTM.
(I linted it, inspected the output in the store with 'ls -lR' and opened
the info file)
--
Cheers Swedebugia
next prev parent reply other threads:[~2019-08-06 11:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-21 19:36 [bug#36751] [PATCH] gnu: Add emacs-hyperbole LaFreniere, Joseph
2019-07-23 4:33 ` LaFreniere, Joseph
2019-08-03 4:16 ` LaFreniere, Joseph
2019-08-06 11:32 ` swedebugia [this message]
2020-05-11 23:16 ` Alex ter Weele
2020-06-20 19:33 ` bug#36751: Done: " Jakub Kądziołka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee6cfed9-0472-5138-3a9f-caaaaa9d1c1e@riseup.net \
--to=swedebugia@riseup.net \
--cc=36751@debbugs.gnu.org \
--cc=joseph@lafreniere.xyz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).