From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:bcc0::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id eFTQEuoNZmAvLgEAgWs5BA (envelope-from ) for ; Thu, 01 Apr 2021 20:16:10 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id SMS5DOoNZmAXPgAA1q6Kng (envelope-from ) for ; Thu, 01 Apr 2021 18:16:10 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id CBE8627F55 for ; Thu, 1 Apr 2021 20:16:09 +0200 (CEST) Received: from localhost ([::1]:34208 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lS1rU-0003K7-VV for larch@yhetil.org; Thu, 01 Apr 2021 14:16:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59478) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lS1mZ-0000Xy-IU for guix-patches@gnu.org; Thu, 01 Apr 2021 14:11:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:46981) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lS1mY-0001M7-6K for guix-patches@gnu.org; Thu, 01 Apr 2021 14:11:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lS1mY-0007c1-1v for guix-patches@gnu.org; Thu, 01 Apr 2021 14:11:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#47539] [ SPAM? ] Re: [bug#47539] [PATCH 00/28] Add gh and dependencies Resent-From: Leo Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 01 Apr 2021 18:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47539 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Xinglu Chen , 47539@debbugs.gnu.org Received: via spool by 47539-submit@debbugs.gnu.org id=B47539.161730065829252 (code B ref 47539); Thu, 01 Apr 2021 18:11:01 +0000 Received: (at 47539) by debbugs.gnu.org; 1 Apr 2021 18:10:58 +0000 Received: from localhost ([127.0.0.1]:58527 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lS1mU-0007bk-Hm for submit@debbugs.gnu.org; Thu, 01 Apr 2021 14:10:58 -0400 Received: from mailrelay.tugraz.at ([129.27.2.202]:7120) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lS1mS-0007bY-5g for 47539@debbugs.gnu.org; Thu, 01 Apr 2021 14:10:57 -0400 Received: from nijino.local (194-96-13-79.adsl.highway.telekom.at [194.96.13.79]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4FBB7c1Dskz1LgFR; Thu, 1 Apr 2021 20:10:51 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 mailrelay.tugraz.at 4FBB7c1Dskz1LgFR DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1617300652; bh=UVKX5mqQIjSJ6tB40mUcGL2P58uF+DS7DVkEhCAFVS8=; h=Subject:From:To:Date:In-Reply-To:References:From; b=Ab2FneBQvj2HQbx/mMXQ8OJNnpPKqXhHFk+45rryzqHlw24uNyDuQtq39r4isF/3/ J5jPSC74PtKqXCqV8yYpbKlrQBO5Z0AtouojA1BhWWsb+s9FNYXsDAyIUBjmLvP36X A4sfSw9NBXlZhus5p3Ixkit/Kn8DGygtpBWh7VPo= Message-ID: From: Leo Prikler Date: Thu, 01 Apr 2021 20:10:51 +0200 In-Reply-To: <871rbt519u.fsf@yoctocell.xyz> References: <7f41ded1648030ed8f4db3165bfe4ccb2cb6b2a9.camel@student.tugraz.at> <87czve3vrg.fsf@yoctocell.xyz> <877dlm3rak.fsf@yoctocell.xyz> <871rbt519u.fsf@yoctocell.xyz> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-TUG-Backscatter-control: bt4lQm5Tva3SBgCuw0EnZw X-Spam-Scanner: SpamAssassin 3.003001 X-Spam-Score-relay: -1.9 X-Scanned-By: MIMEDefang 2.74 on 129.27.10.117 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1617300969; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=UVKX5mqQIjSJ6tB40mUcGL2P58uF+DS7DVkEhCAFVS8=; b=tPoHBv/qUWOYztR9FugabDU8hr5HmC/FxTHDy1BwEOo0UwCcE+ZapVWH8eDIK+D12u/P4y NY/PLGXIfQh7iRZJ5JzaqLjKwAldRlwEfUvfnuu/D6NjLSjR0g5p9qafJPikwMqEd1SkPF mfzpBR5AEdfNHkv53uj9Lw1v0OWqccMicFKn9FmhKUSi1rsDlfc2a3rZVClfPf6tJ4dLhN DHu9FeUeDF32PVMYMCq/F8Kcc6CIekFw2p1azfWcSGo8y09J3NjRpr5JwzNmRuzTs13vEj m3n0jXZ9BazaubXmcpr04nei3tCGelRCtRXiW4rdrHAbgJyzUXtomI5Iz81nzg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1617300969; a=rsa-sha256; cv=none; b=rsJoPk5qJb9mD3O6QSWlyktOAIeGq7ly5W8Jq5t1Mo+JLl/4rPq6nYSWjm3l2YKOlknsL6 9cElEEnkSF1ypYax4EXt+b0qWLCIiPgcZK+MpTB0Cn7M2YegEJfBnW9zXchG8FSq9hbeyP ZKodgKqi/vavLZA3Y88lZTK5MH1CFPDeUtCual92L0j052dmYbzfgeNXpo1bo5wEqH76Co zvc8m+Z+0QvjuBu0b4wBHzRoL5V5EgVPXM+4AMcMqkkiH/kzbm4eoxJ7iCm+JiXIJ6YLGU WUDe7f/lPFz/m1w1d5LQj6A8TKRf4cWVXA+B6wSHVyA8aS+1vMMpqR24QriJew== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tugraz.at header.s=mailrelay header.b=Ab2FneBQ; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.33 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tugraz.at header.s=mailrelay header.b=Ab2FneBQ; dmarc=fail reason="SPF not aligned (relaxed)" header.from=student.tugraz.at (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: CBE8627F55 X-Spam-Score: -1.33 X-Migadu-Scanner: scn0.migadu.com X-Migadu-Mailbox-Spam: Yes X-TUID: +6FV2Wg8XI7/ Am Donnerstag, den 01.04.2021, 20:05 +0200 schrieb Xinglu Chen: > On Thu, Apr 01 2021, Leo Prikler wrote: > > > > Compiling github-cli without the package doesn't work, and the > > > package is used in multiple places in the source code. I don't > > > really know what we can do here. Should I open an issue on their > > > GitHub page, or just leave it as is? > > For now, I don't think this is going to be a blocking issue, as > > long as > > the package and the input are appropriately marked, e.g. with > > comments, > > and we make sure not to endorse the Microsoft OS through them. > > As to how we might handle this, we could do our own investigations > > into > > dropping the dependency, but asking a question (make sure to tag it > > as > > such) should work as well. Also be clear, that the goal is not > > necessarily to remove the dependency altogether, but rather make it > > an > > optional one. > > > > After doing some quick investigations myself, I think the following > > pair of substitute*s might work: > > (("github.com/cli/safeexec") "os/exec") > > (("safeexec") "exec") > > Thank you for the pointer, I managed to get it to work with the > following snippet: > > #+begin_src scheme > (add-after 'unpack 'remove-safeexec > (lambda* (#:key outputs #:allow-other-keys) > (let ((prefix-file (lambda (file) > (string-append "src/github.com/cli/cli/" > file)))) > ;; 'github.com/cli/safeexec' is only used for Windows, > we > ;; replace it with the regular 'os/exec'. See > ;; for discussion. > (substitute* (map prefix-file > '("pkg/cmd/alias/expand/expand.go" > "script/build.go")) > (("github.com/cli/safeexec") "os/exec") > (("safeexec") "exec")) > ;; These files have already imported 'os/exec', > meaning that > ;; 'os/exec' would get imported twice, causing an > error. > ;; Instead, we just remove the > 'github.com/cli/safeexec'. > (substitute* (map prefix-file > '("cmd/gh/main.go" > "git/git.go" > "pkg/iostreams/iostreams.go" > "pkg/cmd/auth/shared/ssh_keys.go" > "pkg/cmd/pr/checkout/checkout.go" > "pkg/cmdutil/web_browser.go" > "pkg/surveyext/editor_manual.go")) > (("\"github.com/cli/safeexec\"") "") > (("safeexec") "exec"))))) > #+end_src This should probably be implemented with directory excursions, but other than that if it works for you, then LGTM :)