From: Leo Prikler <leo.prikler@student.tugraz.at>
To: Xinglu Chen <public@yoctocell.xyz>, 47539@debbugs.gnu.org
Subject: [bug#47539] [ SPAM? ] Re: [bug#47539] [PATCH 00/28] Add gh and dependencies
Date: Thu, 01 Apr 2021 20:10:51 +0200 [thread overview]
Message-ID: <ed90b9073694d7d9e858cc46650c0a7a25b19866.camel@student.tugraz.at> (raw)
In-Reply-To: <871rbt519u.fsf@yoctocell.xyz>
Am Donnerstag, den 01.04.2021, 20:05 +0200 schrieb Xinglu Chen:
> On Thu, Apr 01 2021, Leo Prikler wrote:
>
> > > Compiling github-cli without the package doesn't work, and the
> > > package is used in multiple places in the source code. I don't
> > > really know what we can do here. Should I open an issue on their
> > > GitHub page, or just leave it as is?
> > For now, I don't think this is going to be a blocking issue, as
> > long as
> > the package and the input are appropriately marked, e.g. with
> > comments,
> > and we make sure not to endorse the Microsoft OS through them.
> > As to how we might handle this, we could do our own investigations
> > into
> > dropping the dependency, but asking a question (make sure to tag it
> > as
> > such) should work as well. Also be clear, that the goal is not
> > necessarily to remove the dependency altogether, but rather make it
> > an
> > optional one.
> >
> > After doing some quick investigations myself, I think the following
> > pair of substitute*s might work:
> > (("github.com/cli/safeexec") "os/exec")
> > (("safeexec") "exec")
>
> Thank you for the pointer, I managed to get it to work with the
> following snippet:
>
> #+begin_src scheme
> (add-after 'unpack 'remove-safeexec
> (lambda* (#:key outputs #:allow-other-keys)
> (let ((prefix-file (lambda (file)
> (string-append "src/github.com/cli/cli/"
> file))))
> ;; 'github.com/cli/safeexec' is only used for Windows,
> we
> ;; replace it with the regular 'os/exec'. See
> ;; <https://issues.guix.gnu.org/47539> for discussion.
> (substitute* (map prefix-file
> '("pkg/cmd/alias/expand/expand.go"
> "script/build.go"))
> (("github.com/cli/safeexec") "os/exec")
> (("safeexec") "exec"))
> ;; These files have already imported 'os/exec',
> meaning that
> ;; 'os/exec' would get imported twice, causing an
> error.
> ;; Instead, we just remove the
> 'github.com/cli/safeexec'.
> (substitute* (map prefix-file
> '("cmd/gh/main.go"
> "git/git.go"
> "pkg/iostreams/iostreams.go"
> "pkg/cmd/auth/shared/ssh_keys.go"
> "pkg/cmd/pr/checkout/checkout.go"
> "pkg/cmdutil/web_browser.go"
> "pkg/surveyext/editor_manual.go"))
> (("\"github.com/cli/safeexec\"") "")
> (("safeexec") "exec")))))
> #+end_src
This should probably be implemented with directory excursions, but
other than that if it works for you, then LGTM :)
next prev parent reply other threads:[~2021-04-01 18:16 UTC|newest]
Thread overview: 108+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-01 7:51 [bug#47539] [PATCH 00/28] Add gh and dependencies Xinglu Chen
2021-04-01 8:01 ` [bug#47539] [PATCH 20/28] gnu: Add go-github-com-itchyny-timefmt-go Xinglu Chen
2021-04-01 8:02 ` [bug#47539] [PATCH 21/28] gnu: Add go-github-com-itchyny-gojq Xinglu Chen
2021-04-01 8:02 ` [bug#47539] [PATCH 22/28] gnu: Add go-github-com-mattn-go-runewidth Xinglu Chen
2021-04-01 8:02 ` [bug#47539] [PATCH 23/28] gnu: Add go-github-com-rivo-uniseg Xinglu Chen
2021-04-01 8:02 ` [bug#47539] [PATCH 24/28] gnu: Add go-github-com-shurcool-githubv4 Xinglu Chen
2021-04-01 8:02 ` [bug#47539] [PATCH 25/28] gnu: Add go-gopkg-in-yaml-v3 Xinglu Chen
2021-04-01 8:02 ` [bug#47539] [PATCH 26/28] gnu: Add go-github-com-shurcool-graphql Xinglu Chen
2021-04-01 8:02 ` [bug#47539] [PATCH 01/28] gnu: go-github-com-charmbracelet-glamour: Move some Xinglu Chen
2021-04-01 8:02 ` [bug#47539] [PATCH 27/28] gnu: Add go-github-com-cli-shurcool-graphql Xinglu Chen
2021-04-01 8:02 ` [bug#47539] [PATCH 02/28] gnu: Add go-github-com-hinshun-vt10x Xinglu Chen
2021-04-01 8:02 ` [bug#47539] [PATCH 03/28] gnu: Add go-github-com-creack-pty Xinglu Chen
2021-04-01 8:02 ` [bug#47539] [PATCH 04/28] gnu: Add go-github-com-kr-pty Xinglu Chen
2021-04-01 8:02 ` [bug#47539] [PATCH 05/28] gnu: Add go-github-com-netflix-go-expect Xinglu Chen
2021-04-01 8:02 ` [bug#47539] [PATCH 06/28] gnu: Add go-github-com-alecaivazis-survey-v2 Xinglu Chen
2021-04-01 8:02 ` [bug#47539] [PATCH 07/28] gnu: Add go-github-com-makenowjust-heredoc Xinglu Chen
2021-04-01 8:02 ` [bug#47539] [PATCH 08/28] gnu: Add go-github-com-briandowns-spinner Xinglu Chen
2021-04-01 8:02 ` [bug#47539] [PATCH 09/28] gnu: Add go-github-com-cli-browser Xinglu Chen
2021-04-01 8:02 ` [bug#47539] [PATCH 10/28] gnu: Add go-github-com-cli-oauth Xinglu Chen
2021-04-01 8:02 ` [bug#47539] [PATCH 12/28] gnu: Add go-github-com-russross-blackfriday-v2 Xinglu Chen
2021-04-01 8:02 ` [bug#47539] [PATCH 11/28] gnu: Add go-github-com-cli-safeexec Xinglu Chen
2021-04-01 8:02 ` [bug#47539] [PATCH 13/28] gnu: Add go-github-com-shurcool-sanitized-anchor-name Xinglu Chen
2021-04-01 8:02 ` [bug#47539] [PATCH 14/28] gnu: Add go-github-com-cpuguy83-go-md2man-v2 Xinglu Chen
2021-04-01 8:02 ` [bug#47539] [PATCH 16/28] gnu: Add go-github-com-gabriel-vasile-mimetype Xinglu Chen
2021-04-01 8:02 ` [bug#47539] [PATCH 15/28] gnu: Add go-github-com-enescakir-emoji Xinglu Chen
2021-04-01 8:02 ` [bug#47539] [PATCH 17/28] gnu: Add go-github-com-google-shlex Xinglu Chen
2021-04-01 8:02 ` [bug#47539] [PATCH 18/28] gnu: Add go-github-com-henvic-httpretty Xinglu Chen
2021-04-01 8:02 ` [bug#47539] [PATCH 19/28] gnu: Add go-github-com-itchyny-go-flags Xinglu Chen
2021-04-01 8:02 ` [bug#47539] [PATCH 28/28] gnu: Add gh Xinglu Chen
2021-04-01 10:08 ` [bug#47539] [PATCH 00/28] Add gh and dependencies Leo Prikler
2021-04-01 14:49 ` Xinglu Chen
2021-04-01 16:20 ` Leo Prikler
2021-04-01 16:25 ` Xinglu Chen
2021-04-01 16:47 ` Leo Prikler
2021-04-01 17:21 ` Jack Hill
2021-04-01 18:05 ` Xinglu Chen
2021-04-01 18:10 ` Leo Prikler [this message]
2021-04-01 18:16 ` Xinglu Chen
2021-04-01 18:31 ` [bug#47539] [PATCH v2 00/26] Add github-cli " Xinglu Chen
2021-04-01 18:31 ` [bug#47539] [PATCH v2 18/26] gnu: Add go-github-com-itchyny-timefmt-go Xinglu Chen
2021-04-01 18:31 ` [bug#47539] [PATCH v2 19/26] gnu: Add go-github-com-itchyny-gojq Xinglu Chen
2021-04-01 18:31 ` [bug#47539] [PATCH v2 20/26] gnu: Add go-github-com-mattn-go-runewidth Xinglu Chen
2021-04-01 18:31 ` [bug#47539] [PATCH v2 21/26] gnu: Add go-github-com-rivo-uniseg Xinglu Chen
2021-04-01 18:31 ` [bug#47539] [PATCH v2 22/26] gnu: Add go-github-com-shurcool-githubv4 Xinglu Chen
2021-04-01 18:31 ` [bug#47539] [PATCH v2 23/26] gnu: Add go-gopkg-in-yaml-v3 Xinglu Chen
2021-04-01 18:31 ` [bug#47539] [PATCH v2 24/26] gnu: Add go-github-com-shurcool-graphql Xinglu Chen
2021-04-01 18:31 ` [bug#47539] [PATCH v2 25/26] gnu: Add go-github-com-cli-shurcool-graphql Xinglu Chen
2021-04-01 18:31 ` [bug#47539] [PATCH v2 01/26] gnu: Add go-github-com-hinshun-vt10x Xinglu Chen
2021-04-01 18:31 ` [bug#47539] [PATCH v2 02/26] gnu: Add go-github-com-creack-pty Xinglu Chen
2021-04-01 18:31 ` [bug#47539] [PATCH v2 03/26] gnu: Add go-github-com-kr-pty Xinglu Chen
2021-04-01 18:31 ` [bug#47539] [PATCH v2 04/26] gnu: Add go-github-com-netflix-go-expect Xinglu Chen
2021-04-01 18:31 ` [bug#47539] [PATCH v2 05/26] gnu: Add go-github-com-alecaivazis-survey-v2 Xinglu Chen
2021-04-01 18:31 ` [bug#47539] [PATCH v2 06/26] gnu: Add go-github-com-makenowjust-heredoc Xinglu Chen
2021-04-01 18:31 ` [bug#47539] [PATCH v2 07/26] gnu: Add go-github-com-briandowns-spinner Xinglu Chen
2021-04-01 18:31 ` [bug#47539] [PATCH v2 08/26] gnu: Add go-github-com-cli-browser Xinglu Chen
2021-04-01 18:31 ` [bug#47539] [PATCH v2 09/26] gnu: Add go-github-com-cli-oauth Xinglu Chen
2021-04-01 18:31 ` [bug#47539] [PATCH v2 10/26] gnu: Add go-github-com-cli-safeexec Xinglu Chen
2021-04-01 18:31 ` [bug#47539] [PATCH v2 11/26] gnu: Add go-github-com-russross-blackfriday-v2 Xinglu Chen
2021-04-01 18:31 ` [bug#47539] [PATCH v2 12/26] gnu: Add go-github-com-cpuguy83-go-md2man-v2 Xinglu Chen
2021-04-01 18:31 ` [bug#47539] [PATCH v2 13/26] gnu: Add go-github-com-enescakir-emoji Xinglu Chen
2021-04-01 18:31 ` [bug#47539] [PATCH v2 14/26] gnu: Add go-github-com-gabriel-vasile-mimetype Xinglu Chen
2021-04-01 18:31 ` [bug#47539] [PATCH v2 15/26] gnu: Add go-github-com-google-shlex Xinglu Chen
2021-04-01 18:31 ` [bug#47539] [PATCH v2 16/26] gnu: Add go-github-com-henvic-httpretty Xinglu Chen
2021-04-01 18:31 ` [bug#47539] [PATCH v2 17/26] gnu: Add go-github-com-itchyny-go-flags Xinglu Chen
2021-04-01 18:31 ` [bug#47539] [PATCH v2 26/26] gnu: Add github-cli Xinglu Chen
2021-04-19 13:24 ` [bug#47539] [PATCH v2 00/26] Add github-cli and dependencies Xinglu Chen
2021-04-19 14:15 ` Leo Prikler
2021-04-19 14:39 ` Xinglu Chen
2021-04-19 15:21 ` [bug#47539] [PATCH v3 00/25] " Xinglu Chen
2021-04-19 15:22 ` [bug#47539] [PATCH v3 01/25] gnu: Add go-github-com-hinshun-vt10x Xinglu Chen
2021-04-19 15:22 ` [bug#47539] [PATCH v3 02/25] gnu: Add go-github-com-creack-pty Xinglu Chen
2021-04-19 15:22 ` [bug#47539] [PATCH v3 03/25] gnu: Add go-github-com-kr-pty Xinglu Chen
2021-04-19 15:22 ` [bug#47539] [PATCH v3 04/25] gnu: Add go-github-com-netflix-go-expect Xinglu Chen
2021-04-19 15:22 ` [bug#47539] [PATCH v3 05/25] gnu: Add go-github-com-alecaivazis-survey-v2 Xinglu Chen
2021-04-19 15:22 ` [bug#47539] [PATCH v3 06/25] gnu: Add go-github-com-makenowjust-heredoc Xinglu Chen
2021-04-19 15:22 ` [bug#47539] [PATCH v3 07/25] gnu: Add go-github-com-briandowns-spinner Xinglu Chen
2021-04-19 15:22 ` [bug#47539] [PATCH v3 08/25] gnu: Add go-github-com-cli-browser Xinglu Chen
2021-04-19 15:22 ` [bug#47539] [PATCH v3 09/25] gnu: Add go-github-com-cli-oauth Xinglu Chen
2021-04-19 15:22 ` [bug#47539] [PATCH v3 10/25] gnu: Add go-github-com-russross-blackfriday-v2 Xinglu Chen
2021-04-19 15:22 ` [bug#47539] [PATCH v3 11/25] gnu: Add go-github-com-cpuguy83-go-md2man-v2 Xinglu Chen
2021-04-19 15:23 ` [bug#47539] [PATCH v3 12/25] gnu: Add go-github-com-enescakir-emoji Xinglu Chen
2021-04-19 15:23 ` [bug#47539] [PATCH v3 13/25] gnu: Add go-github-com-gabriel-vasile-mimetype Xinglu Chen
2021-04-19 15:23 ` [bug#47539] [PATCH v3 14/25] gnu: Add go-github-com-google-shlex Xinglu Chen
2021-04-19 15:23 ` [bug#47539] [PATCH v3 15/25] gnu: Add go-github-com-henvic-httpretty Xinglu Chen
2021-04-19 15:23 ` [bug#47539] [PATCH v3 16/25] gnu: Add go-github-com-itchyny-go-flags Xinglu Chen
2021-04-19 15:23 ` [bug#47539] [PATCH v3 17/25] gnu: Add go-github-com-itchyny-timefmt-go Xinglu Chen
2021-04-19 15:23 ` [bug#47539] [PATCH v3 18/25] gnu: Add go-github-com-itchyny-gojq Xinglu Chen
2021-04-19 15:23 ` [bug#47539] [PATCH v3 19/25] gnu: Add go-github-com-mattn-go-runewidth Xinglu Chen
2021-04-19 15:23 ` [bug#47539] [PATCH v3 20/25] gnu: Add go-github-com-rivo-uniseg Xinglu Chen
2021-04-19 15:23 ` [bug#47539] [PATCH v3 21/25] gnu: Add go-github-com-shurcool-githubv4 Xinglu Chen
2021-04-19 15:23 ` [bug#47539] [PATCH v3 22/25] gnu: Add go-gopkg-in-yaml-v3 Xinglu Chen
2021-04-19 15:24 ` [bug#47539] [PATCH v3 23/25] gnu: Add go-github-com-shurcool-graphql Xinglu Chen
2021-04-19 15:24 ` [bug#47539] [PATCH v3 24/25] gnu: Add go-github-com-cli-shurcool-graphql Xinglu Chen
2021-04-19 15:24 ` [bug#47539] [PATCH v3 25/25] gnu: Add github-cli Xinglu Chen
2021-04-19 22:37 ` [bug#47539] Sharlatan Hellseher
2021-04-20 5:26 ` [bug#47539] Xinglu Chen
2021-04-20 5:34 ` [bug#47539] Leo Famulari
2021-04-20 7:34 ` [bug#47539] Xinglu Chen
2021-05-21 17:08 ` [bug#47539] Leo Prikler
2021-05-21 20:34 ` [bug#47539] Leo Famulari
2021-06-05 19:16 ` [bug#47539] Xinglu Chen
2021-06-06 17:26 ` [bug#47539] Leo Famulari
2021-06-07 12:58 ` [bug#47539] Xinglu Chen
2021-06-07 13:11 ` [bug#47539] Xinglu Chen
2021-06-07 13:33 ` [bug#47539] Leo Prikler
2021-06-07 17:19 ` [bug#47539] Leo Famulari
2021-07-15 12:24 ` [bug#47539] Add github-cli Leo Prikler
2021-07-16 17:20 ` Xinglu Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed90b9073694d7d9e858cc46650c0a7a25b19866.camel@student.tugraz.at \
--to=leo.prikler@student.tugraz.at \
--cc=47539@debbugs.gnu.org \
--cc=public@yoctocell.xyz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).