From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id CO5tKORglF9MUgAA0tVLHw (envelope-from ) for ; Sat, 24 Oct 2020 17:14:12 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id sJJmJORglF/nJAAA1q6Kng (envelope-from ) for ; Sat, 24 Oct 2020 17:14:12 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 234559403C6 for ; Sat, 24 Oct 2020 17:14:12 +0000 (UTC) Received: from localhost ([::1]:55938 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kWN7K-0003yb-Tx for larch@yhetil.org; Sat, 24 Oct 2020 13:14:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33686) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kWN1O-0006on-6T for guix-patches@gnu.org; Sat, 24 Oct 2020 13:08:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:51741) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kWN1N-0006HE-Td for guix-patches@gnu.org; Sat, 24 Oct 2020 13:08:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kWN1N-0004qH-OQ for guix-patches@gnu.org; Sat, 24 Oct 2020 13:08:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#41219] [PATCH 2/2] guix: Enforce package.json "files" directive. Resent-From: paul Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 24 Oct 2020 17:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41219 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Jelle Licht , 41219@debbugs.gnu.org Received: via spool by 41219-submit@debbugs.gnu.org id=B41219.160355925118570 (code B ref 41219); Sat, 24 Oct 2020 17:08:01 +0000 Received: (at 41219) by debbugs.gnu.org; 24 Oct 2020 17:07:31 +0000 Received: from localhost ([127.0.0.1]:35054 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kWN0t-0004pS-I1 for submit@debbugs.gnu.org; Sat, 24 Oct 2020 13:07:31 -0400 Received: from latitanza.investici.org ([82.94.249.234]:61555) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kWN0q-0004pG-CG for 41219@debbugs.gnu.org; Sat, 24 Oct 2020 13:07:29 -0400 Received: from mx3.investici.org (unknown [127.0.0.1]) by latitanza.investici.org (Postfix) with ESMTP id 4CJSFq1BB9z8sgh; Sat, 24 Oct 2020 17:07:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=autistici.org; s=stigmate; t=1603559247; bh=wuZq+FvQECeZT9W3bia1awCinbmd+dSzHIgSLr48uDQ=; h=Subject:To:References:From:Date:In-Reply-To:From; b=HAwLV19BtS29cYuhdBdzaWO+WZgFROvan18w6OwABDx0AaNqQ66SfmtTQdiXt1VdS hN+JcNBqHLGR0W1LxeJ0mGBNgw+axxrXiY1Ld7HIGrMFr8ftqnb+YZy2t37MDgADZ5 CW4HlNNYMRdWoMby5acjgnb1bEA2P6yN5IPwwkco= Received: from [82.94.249.234] (mx3.investici.org [82.94.249.234]) (Authenticated sender: goodoldpaul@autistici.org) by localhost (Postfix) with ESMTPSA id 4CJSFp6bS4z8sgM; Sat, 24 Oct 2020 17:07:26 +0000 (UTC) References: <20200512213131.28873-1-goodoldpaul@autistici.org> <20200512213131.28873-2-goodoldpaul@autistici.org> <875z88jkg9.fsf@jlicht.xyz> <7bea951c-c8c8-cca9-4bfe-8d8f5c83e2ab@autistici.org> <87a6xhel9s.fsf@jlicht.xyz> <86zh4bwyek.fsf@fsfe.org> From: paul Message-ID: Date: Sat, 24 Oct 2020 19:07:26 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Icedove/78.3.2 MIME-Version: 1.0 In-Reply-To: <86zh4bwyek.fsf@fsfe.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Spam-Score: -0.1 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.1 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=fail (rsa verify failed) header.d=autistici.org header.s=stigmate header.b=HAwLV19B; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -0.01 X-TUID: 0nf1PqyS0XO/ Hi Jelle, > I've been working on an alternative implementation to achieve what this > patch is trying to do; See [1] for what I tried. Do you think that > addresses your use-case as well? If so, perhaps we can still have a look > at the glob code you contributed, as it seems useful outside of an npm > context. I think it definitely does, thank you for your work :D I agree that my patch to the node-build-system is not useful anymore, so if deem the other patch worth of being merged I'd go that way. Thank you for your review, Giacomo