From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60363) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fDyGM-00048F-7t for guix-patches@gnu.org; Wed, 02 May 2018 16:22:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fDyGI-0005mJ-8S for guix-patches@gnu.org; Wed, 02 May 2018 16:22:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:39475) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fDyGI-0005mD-3s for guix-patches@gnu.org; Wed, 02 May 2018 16:22:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fDyGH-0002Dm-TT for guix-patches@gnu.org; Wed, 02 May 2018 16:22:01 -0400 Subject: [bug#31331] [PATCH 1/2] gnu: Add bitlbee-discord. Resent-Message-ID: References: <20180501120535.13961-1-contact@parouby.fr> <20180502184112.fi7dtxv2lzz3rxqi@abyayala> From: parouby Message-ID: Date: Wed, 2 May 2018 22:21:54 +0200 MIME-Version: 1.0 In-Reply-To: <20180502184112.fi7dtxv2lzz3rxqi@abyayala> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Nils Gillmann Cc: 31331@debbugs.gnu.org Hi Nils, On 02/05/2018 20:41, Nils Gillmann wrote: >> + (string-append >> + "https://github.com/sm00th/bitlbee-discord/" >> + "archive/" version ".tar.gz")) > > Nitpick, I would write it like:> + (uri > + (string-append "https://github.com/sm00th/bitlbee-discord/" > + "archive/" version ".tar.gz")) Yes, it's true, my bad ! >> + (add-before 'configure 'bash-path >> + (lambda* (#:key inputs outputs #:allow-other-keys) >> + (substitute* "configure" >> + (("\\$SHELL") (string-append (assoc-ref inputs "bash") >> + "/bin/sh"))))) > > Is the configure.ac in this case special, or why doesn't it pick our SHELL > that is already in the environment of the build chroot? In this case, without modification the configure try to run '/bin/bash' and don't care about 'SHELL' environment variable. I don't found any other way. Any idea ? >> + (native-inputs `(("pkg-config" ,pkg-config) >> + ("autoconf" ,autoconf) >> + ("automake" ,automake) >> + ("texinfo" ,texinfo) >> + ("libtool" ,libtool) >> + ("bitlbee" ,bitlbee) > > Does the buildsystem of bitlbee-discord check for bitlbee, or why is this required? Yes it's need bitlbee lib and header for compilation (just like bitlbee-dev debian package). Thanks, -- Pierre-Antoine