From: Maxime Devos <maximedevos@telenet.be>
To: "Wamm K. D" <jaft.r@outlook.com>, 54311@debbugs.gnu.org
Subject: [bug#54311] [PATCH v2] gnu: tint2: Update to 17.0.2.
Date: Wed, 11 May 2022 11:51:09 +0200 [thread overview]
Message-ID: <ebbd6f9954ea39103d07c810a55fe30c3aac1149.camel@telenet.be> (raw)
In-Reply-To: <DM5PR04MB37727B6BF7C68A4B17C8BF5099E29@DM5PR04MB3772.namprd04.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 1218 bytes --]
Wamm K. D schreef op za 02-04-2022 om 22:01 [-0500]:
> ---
> Here we go, Maxime; I've switched the ~fetch~ method to =git=.
>
> I think you're absolutely right about the =fix-installation-prefix= phase not
> being necessary as "etc" isn't even in the =CMakeLists.txt= file, anymore; I had
> no issues building with the phase removed, as well.
>
> Removing not–running-tests, however, did result in a "make: *** No rule to make
> target 'test'. Stop." error, however, so I'm guessing that, while the files in
> that directory are used for testing, they are not incorporated as part of the
> build process and there still is no target so I've left that in.
There's 'regression.py' which has a 'main' and 'run_unit_tests'. Maybe
'regression.py' can be run in the 'check' phase?
>
> Hopefully this addresses everything and thanks a ton for looking over this!
Looks ok (except for 'regression.py' not being run), but for
completeneess you might want to run it in a a pure environment (./pre-
inst-env guix shell --pure tint2) and look for problems like missing
icons or configuration not working or ‘warning: configuration scheme
things / file chooser’ things.
Greetings,
Maxime.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]
next prev parent reply other threads:[~2022-05-11 10:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <23>
2022-04-03 3:01 ` [bug#54311] [PATCH v2] gnu: tint2: Update to 17.0.2 Wamm K. D
2022-05-10 2:05 ` Jaft
2022-05-11 9:51 ` Maxime Devos [this message]
2022-05-19 4:54 ` Jaft
2022-05-19 13:13 ` Maxime Devos
2022-05-19 15:57 ` Jaft
[not found] ` <1643733361.385880.1652975850912@mail.yahoo.com>
2022-05-22 7:49 ` Jaft
2022-08-04 2:17 ` bug#54311: [PATCH] " 宋文武 via Guix-patches via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ebbd6f9954ea39103d07c810a55fe30c3aac1149.camel@telenet.be \
--to=maximedevos@telenet.be \
--cc=54311@debbugs.gnu.org \
--cc=jaft.r@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).