From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id gKWMDIJS2V/bFwAA0tVLHw (envelope-from ) for ; Wed, 16 Dec 2020 00:19:14 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id IOlICIJS2V/EXAAAbx9fmQ (envelope-from ) for ; Wed, 16 Dec 2020 00:19:14 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 452FC9404CE for ; Wed, 16 Dec 2020 00:19:13 +0000 (UTC) Received: from localhost ([::1]:59734 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kpKXA-0006Hi-3i for larch@yhetil.org; Tue, 15 Dec 2020 19:19:12 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:34682) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kpKX0-0006Ha-1s for guix-patches@gnu.org; Tue, 15 Dec 2020 19:19:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:47922) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kpKWz-00068q-Qk for guix-patches@gnu.org; Tue, 15 Dec 2020 19:19:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kpKWz-0005hn-Kt for guix-patches@gnu.org; Tue, 15 Dec 2020 19:19:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#44806] [PATCH staging 5/6] gnu: Add pitivi. Resent-From: Leo Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 16 Dec 2020 00:19:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44806 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Leo Famulari Received: via spool by 44806-submit@debbugs.gnu.org id=B44806.160807792121899 (code B ref 44806); Wed, 16 Dec 2020 00:19:01 +0000 Received: (at 44806) by debbugs.gnu.org; 16 Dec 2020 00:18:41 +0000 Received: from localhost ([127.0.0.1]:59468 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kpKWf-0005h8-13 for submit@debbugs.gnu.org; Tue, 15 Dec 2020 19:18:41 -0500 Received: from mailrelay.tugraz.at ([129.27.2.202]:32025) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kpKWc-0005gy-He for 44806@debbugs.gnu.org; Tue, 15 Dec 2020 19:18:39 -0500 Received: from nijino.local (217-149-174-13.nat.highway.telekom.at [217.149.174.13]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4CwbMH4kMPz3wZB; Wed, 16 Dec 2020 01:18:35 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1608077915; bh=kTpL4Otx7xpP7UHdieuSSzt8u0sSMYYqKOCjnBZHu6w=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=q29xGtdS095M0fWwId2tk6WLah7Q3EylxkWfD2HeZ3p0zpFtYSBormHq7ecMSgKGl gNmqgVcqapcJdv/GceYllwBSb+OOspzoZyaj3NPcPnQrqgPrKZksFth0+Rr0JFiFeg H240l/l+oyrIwAfaKNOeFGFJb3/99irWn3PnZUDc= Message-ID: From: Leo Prikler Date: Wed, 16 Dec 2020 01:18:33 +0100 In-Reply-To: References: <20201122203625.1347-1-leo.prikler@student.tugraz.at> <20201122203625.1347-5-leo.prikler@student.tugraz.at> <5ec8e559cc35936d03bfbc88593a36d09a61649c.camel@student.tugraz.at> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TUG-Backscatter-control: bt4lQm5Tva3SBgCuw0EnZw X-Spam-Scanner: SpamAssassin 3.003001 X-Spam-Score-relay: -1.9 X-Scanned-By: MIMEDefang 2.74 on 129.27.10.116 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 44806@debbugs.gnu.org Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -1.21 Authentication-Results: aspmx1.migadu.com; dkim=fail (headers rsa verify failed) header.d=tugraz.at header.s=mailrelay header.b=q29xGtdS; dmarc=fail reason="SPF not aligned (relaxed)" header.from=student.tugraz.at (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 452FC9404CE X-Spam-Score: -1.21 X-Migadu-Scanner: scn0.migadu.com X-TUID: Qllrx2AQB3en Am Dienstag, den 15.12.2020, 16:31 -0500 schrieb Leo Famulari: > On Tue, Dec 15, 2020 at 08:55:17AM +0100, Leo Prikler wrote: > > Am Dienstag, den 15.12.2020, 02:25 -0500 schrieb Leo Famulari: > > > Do we do this to save space? Or to avoid the rest of the bad > > > plugins? > > Both would be valid reasons to do this imo. Adding more bad > > plugins is > > likely also not going to increase the number of features Pitivi > > offers. > > This is a good idea for the "bad" plugins, because they are rarely > used > in Guix, so there is less chance of unecessary duplication compared > to > the other collections of GStreamer plugins. There is sadly still a lot of duplication between a plugin "selection" and its base package, so the option will have to be used sparingly. The reason why I opted for writing a procedure, that redoes the whole build rather than just copying some shared libraries, is because I don't think the latter would be particularly safe to do. Perhaps I'm wrong on that, however. > Still, it increases complexity, and it sholud be "worth it" in some > sense. If gst-plugins/selection becomes popular, it may be that the > increase in package objects outweighs the disk space savings — the > package graph may grow so large that it slows Guix package operations > down too much. The disk space savings may be obviated in that case, > anyways. I think it's only "worth it" when importing not more than two or three plugins from "bad" or "ugly". Even then the savings are only moderate, as gstreamer will still build what it deems to be absolutely necessary. To be completely honest, I also don't expect this to be around for too long. I am more than happy to see this procedure vanish at some point when we have parameters, though maybe that'd be a very Gentoo-y way of using parameters and still suffer from the same problem. > If you choose to apply for commit access, as I suggested, you will be > able to use your judgement here :) Sounds like it slowly gets time to take this serious and apply for commit access, then. I'll try to get that done soon-ish™. Regards, Leo