From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id 2IXyDupz2WI8JQAAbAwnHQ (envelope-from ) for ; Thu, 21 Jul 2022 17:42:34 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id iMYgDupz2WI6jwAAG6o9tA (envelope-from ) for ; Thu, 21 Jul 2022 17:42:34 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 03EEC3DA8D for ; Thu, 21 Jul 2022 17:42:34 +0200 (CEST) Received: from localhost ([::1]:42452 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oEYJt-0007IU-64 for larch@yhetil.org; Thu, 21 Jul 2022 11:42:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50246) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oEYEZ-0007qW-05 for guix-patches@gnu.org; Thu, 21 Jul 2022 11:37:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:48934) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oEYEY-0003VE-Mo for guix-patches@gnu.org; Thu, 21 Jul 2022 11:37:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oEYEY-0000Dg-Hy for guix-patches@gnu.org; Thu, 21 Jul 2022 11:37:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#56663] [PATCH 24/24]: gnu: just: New package. Resent-From: Jean Pierre De Jesus DIAZ Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 21 Jul 2022 15:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56663 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxime Devos Cc: "56663@debbugs.gnu.org" <56663@debbugs.gnu.org> Received: via spool by 56663-submit@debbugs.gnu.org id=B56663.1658417770769 (code B ref 56663); Thu, 21 Jul 2022 15:37:02 +0000 Received: (at 56663) by debbugs.gnu.org; 21 Jul 2022 15:36:10 +0000 Received: from localhost ([127.0.0.1]:38683 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oEYDi-0000CL-2j for submit@debbugs.gnu.org; Thu, 21 Jul 2022 11:36:10 -0400 Received: from mail-4323.proton.ch ([185.70.43.23]:20697) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oEYDc-0000Bk-9P for 56663@debbugs.gnu.org; Thu, 21 Jul 2022 11:36:08 -0400 Date: Thu, 21 Jul 2022 15:35:50 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jeandudey.tech; s=protonmail3; t=1658417757; x=1658676957; bh=4zDBKduso1vP3aSqPLbzuOwAZLmy+sIvboAwR/ZHBOo=; h=Date:To:From:Cc:Reply-To:Subject:Message-ID:In-Reply-To: References:Feedback-ID:From:To:Cc:Date:Subject:Reply-To: Feedback-ID:Message-ID; b=WM/QhHpn830xai6jsmnpq1Cjep4ghWPm8CiNVTd3vjOWpafEzm1q/EJoDSlnBDTcK I5w3kcajK6YgxZFwQPurYUgz7Hi2wggNaFryHaOAoYXujYgWcxJd4sq9iTrvZKn1ve KKqIHS301dPq6P5XQU3ZHC5Pcj/2veoj3St+YqPcWqIP6IkA2gasiSr8llMYfa59Rr 1TlwiDsWhrVwa0JRPHgGAbCI1L5yFyv6mvQelRihhazzdz2NeAXfFf3Wg1ezMkKsvA Kzc3nXnLzOe7zG5m1K8f4kKRAwAoHY/zliX4yQ2yPJwFroPOdNb9F61/NyRfOUjcRP Wi+zEmANlMSJA== Message-ID: In-Reply-To: References: Feedback-ID: 20187791:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: Jean Pierre De Jesus DIAZ X-ACL-Warn: , Jean Pierre De Jesus DIAZ via Guix-patches From: Jean Pierre De Jesus DIAZ via Guix-patches via X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1658418154; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=4zDBKduso1vP3aSqPLbzuOwAZLmy+sIvboAwR/ZHBOo=; b=gwOci7IngUqKEE8Guho1HakX0yFP4ToIODz5PhNGtkvzXbTRSLifqdBY9i1SWCqE+XWF8E XRghY2QehtboD+XCHcmzunShG+36YSeWleflx3DXBGLyuFNg2tl9rS21B4LTb9E/xh3n17 eWVaoZr9+sPz2aPI/ZyyhJZbz1ASavDdQ9tlh4LeI9fIiMdvan3DhU0SWNIMdwfZuKOigi aY4UYDyouFREqGSECngUg1D8vOxgkMFRHcHSmQuNvb/6oeOXvk+HTpDrEbY97RQFLOZ7xl Svl180oLOOpgvUDFG2IMvhFSMBrQFKKYjJVvzqwmNBFWu9Izn4ei8A4vhyXGaQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1658418154; a=rsa-sha256; cv=none; b=VBiGfofqZlRs1BwFJIT4Rl375KGs+z93Ra7cuciU6wVTCaEgYzRd17t20GpdLFHA6yTb0o D0XSMx0IONd7fxIKwDSEivmssDA1/hal4wixK0rgzJESCCGvA8zHEMLCwu9L2BeZcJgrw+ H9uv0T5kWHrbYl6jX95w/6YlDvR6GkAsp1SuPSoNS2c4yvh/eH7CfXGGex/IEEIfZAcaN9 JNimuBmcW12AqM9PZDG/QvVxTZQkqsPuXsrW7ZZU1Pnw/tloD8KnpPAXpORBZZyl9w1F1M L4rWEh7OMRE5j/sJAZ9aiF4xzj0tCXQ4d1iDthc+ucH94F/IWVvpTnIGrhVSWg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=jeandudey.tech header.s=protonmail3 header.b="WM/QhHpn"; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.44 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=jeandudey.tech header.s=protonmail3 header.b="WM/QhHpn"; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 03EEC3DA8D X-Spam-Score: -3.44 X-Migadu-Scanner: scn0.migadu.com X-TUID: pvqFe1MXXG6u >On 20-07-2022 14:22, Jean Pierre De Jesus DIAZ via Guix-patches via >wrote= : >> Empty Message >https://github.com/casey/temptree An error on my side. Did not attach the patch (ProtonMail doesn't support SMTP in order to use git send-email, I'm still porting their bridge program to GNU Guix). >Why are all these tests skipped? Most of these tests are tests specific to test shebang code, but are hard coded to use `#!/usr/bin/env ', some of these tests could be changed though. Didn't make patches for that because of the added maintenance effort but will do so. >FWIW, I can confirm I got the same hash in some code I haven't submitted yet (antioxidant). Would be great if upstreamed to GNU Guix and one less patch on this series :-). And great work on antioxidant, tried to make each crate on this patch series build-able so in the future switching/using antioxidant-build-system is easier. I have also started to test various crates to remove `#:skip-build? #f' as much as possible from gnu/packages/crates-io.scm. >+ `(substitute* "Cargo.toml" >+ ;; Relax quote version. >+ (("1\\.0\\.10") "1"))))) > >Nice, though ` -> ' or #~ will do. Thought of using G-Expressions but as it isn't used on crates-io.scm yet didn't want to change the convention there. Would be you okay if I use '? >[rust-cradle-0.2] > >+ (inputs >+ (list coreutils >+ which > >AFAICT coreutils, which and xxd aren't used. Are required by the tests which is why I added these packages. These are mostly used on documentation tests but the author of the crate did not mark these as no_run so they run on the 'check phase, and there's no easy way to disable documentation tests or skip specific ones. I'll try to make some patches to make some of these tests to not run. Thanks for the review! Will update accordingly. =E2=80=94 Jean-Pierre De Jesus DIAZ