From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id xWokMiSYg2TAzgAASxT56A (envelope-from ) for ; Fri, 09 Jun 2023 23:22:44 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id 2I9IMSSYg2TxdAEAauVa8A (envelope-from ) for ; Fri, 09 Jun 2023 23:22:44 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A4F3E13EC3 for ; Fri, 9 Jun 2023 23:22:44 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q7jYa-00062D-DI; Fri, 09 Jun 2023 17:22:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q7jYY-00061Q-1u for guix-patches@gnu.org; Fri, 09 Jun 2023 17:22:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q7jYX-0007PO-Oy for guix-patches@gnu.org; Fri, 09 Jun 2023 17:22:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q7jYX-0000Vb-KO for guix-patches@gnu.org; Fri, 09 Jun 2023 17:22:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#63985] [PATCH RFC 1/5] services: configuration: Simplify normalize-extra-args. Resent-From: Bruno Victal Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 09 Jun 2023 21:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63985 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 63985@debbugs.gnu.org Cc: Bruno Victal Received: via spool by 63985-submit@debbugs.gnu.org id=B63985.16863456721860 (code B ref 63985); Fri, 09 Jun 2023 21:22:01 +0000 Received: (at 63985) by debbugs.gnu.org; 9 Jun 2023 21:21:12 +0000 Received: from localhost ([127.0.0.1]:32875 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q7jXk-0000Tw-Ht for submit@debbugs.gnu.org; Fri, 09 Jun 2023 17:21:12 -0400 Received: from smtpmciv1.myservices.hosting ([185.26.107.237]:59346) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q7jXi-0000To-UQ for 63985@debbugs.gnu.org; Fri, 09 Jun 2023 17:21:11 -0400 Received: from mail1.netim.hosting (unknown [185.26.106.173]) by smtpmciv1.myservices.hosting (Postfix) with ESMTP id 36F1020CD0 for <63985@debbugs.gnu.org>; Fri, 9 Jun 2023 23:21:09 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by mail1.netim.hosting (Postfix) with ESMTP id 7E79F8009B; Fri, 9 Jun 2023 23:21:09 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at mail1.netim.hosting Received: from mail1.netim.hosting ([127.0.0.1]) by localhost (mail1-2.netim.hosting [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id cshjM1svIMQ5; Fri, 9 Jun 2023 23:21:09 +0200 (CEST) Received: from guix-nuc.home.arpa (unknown [10.192.1.83]) (Authenticated sender: lumen@makinata.eu) by mail1.netim.hosting (Postfix) with ESMTPSA id B6D6080098; Fri, 9 Jun 2023 23:21:08 +0200 (CEST) From: Bruno Victal Date: Fri, 9 Jun 2023 22:20:56 +0100 Message-Id: X-Mailer: git-send-email 2.39.2 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1686345764; a=rsa-sha256; cv=none; b=cPGcxuA+lkVZZEI8SoYBRqWnm7QKDFV8SMuuPul4BiIdcsc97ioW/75G/ditaFRm2jHQ5+ gIj2PvDjGywvFSYO6OdTabqsFo0FMP82nkSaHEh8lrg5F4ByJVstQzvsgkSMvIRTHl2LPU ZGF9CPUH1sjUxNeHxHAwg/4EF5ehLv9+O7vZ6fDedYI6bKeEsE/0R+Z/T/gH0kiLeL+xiD cXzsiIk5I9cRy7EO9cuEa7nEtw5bTIg7PcXsiXp2v7hfFwylsBZ0BzkIrfsy7F6UtU5ths EGmz7uG98M/NwFlzvzwG/27cJ4NhlHQSYF33OCrM0RRXFrDiBEmiyvT7pPy7CA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1686345764; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=UO78rHU+3WruCB+eWLGFU/jCriGX3yHDJzayPJBmHL0=; b=XpsNCVmVxLEL7UJdnsoM1+AySKcVr/am3Kob+CGoSNAuIzAIwDJKhIzmUOZVqDFykqE43/ Lonj0Rf1T3Vu5kD5nvRsGOJWbgUiPJHNzJMg3Dj563qcMgQdWS2RU6IcdIARg4js68qBcF 2eV1/VisaYLAO1iqxwPGhyXFZ2eIemk8UOSSaEsELe0eGKCCMmNgaQILDyc13VGKkqwvHe hRw6kDlFlS/S5fFyKfANMBNFerU2Csr8UQijfMD79ym/AoO3MTmwAKzFr1Z+VaWodojTlK b1mljGfR2/5HGZHNkTDasqvDgVVXQorubY9hkJ5kwho3hPDroVViuKKfONNtmQ== Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Scanner: scn0.migadu.com X-Migadu-Spam-Score: -2.21 X-Spam-Score: -2.21 X-Migadu-Queue-Id: A4F3E13EC3 X-TUID: Ky39416e4eft * gnu/services/configuration.scm (define-configuration-helper, normalize-extra-args): Use #f instead of %unset-value. --- gnu/services/configuration.scm | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/gnu/services/configuration.scm b/gnu/services/configuration.scm index 367b85c1be..dafe72f4fe 100644 --- a/gnu/services/configuration.scm +++ b/gnu/services/configuration.scm @@ -190,32 +190,32 @@ (define (define-configuration-helper serialize? serializer-prefix syn) (define (normalize-extra-args s) "Extract and normalize arguments following @var{doc}." (let loop ((s s) - (sanitizer* %unset-value) - (serializer* %unset-value)) + (sanitizer* #f) + (serializer* #f)) (syntax-case s (sanitizer serializer empty-serializer) (((sanitizer proc) tail ...) - (if (maybe-value-set? sanitizer*) - (syntax-violation 'sanitizer "duplicate entry" - #'proc) + (if sanitizer* + (syntax-violation 'sanitizer + "duplicate entry" #'proc) (loop #'(tail ...) #'proc serializer*))) (((serializer proc) tail ...) - (if (maybe-value-set? serializer*) - (syntax-violation 'serializer "duplicate or conflicting entry" - #'proc) + (if serializer* + (syntax-violation 'serializer + "duplicate or conflicting entry" #'proc) (loop #'(tail ...) sanitizer* #'proc))) ((empty-serializer tail ...) - (if (maybe-value-set? serializer*) + (if serializer* (syntax-violation 'empty-serializer "duplicate or conflicting entry" #f) (loop #'(tail ...) sanitizer* #'empty-serializer))) (() ; stop condition (values (list sanitizer* serializer*))) ((proc) ; TODO: deprecated, to be removed. - (null? (filter-map maybe-value-set? (list sanitizer* serializer*))) + (every not (list sanitizer* serializer*)) (begin (warning #f (G_ "specifying serializers after documentation is \ deprecated, use (serializer ~a) instead~%") (syntax->datum #'proc)) - (values (list %unset-value #'proc))))))) + (values (list #f #'proc))))))) (syntax-case syn () ((_ stem (field field-type+def doc extra-args ...) ...) @@ -239,11 +239,11 @@ (define (define-configuration-helper serialize? serializer-prefix syn) default-value)) #'((field-type def) ...))) ((field-sanitizer ...) - (map maybe-value #'(sanitizer* ...))) + #'(sanitizer* ...)) ((field-serializer ...) (map (lambda (type proc) (and serialize? - (or (maybe-value proc) + (or proc (if serializer-prefix (id #'stem serializer-prefix #'serialize- type) (id #'stem #'serialize- type))))) base-commit: c348b1be3891e6eb47bbdd9fc1587aba2b6ab0b7 -- 2.39.2