unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "yarl baudig" <yarl-baudig@mailoo.org>
To: mail@nicolasgoaziou.fr
Cc: 59354@debbugs.gnu.org
Subject: [bug#59354] [PATCH] gnu: Add texlive-mathdots.
Date: Sat, 19 Nov 2022 16:02:10 +0100 (CET)	[thread overview]
Message-ID: <ea-mime-6378eff2-131f-54b06da5@www.mailo.com> (raw)
In-Reply-To: <87iljbp9wo.fsf@nicolasgoaziou.fr>

Hello,

> Thank you. Some comments follow.
> 
> > +  (package
> > +    (inherit (simple-texlive-package
> > +	      "texlive-mathdots"
> 
> Indentation looks wrong here.
I am not sure how it's wrong. Path will follow. Is it better?

> 
> > +              (list "doc/generic/mathdots/"
> > +                    "source/generic/mathdots/"
> > +                    "tex/generic/mathdots/")
> > +              (base32
> > +               "1jaffj343p1chdxs2g7s6lpckvihk0jfw22nw0vmijyjxfiy9yg0")
> > +	      #:trivial? #t))
> 
> This doesn't look like a trivial package since it contains a ".ins"
> file. You need to generate the ".tex" and ".sty" files from it.
> 
I think it is, "tex/generic/mathdots/" in tug repo contains ".tex" and ".sty" and if I compile, they are here.
First texlive package I package. I tried `guix import texlive mathdots` then amended by looking at other texlive packages. Please show me if I am wrong.

> > +   (home-page "https://ctan.org/macros/generic/mathdots")
> > +   (synopsis "Commands to produce dots in math that respect font size")
> > +   (description
> > +    "Redefines \\ddots and \\vdots, and defines \\iddots.  The dots 
> produced by \\iddots
> 
> The first sentence should contain a subject. Also \\ddots ->
> @code{\\dots}
> 
> Could you send an updated patch?
> 
> Regards,
> -- 
> Nicolas Goaziou
> 

Patch is coming, please tell me if it good.







  reply	other threads:[~2022-11-19 15:03 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-18 10:20 [bug#59354] [PATCH] gnu: Add texlive-mathdots Yarl Baudig
2022-11-19  9:32 ` Nicolas Goaziou
2022-11-19 15:02   ` yarl baudig [this message]
2022-11-20 15:47     ` Nicolas Goaziou
2022-11-20 16:24       ` yarl baudig
2022-11-20 16:46         ` Nicolas Goaziou
2022-11-20 17:16           ` yarl baudig
2022-11-19 15:02 ` yarl baudig
2022-11-21 14:16 ` Yarl Baudig
2022-11-21 22:21   ` bug#59354: " Nicolas Goaziou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ea-mime-6378eff2-131f-54b06da5@www.mailo.com \
    --to=yarl-baudig@mailoo.org \
    --cc=59354@debbugs.gnu.org \
    --cc=mail@nicolasgoaziou.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).